All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Roman Zippel <zippel@linux-m68k.org>,
	Andreas Schwab <schwab@linux-m68k.org>,
	linux-m68k@vger.kernel.org
Subject: [PATCH v3 21/22] m68k: remove inline asm from minix_find_first_zero_bit
Date: Tue, 23 Nov 2010 22:38:23 +0900	[thread overview]
Message-ID: <1290519504-3958-22-git-send-email-akinobu.mita@gmail.com> (raw)
In-Reply-To: <1290519504-3958-1-git-send-email-akinobu.mita@gmail.com>

As a preparation for moving minix bit operations from asm/bitops.h
to architecture independent code in minix file system, this removes
inline asm from minix_find_first_zero_bit() for m68k.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
---
No change from previous submission
 arch/m68k/include/asm/bitops_mm.h |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/arch/m68k/include/asm/bitops_mm.h b/arch/m68k/include/asm/bitops_mm.h
index 831d626..f31ed5a 100644
--- a/arch/m68k/include/asm/bitops_mm.h
+++ b/arch/m68k/include/asm/bitops_mm.h
@@ -330,23 +330,19 @@ static inline int __fls(int x)
 static inline int minix_find_first_zero_bit(const void *vaddr, unsigned size)
 {
 	const unsigned short *p = vaddr, *addr = vaddr;
-	int res;
 	unsigned short num;
 
 	if (!size)
 		return 0;
 
 	size = (size >> 4) + ((size & 15) > 0);
-	while (*p++ == 0xffff)
-	{
+	while (*p++ == 0xffff) {
 		if (--size == 0)
 			return (p - addr) << 4;
 	}
 
-	num = ~*--p;
-	__asm__ __volatile__ ("bfffo %1{#16,#16},%0"
-			      : "=d" (res) : "d" (num & -num));
-	return ((p - addr) << 4) + (res ^ 31);
+	num = *--p;
+	return ((p - addr) << 4) + ffz(num);
 }
 
 #define minix_test_and_set_bit(nr, addr)	__test_and_set_bit((nr) ^ 16, (unsigned long *)(addr))
-- 
1.7.3.2


WARNING: multiple messages have this Message-ID (diff)
From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Roman Zippel <zippel@linux-m68k.org>,
	Andreas Schwab <schwab@linux-m68k.org>,
	linux-m68k@lists.linux-m68k.org
Subject: [PATCH v3 21/22] m68k: remove inline asm from minix_find_first_zero_bit
Date: Tue, 23 Nov 2010 22:38:23 +0900	[thread overview]
Message-ID: <1290519504-3958-22-git-send-email-akinobu.mita@gmail.com> (raw)
In-Reply-To: <1290519504-3958-1-git-send-email-akinobu.mita@gmail.com>

As a preparation for moving minix bit operations from asm/bitops.h
to architecture independent code in minix file system, this removes
inline asm from minix_find_first_zero_bit() for m68k.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Roman Zippel <zippel@linux-m68k.org>
Cc: Andreas Schwab <schwab@linux-m68k.org>
Cc: linux-m68k@lists.linux-m68k.org
---
No change from previous submission
 arch/m68k/include/asm/bitops_mm.h |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/arch/m68k/include/asm/bitops_mm.h b/arch/m68k/include/asm/bitops_mm.h
index 831d626..f31ed5a 100644
--- a/arch/m68k/include/asm/bitops_mm.h
+++ b/arch/m68k/include/asm/bitops_mm.h
@@ -330,23 +330,19 @@ static inline int __fls(int x)
 static inline int minix_find_first_zero_bit(const void *vaddr, unsigned size)
 {
 	const unsigned short *p = vaddr, *addr = vaddr;
-	int res;
 	unsigned short num;
 
 	if (!size)
 		return 0;
 
 	size = (size >> 4) + ((size & 15) > 0);
-	while (*p++ == 0xffff)
-	{
+	while (*p++ == 0xffff) {
 		if (--size == 0)
 			return (p - addr) << 4;
 	}
 
-	num = ~*--p;
-	__asm__ __volatile__ ("bfffo %1{#16,#16},%0"
-			      : "=d" (res) : "d" (num & -num));
-	return ((p - addr) << 4) + (res ^ 31);
+	num = *--p;
+	return ((p - addr) << 4) + ffz(num);
 }
 
 #define minix_test_and_set_bit(nr, addr)	__test_and_set_bit((nr) ^ 16, (unsigned long *)(addr))
-- 
1.7.3.2

  parent reply	other threads:[~2010-11-23 13:40 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-23 13:38 [PATCH v3 00/22] Introduce little endian bitops Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 01/22] bitops: merge little and big endian definisions in asm-generic/bitops/le.h Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 02/22] bitops: rename generic little-endian bitops functions Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 03/22] s390: introduce little-endian bitops Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 04/22] arm: " Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 05/22] m68k: " Akinobu Mita
2010-11-23 13:38 ` Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 06/22] m68knommu: " Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-25  8:46   ` Akinobu Mita
2010-11-25  8:46   ` Akinobu Mita
2010-11-25  8:46     ` Akinobu Mita
2010-11-23 13:38 ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 07/22] bitops: introduce little-endian bitops for most architectures Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 08/22] rds: stop including asm-generic/bitops/le.h Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 09/22] kvm: " Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 10/22] asm-generic: use little-endian bitops Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 11/22] ext3: " Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 12/22] ext4: " Akinobu Mita
2010-11-23 19:29   ` Ted Ts'o
2010-11-23 13:38 ` [PATCH v3 13/22] ocfs2: " Akinobu Mita
2010-11-23 13:40   ` [Ocfs2-devel] " Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 14/22] nilfs2: " Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 15/22] reiserfs: " Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 16/22] udf: " Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 17/22] ufs: " Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 18/22] md: use little-endian bit operations Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 19/22] dm: " Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 20/22] bitops: remove ext2 non-atomic bitops from asm/bitops.h Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38 ` Akinobu Mita [this message]
2010-11-23 13:38   ` [PATCH v3 21/22] m68k: remove inline asm from minix_find_first_zero_bit Akinobu Mita
2010-11-23 13:38 ` [PATCH v3 22/22] bitops: remove minix bitops from asm/bitops.h Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-23 13:38   ` Akinobu Mita
2010-11-24  5:55   ` Paul Mundt
2010-11-24  5:55   ` Paul Mundt
2010-11-24  5:55     ` Paul Mundt
2010-11-24  5:55     ` Paul Mundt
2010-11-24 12:54   ` Ralf Baechle
2010-11-23 13:38 ` Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290519504-3958-22-git-send-email-akinobu.mita@gmail.com \
    --to=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=schwab@linux-m68k.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.