From: Sage Weil <sage@newdream.net> To: viro@ZenIV.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, hch@lst.de, Sage Weil <sage@newdream.net>, Mark Fasheh <mfasheh@suse.com>, ocfs2-devel@oss.oracle.com Subject: [PATCH 18/19] ocfs2: remove unnecessary dentry_unhash on rmdir/rename_dir Date: Tue, 24 May 2011 13:06:21 -0700 [thread overview] Message-ID: <1306267582-5347-19-git-send-email-sage@newdream.net> (raw) In-Reply-To: <1306267582-5347-1-git-send-email-sage@newdream.net> Ocfs2 has no issues with lingering references to unlinked directory inodes. CC: Mark Fasheh <mfasheh@suse.com> CC: ocfs2-devel@oss.oracle.com Acked-by: Joel Becker <jlbec@evilplan.org> Signed-off-by: Sage Weil <sage@newdream.net> --- fs/ocfs2/namei.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index f3582a6..e5d738c 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -810,9 +810,6 @@ static int ocfs2_unlink(struct inode *dir, (unsigned long long)OCFS2_I(dir)->ip_blkno, (unsigned long long)OCFS2_I(inode)->ip_blkno); - if (S_ISDIR(inode->i_mode)) - dentry_unhash(dentry); - dquot_initialize(dir); BUG_ON(dentry->d_parent->d_inode != dir); @@ -1066,9 +1063,6 @@ static int ocfs2_rename(struct inode *old_dir, struct ocfs2_dir_lookup_result orphan_insert = { NULL, }; struct ocfs2_dir_lookup_result target_insert = { NULL, }; - if (new_inode && S_ISDIR(new_inode->i_mode)) - dentry_unhash(new_dentry); - /* At some point it might be nice to break this function up a * bit. */ -- 1.7.0
WARNING: multiple messages have this Message-ID (diff)
From: Sage Weil <sage@newdream.net> To: viro@ZenIV.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, hch@lst.de, Sage Weil <sage@newdream.net>, Mark Fasheh <mfasheh@suse.com>, ocfs2-devel@oss.oracle.com Subject: [Ocfs2-devel] [PATCH 18/19] ocfs2: remove unnecessary dentry_unhash on rmdir/rename_dir Date: Tue, 24 May 2011 13:06:21 -0700 [thread overview] Message-ID: <1306267582-5347-19-git-send-email-sage@newdream.net> (raw) In-Reply-To: <1306267582-5347-1-git-send-email-sage@newdream.net> Ocfs2 has no issues with lingering references to unlinked directory inodes. CC: Mark Fasheh <mfasheh@suse.com> CC: ocfs2-devel at oss.oracle.com Acked-by: Joel Becker <jlbec@evilplan.org> Signed-off-by: Sage Weil <sage@newdream.net> --- fs/ocfs2/namei.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c index f3582a6..e5d738c 100644 --- a/fs/ocfs2/namei.c +++ b/fs/ocfs2/namei.c @@ -810,9 +810,6 @@ static int ocfs2_unlink(struct inode *dir, (unsigned long long)OCFS2_I(dir)->ip_blkno, (unsigned long long)OCFS2_I(inode)->ip_blkno); - if (S_ISDIR(inode->i_mode)) - dentry_unhash(dentry); - dquot_initialize(dir); BUG_ON(dentry->d_parent->d_inode != dir); @@ -1066,9 +1063,6 @@ static int ocfs2_rename(struct inode *old_dir, struct ocfs2_dir_lookup_result orphan_insert = { NULL, }; struct ocfs2_dir_lookup_result target_insert = { NULL, }; - if (new_inode && S_ISDIR(new_inode->i_mode)) - dentry_unhash(new_dentry); - /* At some point it might be nice to break this function up a * bit. */ -- 1.7.0
next prev parent reply other threads:[~2011-05-24 19:43 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-05-24 20:06 [PATCH 00/19] Do not dentry_unhash in VFS (v3) Sage Weil 2011-05-24 20:06 ` [PATCH 01/19] vfs: dentry_unhash immediately prior to rmdir Sage Weil 2011-05-24 20:06 ` [PATCH 02/19] vfs: remove dget() from dentry_unhash() Sage Weil 2011-05-24 20:06 ` [PATCH 03/19] vfs: push dentry_unhash on rmdir into file systems Sage Weil 2011-05-24 20:06 ` [PATCH 04/19] vfs: push dentry_unhash on rename_dir " Sage Weil 2011-05-24 20:06 ` [PATCH 05/19] vfs: update dentry_unhash() comment Sage Weil 2011-05-24 20:06 ` [PATCH 06/19] libfs: drop unneeded dentry_unhash Sage Weil 2011-05-24 20:06 ` [PATCH 07/19] vfs: fix vfs_rename_dir for FS_RENAME_DOES_D_MOVE filesystems Sage Weil 2011-05-24 20:06 ` [PATCH 08/19] vfs: clean up vfs_rmdir Sage Weil 2011-05-24 20:06 ` [PATCH 09/19] vfs: clean up vfs_rename_dir Sage Weil 2011-05-24 20:06 ` [PATCH 10/19] vfs: clean up vfs_rename_other Sage Weil 2011-05-24 20:06 ` [PATCH 11/19] ceph: remove unnecessary dentry_unhash calls Sage Weil 2011-05-24 20:06 ` [PATCH 12/19] btrfs: remove unnecessary dentry_unhash in rmdir/rename_dir Sage Weil 2011-05-24 20:06 ` [PATCH 13/19] ext4: remove unnecessary dentry_unhash on rmdir/rename_dir Sage Weil 2011-05-24 20:06 ` [PATCH 14/19] ext3: " Sage Weil 2011-05-24 20:38 ` Jan Kara 2011-05-24 23:57 ` Sage Weil 2011-05-25 2:44 ` Yongqiang Yang 2011-05-25 3:44 ` Sage Weil 2011-05-24 20:06 ` [PATCH 15/19] ext2: " Sage Weil [not found] ` <1306267582-5347-1-git-send-email-sage-BnTBU8nroG7k1uMJSBkQmQ@public.gmane.org> 2011-05-24 20:06 ` [PATCH 16/19] nfs: " Sage Weil 2011-05-24 20:06 ` Sage Weil 2011-05-24 20:06 ` [PATCH 17/19] exofs: " Sage Weil 2011-05-24 20:06 ` Sage Weil [this message] 2011-05-24 20:06 ` [Ocfs2-devel] [PATCH 18/19] ocfs2: " Sage Weil 2011-05-24 20:06 ` [PATCH 19/19] cifs: " Sage Weil 2011-05-27 9:46 ` [PATCH 00/19] Do not dentry_unhash in VFS (v3) Christoph Hellwig 2011-05-27 14:15 ` Jan Kara 2011-05-27 19:11 ` Sage Weil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1306267582-5347-19-git-send-email-sage@newdream.net \ --to=sage@newdream.net \ --cc=hch@lst.de \ --cc=linux-fsdevel@vger.kernel.org \ --cc=mfasheh@suse.com \ --cc=ocfs2-devel@oss.oracle.com \ --cc=viro@ZenIV.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.