From: <Codrin.Ciubotariu@microchip.com>
To: <colin.king@canonical.com>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <alsa-devel@alsa-project.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned
Date: Wed, 25 Mar 2020 15:03:32 +0000 [thread overview]
Message-ID: <130efce3-5a04-a813-062b-79f8b4284db8@microchip.com> (raw)
In-Reply-To: <20200325132913.110115-1-colin.king@canonical.com>
On 25.03.2020 15:29, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The signed 1 bit bitfields should be unsigned, so make them unsigned.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks!
> ---
> sound/soc/atmel/mchp-i2s-mcc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/atmel/mchp-i2s-mcc.c b/sound/soc/atmel/mchp-i2s-mcc.c
> index befc2a3a05b0..3cb63886195f 100644
> --- a/sound/soc/atmel/mchp-i2s-mcc.c
> +++ b/sound/soc/atmel/mchp-i2s-mcc.c
> @@ -239,10 +239,10 @@ struct mchp_i2s_mcc_dev {
> unsigned int frame_length;
> int tdm_slots;
> int channels;
> - int gclk_use:1;
> - int gclk_running:1;
> - int tx_rdy:1;
> - int rx_rdy:1;
> + unsigned int gclk_use:1;
> + unsigned int gclk_running:1;
> + unsigned int tx_rdy:1;
> + unsigned int rx_rdy:1;
> };
>
> static irqreturn_t mchp_i2s_mcc_interrupt(int irq, void *dev_id)
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: <Codrin.Ciubotariu@microchip.com>
To: colin.king@canonical.com, lgirdwood@gmail.com,
broonie@kernel.org, perex@perex.cz, tiwai@suse.com,
Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com,
Ludovic.Desroches@microchip.com, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned
Date: Wed, 25 Mar 2020 15:03:32 +0000 [thread overview]
Message-ID: <130efce3-5a04-a813-062b-79f8b4284db8@microchip.com> (raw)
In-Reply-To: <20200325132913.110115-1-colin.king@canonical.com>
T24gMjUuMDMuMjAyMCAxNToyOSwgQ29saW4gS2luZyB3cm90ZToNCj4gRnJvbTogQ29saW4gSWFu
IEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNvbT4NCj4gDQo+IFRoZSBzaWduZWQgMSBiaXQg
Yml0ZmllbGRzIHNob3VsZCBiZSB1bnNpZ25lZCwgc28gbWFrZSB0aGVtIHVuc2lnbmVkLg0KPiAN
Cj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fub25pY2FsLmNv
bT4NCg0KUmV2aWV3ZWQtYnk6IENvZHJpbiBDaXVib3Rhcml1IDxjb2RyaW4uY2l1Ym90YXJpdUBt
aWNyb2NoaXAuY29tPg0KDQpUaGFua3MhDQoNCj4gLS0tDQo+ICAgc291bmQvc29jL2F0bWVsL21j
aHAtaTJzLW1jYy5jIHwgOCArKysrLS0tLQ0KPiAgIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlv
bnMoKyksIDQgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0IGEvc291bmQvc29jL2F0bWVs
L21jaHAtaTJzLW1jYy5jIGIvc291bmQvc29jL2F0bWVsL21jaHAtaTJzLW1jYy5jDQo+IGluZGV4
IGJlZmMyYTNhMDViMC4uM2NiNjM4ODYxOTVmIDEwMDY0NA0KPiAtLS0gYS9zb3VuZC9zb2MvYXRt
ZWwvbWNocC1pMnMtbWNjLmMNCj4gKysrIGIvc291bmQvc29jL2F0bWVsL21jaHAtaTJzLW1jYy5j
DQo+IEBAIC0yMzksMTAgKzIzOSwxMCBAQCBzdHJ1Y3QgbWNocF9pMnNfbWNjX2RldiB7DQo+ICAg
ICAgICAgIHVuc2lnbmVkIGludCAgICAgICAgICAgICAgICAgICAgICAgICAgICBmcmFtZV9sZW5n
dGg7DQo+ICAgICAgICAgIGludCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB0
ZG1fc2xvdHM7DQo+ICAgICAgICAgIGludCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICBjaGFubmVsczsNCj4gLSAgICAgICBpbnQgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgZ2Nsa191c2U6MTsNCj4gLSAgICAgICBpbnQgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgZ2Nsa19ydW5uaW5nOjE7DQo+IC0gICAgICAgaW50ICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgIHR4X3JkeToxOw0KPiAtICAgICAgIGludCAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICByeF9yZHk6MTsNCj4gKyAgICAgICB1bnNpZ25l
ZCBpbnQgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2Nsa191c2U6MTsNCj4gKyAgICAgICB1
bnNpZ25lZCBpbnQgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ2Nsa19ydW5uaW5nOjE7DQo+
ICsgICAgICAgdW5zaWduZWQgaW50ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHR4X3JkeTox
Ow0KPiArICAgICAgIHVuc2lnbmVkIGludCAgICAgICAgICAgICAgICAgICAgICAgICAgICByeF9y
ZHk6MTsNCj4gICB9Ow0KPiANCj4gICBzdGF0aWMgaXJxcmV0dXJuX3QgbWNocF9pMnNfbWNjX2lu
dGVycnVwdChpbnQgaXJxLCB2b2lkICpkZXZfaWQpDQo+IC0tDQo+IDIuMjUuMQ0KPiANCg=
WARNING: multiple messages have this Message-ID (diff)
From: <Codrin.Ciubotariu@microchip.com>
To: <colin.king@canonical.com>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <alsa-devel@alsa-project.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned
Date: Wed, 25 Mar 2020 15:03:32 +0000 [thread overview]
Message-ID: <130efce3-5a04-a813-062b-79f8b4284db8@microchip.com> (raw)
In-Reply-To: <20200325132913.110115-1-colin.king@canonical.com>
On 25.03.2020 15:29, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The signed 1 bit bitfields should be unsigned, so make them unsigned.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks!
> ---
> sound/soc/atmel/mchp-i2s-mcc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/atmel/mchp-i2s-mcc.c b/sound/soc/atmel/mchp-i2s-mcc.c
> index befc2a3a05b0..3cb63886195f 100644
> --- a/sound/soc/atmel/mchp-i2s-mcc.c
> +++ b/sound/soc/atmel/mchp-i2s-mcc.c
> @@ -239,10 +239,10 @@ struct mchp_i2s_mcc_dev {
> unsigned int frame_length;
> int tdm_slots;
> int channels;
> - int gclk_use:1;
> - int gclk_running:1;
> - int tx_rdy:1;
> - int rx_rdy:1;
> + unsigned int gclk_use:1;
> + unsigned int gclk_running:1;
> + unsigned int tx_rdy:1;
> + unsigned int rx_rdy:1;
> };
>
> static irqreturn_t mchp_i2s_mcc_interrupt(int irq, void *dev_id)
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: <Codrin.Ciubotariu@microchip.com>
To: <colin.king@canonical.com>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <perex@perex.cz>, <tiwai@suse.com>,
<Nicolas.Ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<Ludovic.Desroches@microchip.com>, <alsa-devel@alsa-project.org>,
<linux-arm-kernel@lists.infradead.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned
Date: Wed, 25 Mar 2020 15:03:32 +0000 [thread overview]
Message-ID: <130efce3-5a04-a813-062b-79f8b4284db8@microchip.com> (raw)
In-Reply-To: <20200325132913.110115-1-colin.king@canonical.com>
On 25.03.2020 15:29, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The signed 1 bit bitfields should be unsigned, so make them unsigned.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Thanks!
> ---
> sound/soc/atmel/mchp-i2s-mcc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/atmel/mchp-i2s-mcc.c b/sound/soc/atmel/mchp-i2s-mcc.c
> index befc2a3a05b0..3cb63886195f 100644
> --- a/sound/soc/atmel/mchp-i2s-mcc.c
> +++ b/sound/soc/atmel/mchp-i2s-mcc.c
> @@ -239,10 +239,10 @@ struct mchp_i2s_mcc_dev {
> unsigned int frame_length;
> int tdm_slots;
> int channels;
> - int gclk_use:1;
> - int gclk_running:1;
> - int tx_rdy:1;
> - int rx_rdy:1;
> + unsigned int gclk_use:1;
> + unsigned int gclk_running:1;
> + unsigned int tx_rdy:1;
> + unsigned int rx_rdy:1;
> };
>
> static irqreturn_t mchp_i2s_mcc_interrupt(int irq, void *dev_id)
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-25 15:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 13:29 [PATCH] ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned Colin King
2020-03-25 13:29 ` Colin King
2020-03-25 15:03 ` Codrin.Ciubotariu [this message]
2020-03-25 15:03 ` Codrin.Ciubotariu
2020-03-25 15:03 ` Codrin.Ciubotariu
2020-03-25 15:03 ` Codrin.Ciubotariu
2020-03-25 21:51 ` Applied "ASoC: mchp-i2s-mcc: make signed 1 bit bitfields unsigned" to the asoc tree Mark Brown
2020-03-25 21:51 ` Mark Brown
2020-03-25 21:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=130efce3-5a04-a813-062b-79f8b4284db8@microchip.com \
--to=codrin.ciubotariu@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.