From: Dong Aisheng <b29396@freescale.com>
To: alsa-devel@alsa-project.org
Cc: s.hauer@pengutronix.de, broonie@opensource.wolfsonmicro.com,
lrg@ti.com, linux-arm-kernel@lists.infradead.org,
u.kleine-koenig@pengutronix.de
Subject: [PATCH v3 10/10] ARM: mxs-dma: include <linux/dmaengine.h>
Date: Fri, 15 Jul 2011 20:09:40 +0800 [thread overview]
Message-ID: <1310731780-1645-11-git-send-email-b29396@freescale.com> (raw)
In-Reply-To: <1310731780-1645-1-git-send-email-b29396@freescale.com>
Other files using dma.h may fail to compile as follows:
In file included from sound/soc/mxs/mxs-pcm.h:22,
from sound/soc/mxs/mxs-saif.h:112,
from sound/soc/mxs/mxs-sgtl5000.c:34:
arch/arm/mach-mxs/include/mach/dma.h:16: warning: 'struct dma_chan' declared inside parameter list
arch/arm/mach-mxs/include/mach/dma.h:16: warning: its scope is only this definition or declaration, which is probably not what you want
arch/arm/mach-mxs/include/mach/dma.h: In function 'mxs_dma_is_apbh':
arch/arm/mach-mxs/include/mach/dma.h:18: error: dereferencing pointer to incomplete type
arch/arm/mach-mxs/include/mach/dma.h: At top level:
arch/arm/mach-mxs/include/mach/dma.h:21: warning: 'struct dma_chan' declared inside parameter list
arch/arm/mach-mxs/include/mach/dma.h: In function 'mxs_dma_is_apbx':
arch/arm/mach-mxs/include/mach/dma.h:23: error: dereferencing pointer to incomplete type
make[3]: *** [sound/soc/mxs/mxs-sgtl5000.o] Error 1
make[2]: *** [sound/soc/mxs] Error 2
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2
It seems it's better for dma.h to include dmaengine.h himself.
Signed-off-by: Dong Aisheng <b29396@freescale.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
---
arch/arm/mach-mxs/include/mach/dma.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mxs/include/mach/dma.h b/arch/arm/mach-mxs/include/mach/dma.h
index 7f4aeea..203d7c4 100644
--- a/arch/arm/mach-mxs/include/mach/dma.h
+++ b/arch/arm/mach-mxs/include/mach/dma.h
@@ -9,6 +9,8 @@
#ifndef __MACH_MXS_DMA_H__
#define __MACH_MXS_DMA_H__
+#include <linux/dmaengine.h>
+
struct mxs_dma_data {
int chan_irq;
};
--
1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: b29396@freescale.com (Dong Aisheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 10/10] ARM: mxs-dma: include <linux/dmaengine.h>
Date: Fri, 15 Jul 2011 20:09:40 +0800 [thread overview]
Message-ID: <1310731780-1645-11-git-send-email-b29396@freescale.com> (raw)
In-Reply-To: <1310731780-1645-1-git-send-email-b29396@freescale.com>
Other files using dma.h may fail to compile as follows:
In file included from sound/soc/mxs/mxs-pcm.h:22,
from sound/soc/mxs/mxs-saif.h:112,
from sound/soc/mxs/mxs-sgtl5000.c:34:
arch/arm/mach-mxs/include/mach/dma.h:16: warning: 'struct dma_chan' declared inside parameter list
arch/arm/mach-mxs/include/mach/dma.h:16: warning: its scope is only this definition or declaration, which is probably not what you want
arch/arm/mach-mxs/include/mach/dma.h: In function 'mxs_dma_is_apbh':
arch/arm/mach-mxs/include/mach/dma.h:18: error: dereferencing pointer to incomplete type
arch/arm/mach-mxs/include/mach/dma.h: At top level:
arch/arm/mach-mxs/include/mach/dma.h:21: warning: 'struct dma_chan' declared inside parameter list
arch/arm/mach-mxs/include/mach/dma.h: In function 'mxs_dma_is_apbx':
arch/arm/mach-mxs/include/mach/dma.h:23: error: dereferencing pointer to incomplete type
make[3]: *** [sound/soc/mxs/mxs-sgtl5000.o] Error 1
make[2]: *** [sound/soc/mxs] Error 2
make[1]: *** [sound/soc] Error 2
make: *** [sound] Error 2
It seems it's better for dma.h to include dmaengine.h himself.
Signed-off-by: Dong Aisheng <b29396@freescale.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Shawn Guo <shawn.guo@linaro.org>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
---
arch/arm/mach-mxs/include/mach/dma.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mxs/include/mach/dma.h b/arch/arm/mach-mxs/include/mach/dma.h
index 7f4aeea..203d7c4 100644
--- a/arch/arm/mach-mxs/include/mach/dma.h
+++ b/arch/arm/mach-mxs/include/mach/dma.h
@@ -9,6 +9,8 @@
#ifndef __MACH_MXS_DMA_H__
#define __MACH_MXS_DMA_H__
+#include <linux/dmaengine.h>
+
struct mxs_dma_data {
int chan_irq;
};
--
1.7.0.4
next prev parent reply other threads:[~2011-07-15 11:45 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-15 12:09 [PATCH v3 00/10] ARM: mxs: add audio support Dong Aisheng
2011-07-15 12:09 ` Dong Aisheng
2011-07-15 12:09 ` [PATCH v3 01/10] ASoc: mxs: add mxs-pcm driver Dong Aisheng
2011-07-15 12:09 ` Dong Aisheng
2011-07-15 12:09 ` [PATCH v3 02/10] ASoc: mxs: add mxs-saif driver Dong Aisheng
2011-07-15 12:09 ` Dong Aisheng
2011-07-15 12:09 ` [PATCH v3 03/10] ASoc: mxs: add mxs-sgtl5000 machine driver Dong Aisheng
2011-07-15 12:09 ` Dong Aisheng
2011-07-15 12:09 ` [PATCH v3 04/10] ASoc: mxs: add asoc configuration files Dong Aisheng
2011-07-15 12:09 ` Dong Aisheng
2011-07-15 12:09 ` [PATCH v3 05/10] ARM: mxs: add saif clock Dong Aisheng
2011-07-15 12:09 ` Dong Aisheng
2011-07-15 12:09 ` [PATCH v3 06/10] ARM: mxs: add saif device Dong Aisheng
2011-07-15 12:09 ` Dong Aisheng
2011-07-19 4:34 ` [PATCH v4 " Dong Aisheng
2011-07-19 4:34 ` Dong Aisheng
2011-07-19 14:57 ` Mark Brown
2011-07-19 14:57 ` Mark Brown
2011-07-20 2:43 ` Dong Aisheng
2011-07-20 2:43 ` [alsa-devel] " Dong Aisheng
2011-07-15 12:09 ` [PATCH v3 07/10] ARM: mxs: add sgtl5000 i2c device Dong Aisheng
2011-07-15 12:09 ` Dong Aisheng
2011-07-19 4:35 ` [PATCH v4 " Dong Aisheng
2011-07-19 4:35 ` Dong Aisheng
2011-07-15 12:09 ` [PATCH v3 08/10] ARM: mxs: add mxs-sgtl5000 device Dong Aisheng
2011-07-15 12:09 ` Dong Aisheng
2011-07-19 4:36 ` [PATCH v4 " Dong Aisheng
2011-07-19 4:36 ` Dong Aisheng
2011-07-15 12:09 ` [PATCH v3 09/10] ARM: mxs: correct the using of frac div for saif Dong Aisheng
2011-07-15 12:09 ` Dong Aisheng
2011-07-15 12:09 ` Dong Aisheng [this message]
2011-07-15 12:09 ` [PATCH v3 10/10] ARM: mxs-dma: include <linux/dmaengine.h> Dong Aisheng
2011-07-15 20:39 ` [PATCH v3 00/10] ARM: mxs: add audio support Wolfram Sang
2011-07-15 20:39 ` Wolfram Sang
2011-07-17 3:44 ` Dong Aisheng
2011-07-17 3:44 ` [alsa-devel] " Dong Aisheng
2011-07-18 16:04 ` [PATCH 11/10] arm: mxs: mx28evk: add fixed regulators for audio Wolfram Sang
2011-07-18 16:04 ` Wolfram Sang
2011-07-18 20:38 ` [PATCH v3 00/10] ARM: mxs: add audio support Wolfram Sang
2011-07-18 20:38 ` Wolfram Sang
2011-07-19 1:49 ` Shawn Guo
2011-07-19 1:49 ` [alsa-devel] " Shawn Guo
2011-07-19 2:58 ` Dong Aisheng
2011-07-19 2:58 ` [alsa-devel] " Dong Aisheng
2011-07-19 12:48 ` Dong Aisheng
2011-07-19 12:48 ` [alsa-devel] " Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1310731780-1645-11-git-send-email-b29396@freescale.com \
--to=b29396@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lrg@ti.com \
--cc=s.hauer@pengutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.