From: "Koul, Vinod" <vinod.koul@intel.com>
To: viresh kumar <viresh.kumar@st.com>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
Pratyush ANAND <pratyush.anand@st.com>,
Rajeev KUMAR <rajeev-dlh.kumar@st.com>,
Armando VISCONTI <armando.visconti@st.com>,
Bhupesh SHARMA <bhupesh.sharma@st.com>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Vipin KUMAR <vipin.kumar@st.com>,
Shiraz HASHIM <shiraz.hashim@st.com>,
Amit VIRDI <Amit.VIRDI@st.com>,
Vipul Kumar SAMAR <vipulkumar.samar@st.com>,
"viresh.linux@gmail.com" <viresh.linux@gmail.com>,
Deepak SIKRI <deepak.sikri@st.com>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 08/20] dmaengine/amba-pl08x: support runtime PM
Date: Thu, 04 Aug 2011 12:58:46 +0530 [thread overview]
Message-ID: <1312442926.1539.0.camel@vkoul-udesk3> (raw)
In-Reply-To: <4E3A3CB7.8040505@st.com>
On Thu, 2011-08-04 at 12:01 +0530, viresh kumar wrote:
> On 08/04/2011 11:06 AM, Koul, Vinod wrote:
> > On Thu, 2011-08-04 at 10:49 +0530, viresh kumar wrote:
> >> On 08/03/2011 06:09 PM, Russell King - ARM Linux wrote:
> >>> On Mon, Aug 01, 2011 at 03:07:18PM +0530, Viresh Kumar wrote:
> >> @@ -405,6 +406,7 @@ pl08x_get_phy_channel(struct pl08x_driver_data *pl08x,
> >> return NULL;
> >> }
> >>
> >> + pm_runtime_get_sync(&pl08x->adev->dev);
> > this should be ideally one of the first things you would do not last.
> > get_sync will ensure your .runtime_resume callback is called before it
> > returns (if its suspended)
> >> return ch;
> >> }
>
> Until this point we are not touching the registers at all. And they will
> accessed after this point only.
But from maintainability POV it should be at the start.
>
> >> + pm_runtime_put(&adev->dev);
> > _put is probe looks suspect, why do you need this here
>
> To save power.
>
> > as you are already setting the status as active, this _put will decrement your
> > usage count and possibly call your runtime_suspend
>
> We set status as active, as amba/bus layer has enabled it before calling
> probe and it doesn't put it.
>
> As DMA will not be used until get_phy_channel() is called, so we can save
> some energy here too. So i put it here.
>
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Koul, Vinod)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 08/20] dmaengine/amba-pl08x: support runtime PM
Date: Thu, 04 Aug 2011 12:58:46 +0530 [thread overview]
Message-ID: <1312442926.1539.0.camel@vkoul-udesk3> (raw)
In-Reply-To: <4E3A3CB7.8040505@st.com>
On Thu, 2011-08-04 at 12:01 +0530, viresh kumar wrote:
> On 08/04/2011 11:06 AM, Koul, Vinod wrote:
> > On Thu, 2011-08-04 at 10:49 +0530, viresh kumar wrote:
> >> On 08/03/2011 06:09 PM, Russell King - ARM Linux wrote:
> >>> On Mon, Aug 01, 2011 at 03:07:18PM +0530, Viresh Kumar wrote:
> >> @@ -405,6 +406,7 @@ pl08x_get_phy_channel(struct pl08x_driver_data *pl08x,
> >> return NULL;
> >> }
> >>
> >> + pm_runtime_get_sync(&pl08x->adev->dev);
> > this should be ideally one of the first things you would do not last.
> > get_sync will ensure your .runtime_resume callback is called before it
> > returns (if its suspended)
> >> return ch;
> >> }
>
> Until this point we are not touching the registers at all. And they will
> accessed after this point only.
But from maintainability POV it should be at the start.
>
> >> + pm_runtime_put(&adev->dev);
> > _put is probe looks suspect, why do you need this here
>
> To save power.
>
> > as you are already setting the status as active, this _put will decrement your
> > usage count and possibly call your runtime_suspend
>
> We set status as active, as amba/bus layer has enabled it before calling
> probe and it doesn't put it.
>
> As DMA will not be used until get_phy_channel() is called, so we can save
> some energy here too. So i put it here.
>
--
~Vinod
next prev parent reply other threads:[~2011-08-04 8:12 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 9:37 [PATCH V2 00/20] dmaengine/amba-pl08x updates Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 01/20] ARM: asm/pl080.h: Protect against multiple inclusion of header file Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 02/20] dmaengine/amba-pl08x: Resolve formatting issues Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 03/20] dmaengine/amba-pl08x: Rearrange inclusion of header files in ascending order Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:52 ` Sergei Shtylyov
2011-08-01 9:52 ` Sergei Shtylyov
2011-08-01 10:34 ` viresh kumar
2011-08-01 10:34 ` viresh kumar
2011-08-01 9:37 ` [PATCH V2 04/20] dmaengine/amba-pl08x: pass (*ptr) to sizeof() instead of (struct xyz) Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 05/20] dmaengine/amba-pl08x: Complete doc comment for struct pl08x_txd Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 06/20] dmaengine/amba-pl08x: Remove redundant comment and rewrite original Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 07/20] dmaengine/amba-pl08x: Changing few prints to dev_dbg from dev_info Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-04 8:28 ` Koul, Vinod
2011-08-04 8:28 ` Koul, Vinod
2011-08-04 9:25 ` viresh kumar
2011-08-04 9:25 ` viresh kumar
2011-08-04 8:53 ` Koul, Vinod
2011-08-04 8:53 ` Koul, Vinod
2011-08-01 9:37 ` [PATCH V2 08/20] dmaengine/amba-pl08x: support runtime PM Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 10:26 ` Russell King - ARM Linux
2011-08-01 10:26 ` Russell King - ARM Linux
2011-08-01 11:55 ` viresh kumar
2011-08-01 11:55 ` viresh kumar
2011-08-03 12:39 ` Russell King - ARM Linux
2011-08-03 12:39 ` Russell King - ARM Linux
2011-08-04 5:19 ` viresh kumar
2011-08-04 5:19 ` viresh kumar
2011-08-04 5:36 ` Koul, Vinod
2011-08-04 5:36 ` Koul, Vinod
2011-08-04 6:31 ` viresh kumar
2011-08-04 6:31 ` viresh kumar
2011-08-04 7:28 ` Koul, Vinod [this message]
2011-08-04 7:28 ` Koul, Vinod
2011-08-04 8:42 ` viresh kumar
2011-08-04 8:42 ` viresh kumar
2011-08-01 9:37 ` [PATCH V2 09/20] dmaengine/amba-pl08x: Simplify pl08x_ensure_on() Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 10/20] dmaengine/amba-pl08x: No need to check "ch->signal < 0" Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 11/20] dmaengine/amba-pl08x: Schedule tasklet in case of error interrupt Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 12/20] dmaengine/amba-pl08x: Get rid of pl08x_pre_boundary() Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 13/20] dmaengine/amba-pl08x: max_bytes_per_lli is TRANSFER_SIZE * src_width (not MIN(width)) Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 14/20] dmaengine/amba-pl08x: Add prep_single_byte_llis() routine Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 15/20] dmaengine/amba-pl08x: Align lli_len to max(src.width, dst.width) Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 16/20] dmaengine/amba-pl08x: Choose peripheral bus as master bus Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 17/20] dmaengine/amba-pl08x: Pass flow controller information with slave channel data Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 18/20] dmaengine/amba-pl08x: Add support for sg len greater than one for slave transfers Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-04 10:27 ` viresh kumar
2011-08-04 10:27 ` viresh kumar
2011-08-01 9:37 ` [PATCH V2 19/20] dmaengine/amba-pl08x: Check txd->llis_va before freeing dma_pool Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 9:37 ` [PATCH V2 20/20] dmaengine/amba-pl08x: Call pl08x_free_txd() instead of calling kfree() directly Viresh Kumar
2011-08-01 9:37 ` Viresh Kumar
2011-08-01 11:56 ` [PATCH V3 08/20] dmaengine/amba-pl08x: support runtime PM Viresh Kumar
2011-08-01 11:56 ` Viresh Kumar
2011-08-04 8:52 ` Koul, Vinod
2011-08-04 8:52 ` Koul, Vinod
2011-08-04 9:41 ` viresh kumar
2011-08-04 9:41 ` viresh kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312442926.1539.0.camel@vkoul-udesk3 \
--to=vinod.koul@intel.com \
--cc=Amit.VIRDI@st.com \
--cc=armando.visconti@st.com \
--cc=bhupesh.sharma@st.com \
--cc=dan.j.williams@intel.com \
--cc=deepak.sikri@st.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pratyush.anand@st.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=shiraz.hashim@st.com \
--cc=vipin.kumar@st.com \
--cc=vipulkumar.samar@st.com \
--cc=viresh.kumar@st.com \
--cc=viresh.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.