From: Joe Perches <joe@perches.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Andy Green <andy.green@linaro.org>,
s-jan@ti.com, patches@linaro.org, tony@atomide.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2 2/4] net ethernet introduce mac_la_ap helper
Date: Tue, 03 Jul 2012 13:02:11 -0700 [thread overview]
Message-ID: <1341345731.2012.19.camel@joe2Laptop> (raw)
In-Reply-To: <1341246931.6578.10.camel@gandalf.stny.rr.com>
On Mon, 2012-07-02 at 12:35 -0400, Steven Rostedt wrote:
> On Mon, 2012-07-02 at 16:12 +0000, Arnd Bergmann wrote:
>
> > > include/net/mac-la-ap.h | 28 ++++++++
> > > net/Kconfig | 14 ++++
> > > net/ethernet/Makefile | 2 +
> > > net/ethernet/mac-la-ap.c | 165 ++++++++++++++++++++++++++++++++++++++++++++++
> > > 4 files changed, 209 insertions(+)
> > > create mode 100644 include/net/mac-la-ap.h
> > > create mode 100644 net/ethernet/mac-la-ap.c
> > > diff --git a/include/net/mac-la-ap.h b/include/net/mac-la-ap.h
> > > new file mode 100644
> > > index 0000000..d5189b5
> > > --- /dev/null
> > > +++ b/include/net/mac-la-ap.h
> > > @@ -0,0 +1,28 @@
> > > +/*
> > > + * mac-la-ap.h: Locally Administered MAC address for Async probed devices
> > > + */
> >
> > I find the name a bit non-obvious, not sure if we can come up with the
> > perfect one.
> >
> > How about mac-platform?
>
> I really find it unfortunate that 'mac' for ethernet has the same name
> as the Apple box as well. 'mac' in other contexts can usually
> differentiate these two, but saying 'mac-platform' just screams of
> forbidden fruit.
>
> mac-probe.h ?
Maybe eth_mac_addr.h?
underscore filenames outnumber dash filenames ~2:1
$ git ls-files "*_*" | while read file ; do basename $file; done | grep "_" | wc -l
11185
$ git ls-files "*-*" | while read file ; do basename $file; done | grep "-" | wc -l
6624
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2 2/4] net ethernet introduce mac_la_ap helper
Date: Tue, 03 Jul 2012 13:02:11 -0700 [thread overview]
Message-ID: <1341345731.2012.19.camel@joe2Laptop> (raw)
In-Reply-To: <1341246931.6578.10.camel@gandalf.stny.rr.com>
On Mon, 2012-07-02 at 12:35 -0400, Steven Rostedt wrote:
> On Mon, 2012-07-02 at 16:12 +0000, Arnd Bergmann wrote:
>
> > > include/net/mac-la-ap.h | 28 ++++++++
> > > net/Kconfig | 14 ++++
> > > net/ethernet/Makefile | 2 +
> > > net/ethernet/mac-la-ap.c | 165 ++++++++++++++++++++++++++++++++++++++++++++++
> > > 4 files changed, 209 insertions(+)
> > > create mode 100644 include/net/mac-la-ap.h
> > > create mode 100644 net/ethernet/mac-la-ap.c
> > > diff --git a/include/net/mac-la-ap.h b/include/net/mac-la-ap.h
> > > new file mode 100644
> > > index 0000000..d5189b5
> > > --- /dev/null
> > > +++ b/include/net/mac-la-ap.h
> > > @@ -0,0 +1,28 @@
> > > +/*
> > > + * mac-la-ap.h: Locally Administered MAC address for Async probed devices
> > > + */
> >
> > I find the name a bit non-obvious, not sure if we can come up with the
> > perfect one.
> >
> > How about mac-platform?
>
> I really find it unfortunate that 'mac' for ethernet has the same name
> as the Apple box as well. 'mac' in other contexts can usually
> differentiate these two, but saying 'mac-platform' just screams of
> forbidden fruit.
>
> mac-probe.h ?
Maybe eth_mac_addr.h?
underscore filenames outnumber dash filenames ~2:1
$ git ls-files "*_*" | while read file ; do basename $file; done | grep "_" | wc -l
11185
$ git ls-files "*-*" | while read file ; do basename $file; done | grep "-" | wc -l
6624
next prev parent reply other threads:[~2012-07-03 20:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-02 6:40 [PATCH 2 0/4] Add ability to set defaultless network device MAC addresses to deterministic computed locally administered values Andy Green
2012-07-02 6:40 ` Andy Green
2012-07-02 6:40 ` [PATCH 2 1/4] OMAP2+: add cpu id register to MAC address helper Andy Green
2012-07-02 6:40 ` Andy Green
2012-07-02 6:40 ` [PATCH 2 2/4] net ethernet introduce mac_la_ap helper Andy Green
2012-07-02 6:40 ` Andy Green
2012-07-02 16:12 ` Arnd Bergmann
2012-07-02 16:12 ` Arnd Bergmann
2012-07-02 16:35 ` Steven Rostedt
2012-07-02 16:35 ` Steven Rostedt
2012-07-03 20:02 ` Joe Perches [this message]
2012-07-03 20:02 ` Joe Perches
2012-07-03 4:38 ` Andy Green
2012-07-03 4:38 ` Andy Green
2012-07-03 8:05 ` Arnd Bergmann
2012-07-03 8:05 ` Arnd Bergmann
2012-07-02 6:41 ` [PATCH 2 3/4] OMAP4 PANDA register ethernet and wlan for automatic mac allocation Andy Green
2012-07-02 6:41 ` Andy Green
2012-07-02 6:41 ` [PATCH 2 4/4] config test config extending omap2plus with wl12xx etc Andy Green
2012-07-02 6:41 ` Andy Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341345731.2012.19.camel@joe2Laptop \
--to=joe@perches.com \
--cc=andy.green@linaro.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rostedt@goodmis.org \
--cc=s-jan@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.