From: Lee Jones <lee.jones@linaro.org>
To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: STEricsson_nomadik_linux@list.st.com,
linus.walleij@stericsson.com, arnd@arndb.de,
broonie@opensource.wolfsonmicro.com, sameo@linux.intel.com,
olalilja@yahoo.se, ola.o.lilja@stericsson.com,
alsa-devel@alsa-project.org, lrg@ti.com,
Lee Jones <lee.jones@linaro.org>
Subject: [PATCH 06/21] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too
Date: Thu, 26 Jul 2012 11:28:39 +0100 [thread overview]
Message-ID: <1343298534-13611-7-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1343298534-13611-1-git-send-email-lee.jones@linaro.org>
If a list of widgets is provided and one of them fails to be added as
a control, the present semantics fail all subsequent widgets. A better
solution would be to only fail that widget, but pursue in attempting
to add the rest of the list.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
sound/soc/soc-dapm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index eded657..7d9c154 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3095,8 +3095,6 @@ int snd_soc_dapm_new_controls(struct snd_soc_dapm_context *dapm,
dev_err(dapm->dev,
"ASoC: Failed to create DAPM control %s\n",
widget->name);
- ret = -ENOMEM;
- break;
}
widget++;
}
--
1.7.9.5
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/21] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too
Date: Thu, 26 Jul 2012 11:28:39 +0100 [thread overview]
Message-ID: <1343298534-13611-7-git-send-email-lee.jones@linaro.org> (raw)
In-Reply-To: <1343298534-13611-1-git-send-email-lee.jones@linaro.org>
If a list of widgets is provided and one of them fails to be added as
a control, the present semantics fail all subsequent widgets. A better
solution would be to only fail that widget, but pursue in attempting
to add the rest of the list.
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
sound/soc/soc-dapm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index eded657..7d9c154 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -3095,8 +3095,6 @@ int snd_soc_dapm_new_controls(struct snd_soc_dapm_context *dapm,
dev_err(dapm->dev,
"ASoC: Failed to create DAPM control %s\n",
widget->name);
- ret = -ENOMEM;
- break;
}
widget++;
}
--
1.7.9.5
next prev parent reply other threads:[~2012-07-26 10:29 UTC|newest]
Thread overview: 130+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-26 10:28 [PATCH 00/21] Some fixes and DT enablement for ux500 audio Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 01/21] ARM: ux500: Remove unused snowball_of_platform_devs struct Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 02/21] MFD: db8500-prcmu: Ensure AB8500 platform data is passed through MFD Core Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 03/21] ARM: ux500: Clean-up MSP platform code Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 04/21] ASoC: ux500: Strengthen error checking after memory allocation Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 11:57 ` Mark Brown
2012-07-26 11:57 ` Mark Brown
2012-07-26 11:57 ` Mark Brown
2012-07-26 10:28 ` [PATCH 05/21] ASoC: ux500: Include the correct header files Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 11:58 ` Mark Brown
2012-07-26 11:58 ` Mark Brown
2012-07-26 11:58 ` Mark Brown
2012-07-26 10:28 ` Lee Jones [this message]
2012-07-26 10:28 ` [PATCH 06/21] ASoC: dapm: If one widget fails, do not force all subsequent widgets to fail too Lee Jones
2012-07-26 11:54 ` Mark Brown
2012-07-26 11:54 ` Mark Brown
2012-07-26 11:54 ` Mark Brown
2012-07-26 10:28 ` [PATCH 07/21] ASoC: io: Prevent use of regmap if request fails Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 11:32 ` Mark Brown
2012-07-26 11:32 ` Mark Brown
2012-07-26 11:32 ` Mark Brown
2012-07-26 11:38 ` Lee Jones
2012-07-26 11:38 ` Lee Jones
2012-07-26 11:42 ` Mark Brown
2012-07-26 11:42 ` Mark Brown
2012-07-26 11:42 ` Mark Brown
2012-07-26 14:51 ` Lee Jones
2012-07-26 14:51 ` Lee Jones
2012-07-26 15:12 ` Mark Brown
2012-07-26 15:12 ` Mark Brown
2012-07-26 15:12 ` Mark Brown
2012-07-26 15:23 ` Lee Jones
2012-07-26 15:23 ` Lee Jones
2012-07-26 15:25 ` Mark Brown
2012-07-26 15:25 ` Mark Brown
2012-07-26 15:25 ` Mark Brown
2012-07-26 16:05 ` Lee Jones
2012-07-26 16:05 ` Lee Jones
2012-07-26 20:23 ` Mark Brown
2012-07-26 20:23 ` Mark Brown
2012-07-26 20:23 ` Mark Brown
2012-07-26 10:28 ` [PATCH 08/21] ARM: ux500: Add AB8500 CODEC node to DB8500 Device Tree Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 09/21] ARM: ux500: Add MSP devices " Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 10/21] ARM: ux500: Add ux500 PCM " Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 11/21] ARM: ux500: Add all encompassing Sound node " Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 12/21] ARM: ux500: Fork MSP platform registration for step-by-step DT enablement Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 13/21] ARM: ux500: Ensure probing of Audio devices when Device Tree is enabled Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 14/21] ARM: ux500: Enable HIGHMEM on all mop500 platforms Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 15/21] ARM: ux500: Pass MSP DMA platform data though AUXDATA Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 16/21] ASoC: Ux500: Enable MOP500 driver for Device Tree Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 11:37 ` Mark Brown
2012-07-26 11:37 ` Mark Brown
2012-07-26 11:37 ` Mark Brown
2012-07-26 13:51 ` Lee Jones
2012-07-26 13:51 ` Lee Jones
2012-07-26 13:53 ` Mark Brown
2012-07-26 13:53 ` Mark Brown
2012-07-26 13:53 ` Mark Brown
2012-07-26 14:51 ` Lee Jones
2012-07-26 14:51 ` Lee Jones
2012-07-26 10:28 ` [PATCH 17/21] ASoC: Ux500: Enable ux500 PCM " Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 11:38 ` Mark Brown
2012-07-26 11:38 ` Mark Brown
2012-07-26 11:38 ` Mark Brown
2012-07-26 13:52 ` Lee Jones
2012-07-26 13:52 ` Lee Jones
2012-07-26 14:22 ` Mark Brown
2012-07-26 14:22 ` Mark Brown
2012-07-26 14:22 ` Mark Brown
2012-07-26 14:55 ` Lee Jones
2012-07-26 14:55 ` Lee Jones
2012-07-26 10:28 ` [PATCH 18/21] ASoC: Ux500: Move MSP pinctrl setup into the MSP driver Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 10:28 ` [PATCH 19/21] ASoC: Ux500: Enable ux500 MSP driver for Device Tree Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 11:45 ` Mark Brown
2012-07-26 11:45 ` Mark Brown
2012-07-26 11:45 ` Mark Brown
2012-07-26 10:28 ` [PATCH 20/21] ASoC: codecs: Enable AB8500 CODEC " Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 11:50 ` Mark Brown
2012-07-26 11:50 ` Mark Brown
2012-07-26 11:50 ` Mark Brown
2012-07-26 14:00 ` Lee Jones
2012-07-26 14:00 ` Lee Jones
2012-07-26 14:28 ` Mark Brown
2012-07-26 14:28 ` Mark Brown
2012-07-26 14:28 ` Mark Brown
2012-07-26 15:01 ` Lee Jones
2012-07-26 15:01 ` Lee Jones
2012-07-26 15:14 ` Mark Brown
2012-07-26 15:14 ` Mark Brown
2012-07-26 15:14 ` Mark Brown
2012-07-26 15:17 ` Lee Jones
2012-07-26 15:17 ` Lee Jones
2012-07-26 14:15 ` Lee Jones
2012-07-26 14:15 ` Lee Jones
2012-07-26 14:43 ` Mark Brown
2012-07-26 14:43 ` Mark Brown
2012-07-26 14:43 ` Mark Brown
2012-07-26 15:19 ` Lee Jones
2012-07-26 15:19 ` Lee Jones
2012-07-26 15:24 ` Mark Brown
2012-07-26 15:24 ` Mark Brown
2012-07-26 15:24 ` Mark Brown
2012-07-26 10:28 ` [PATCH 21/21] ARM: ux500: Rename MSP board file to something more meaningful Lee Jones
2012-07-26 10:28 ` Lee Jones
2012-07-26 11:28 ` [PATCH 00/21] Some fixes and DT enablement for ux500 audio Mark Brown
2012-07-26 11:28 ` Mark Brown
2012-07-26 11:28 ` Mark Brown
2012-07-26 11:36 ` Lee Jones
2012-07-26 11:36 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343298534-13611-7-git-send-email-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=ola.o.lilja@stericsson.com \
--cc=olalilja@yahoo.se \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.