From: Andre Przywara <andre.przywara@amd.com> To: <cpufreq@vger.kernel.org>, "Rafael J. Wysocki" <rjw@sisk.pl> Cc: Matthew Garrett <mjg@redhat.com>, Andreas Herrmann <andreas.herrmann3@amd.com>, Thomas Renninger <trenn@suse.de>, <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Andre Przywara <andre.przywara@amd.com> Subject: [PATCH 3/8] cpufreq: Add compatibility hack to powernow-k8 Date: Thu, 26 Jul 2012 14:28:39 +0200 [thread overview] Message-ID: <1343305724-2809-4-git-send-email-andre.przywara@amd.com> (raw) In-Reply-To: <1343305724-2809-1-git-send-email-andre.przywara@amd.com> From: Matthew Garrett <mjg@redhat.com> cpufreq modules are often loaded from init scripts that assume that all recent AMD systems will use powernow-k8, so we should ensure that loading it triggers a load of acpi-cpufreq if the latter is built as a module. This avoids the problem of users ending up without any cpufreq support after the transition. Signed-off-by: Matthew Garrett <mjg@redhat.com> Signed-off-by: Andre Przywara <andre.przywara@amd.com> --- drivers/cpufreq/powernow-k8.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index c0e8164..6e35ed2 100644 --- a/drivers/cpufreq/powernow-k8.c +++ b/drivers/cpufreq/powernow-k8.c @@ -1567,8 +1567,12 @@ static int __cpuinit powernowk8_init(void) supported_cpus++; } - if (supported_cpus != num_online_cpus()) + if (supported_cpus != num_online_cpus()) { + if (static_cpu_has(X86_FEATURE_HW_PSTATE)) + request_module("acpi_cpufreq"); + return -ENODEV; + } printk(KERN_INFO PFX "Found %d %s (%d cpu cores) (" VERSION ")\n", num_online_nodes(), boot_cpu_data.x86_model_id, supported_cpus); -- 1.7.4.4
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@amd.com> To: cpufreq@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl> Cc: Matthew Garrett <mjg@redhat.com>, Andreas Herrmann <andreas.herrmann3@amd.com>, Thomas Renninger <trenn@suse.de>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Andre Przywara <andre.przywara@amd.com> Subject: [PATCH 3/8] cpufreq: Add compatibility hack to powernow-k8 Date: Thu, 26 Jul 2012 14:28:39 +0200 [thread overview] Message-ID: <1343305724-2809-4-git-send-email-andre.przywara@amd.com> (raw) In-Reply-To: <1343305724-2809-1-git-send-email-andre.przywara@amd.com> From: Matthew Garrett <mjg@redhat.com> cpufreq modules are often loaded from init scripts that assume that all recent AMD systems will use powernow-k8, so we should ensure that loading it triggers a load of acpi-cpufreq if the latter is built as a module. This avoids the problem of users ending up without any cpufreq support after the transition. Signed-off-by: Matthew Garrett <mjg@redhat.com> Signed-off-by: Andre Przywara <andre.przywara@amd.com> --- drivers/cpufreq/powernow-k8.c | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c index c0e8164..6e35ed2 100644 --- a/drivers/cpufreq/powernow-k8.c +++ b/drivers/cpufreq/powernow-k8.c @@ -1567,8 +1567,12 @@ static int __cpuinit powernowk8_init(void) supported_cpus++; } - if (supported_cpus != num_online_cpus()) + if (supported_cpus != num_online_cpus()) { + if (static_cpu_has(X86_FEATURE_HW_PSTATE)) + request_module("acpi_cpufreq"); + return -ENODEV; + } printk(KERN_INFO PFX "Found %d %s (%d cpu cores) (" VERSION ")\n", num_online_nodes(), boot_cpu_data.x86_model_id, supported_cpus); -- 1.7.4.4
next prev parent reply other threads:[~2012-07-26 12:29 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-26 12:28 [PATCH 0/8] acpi-cpufreq: Move modern AMD cpufreq support to acpi-cpufreq Andre Przywara 2012-07-26 12:28 ` Andre Przywara 2012-07-26 12:28 ` [PATCH 1/8] acpi-cpufreq: Add support for modern AMD CPUs Andre Przywara 2012-07-26 12:28 ` Andre Przywara 2012-07-26 12:28 ` [PATCH 2/8] acpi-cpufreq: Add quirk to disable _PSD usage on all " Andre Przywara 2012-07-26 12:28 ` Andre Przywara 2012-07-26 12:28 ` Andre Przywara [this message] 2012-07-26 12:28 ` [PATCH 3/8] cpufreq: Add compatibility hack to powernow-k8 Andre Przywara 2012-08-22 0:48 ` Thomas Renninger 2012-07-26 12:28 ` [PATCH 4/8] ACPI: Add fixups for AMD P-state figures Andre Przywara 2012-07-26 12:28 ` Andre Przywara 2012-07-26 12:28 ` [PATCH 5/8] acpi-cpufreq: Add support for disabling dynamic overclocking Andre Przywara 2012-07-26 12:28 ` Andre Przywara 2012-08-05 21:26 ` Rafael J. Wysocki 2012-07-26 12:28 ` [PATCH 6/8] acpi-cpufreq: Add compatibility for legacy AMD cpb sysfs knob Andre Przywara 2012-07-26 12:28 ` Andre Przywara 2012-08-05 21:29 ` Rafael J. Wysocki 2012-07-26 12:28 ` [PATCH 7/8] cpufreq: Remove support for hardware P-state chips from powernow-k8 Andre Przywara 2012-07-26 12:28 ` Andre Przywara 2012-08-05 21:33 ` Rafael J. Wysocki 2012-08-20 13:00 ` Andre Przywara 2012-08-20 13:00 ` Andre Przywara 2012-08-20 20:49 ` Rafael J. Wysocki 2012-08-22 1:00 ` Thomas Renninger 2012-08-22 13:39 ` Andre Przywara 2012-08-22 13:39 ` Andre Przywara 2012-08-22 14:34 ` Thomas Renninger 2012-07-26 12:28 ` [PATCH 8/8] Documentation: Add documentation for boost control switch Andre Przywara 2012-07-26 12:28 ` Andre Przywara 2012-08-05 21:34 ` Rafael J. Wysocki 2012-07-26 14:01 ` [PATCH 0/8] acpi-cpufreq: Move modern AMD cpufreq support to acpi-cpufreq Thomas Renninger 2012-07-26 19:58 ` Rafael J. Wysocki 2012-08-05 21:20 ` Rafael J. Wysocki 2012-08-05 23:39 ` H. Peter Anvin 2012-08-06 8:20 ` Borislav Petkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1343305724-2809-4-git-send-email-andre.przywara@amd.com \ --to=andre.przywara@amd.com \ --cc=andreas.herrmann3@amd.com \ --cc=cpufreq@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=mjg@redhat.com \ --cc=rjw@sisk.pl \ --cc=trenn@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.