From: Tero Kristo <t-kristo@ti.com>
To: Kevin Hilman <khilman@ti.com>
Cc: linux-omap@vger.kernel.org, paul@pwsan.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv4 6/8] ARM: OMAP: pm-debug: enhanced usecount debug support
Date: Mon, 30 Jul 2012 11:36:11 +0300 [thread overview]
Message-ID: <1343637371.9847.11.camel@sokoban> (raw)
In-Reply-To: <87y5m5htcu.fsf@ti.com>
On Fri, 2012-07-27 at 12:55 -0700, Kevin Hilman wrote:
> Tero Kristo <t-kristo@ti.com> writes:
>
> > Voltdm, pwrdm, clkdm, hwmod and clk usecounts are now separeted to
> > their own file, 'usecount'. This file shows the usecounts for every
> > active domain and their children recursively. 'count' file now only
> > shows power state counts for powerdomains.
> >
> > This patch also provices a way to do printk dumps from kernel code,
> > by calling the pm_dbg_dump_X functions. The plan is to call these
> > functions once an error condition is detected, e.g. failed suspend.
> >
> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > Cc: Kevin Hilman <khilman@ti.com>
>
> I think we should separate out the debug stuff as a separate patch set.
>
> Where I want to go with PM debug is away from in-kernel debug prints and
> towards using tracepoints. We have tracepoints in the clock code that
> correspond to usecounts, but we need them in the clkdm, pwrdm and voltdm
> code as well. With that, you can use userspace tools (perf, ftrace) to
> trace a problem (e.g. failed suspend) and see voltdm/pwrdm/clkdm/clks
> are on when they shouldn't be.
Yes, I can split out the debug stuff from this set for next rev. I'll
also take a look at the tracepoints if they can be used reasonably for
this purpose. We can add tracepoints for failed suspend for each
powerdomain, but are tracepoints a good way to do this kind of recursive
dumps (well, we could maybe register a trace event recursively from
clkdm + clk code if a powerdomain fails to transition.)
-Tero
WARNING: multiple messages have this Message-ID (diff)
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 6/8] ARM: OMAP: pm-debug: enhanced usecount debug support
Date: Mon, 30 Jul 2012 11:36:11 +0300 [thread overview]
Message-ID: <1343637371.9847.11.camel@sokoban> (raw)
In-Reply-To: <87y5m5htcu.fsf@ti.com>
On Fri, 2012-07-27 at 12:55 -0700, Kevin Hilman wrote:
> Tero Kristo <t-kristo@ti.com> writes:
>
> > Voltdm, pwrdm, clkdm, hwmod and clk usecounts are now separeted to
> > their own file, 'usecount'. This file shows the usecounts for every
> > active domain and their children recursively. 'count' file now only
> > shows power state counts for powerdomains.
> >
> > This patch also provices a way to do printk dumps from kernel code,
> > by calling the pm_dbg_dump_X functions. The plan is to call these
> > functions once an error condition is detected, e.g. failed suspend.
> >
> > Signed-off-by: Tero Kristo <t-kristo@ti.com>
> > Cc: Paul Walmsley <paul@pwsan.com>
> > Cc: Kevin Hilman <khilman@ti.com>
>
> I think we should separate out the debug stuff as a separate patch set.
>
> Where I want to go with PM debug is away from in-kernel debug prints and
> towards using tracepoints. We have tracepoints in the clock code that
> correspond to usecounts, but we need them in the clkdm, pwrdm and voltdm
> code as well. With that, you can use userspace tools (perf, ftrace) to
> trace a problem (e.g. failed suspend) and see voltdm/pwrdm/clkdm/clks
> are on when they shouldn't be.
Yes, I can split out the debug stuff from this set for next rev. I'll
also take a look at the tracepoints if they can be used reasonably for
this purpose. We can add tracepoints for failed suspend for each
powerdomain, but are tracepoints a good way to do this kind of recursive
dumps (well, we could maybe register a trace event recursively from
clkdm + clk code if a powerdomain fails to transition.)
-Tero
next prev parent reply other threads:[~2012-07-30 8:36 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-13 14:19 [PATCHv4 0/8] ARM: OMAP: pm: usecounting changes Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 1/8] ARM: OMAP: clk: add support for omap_clk_for_each Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 10:04 ` Rajendra Nayak
2012-07-16 10:04 ` Rajendra Nayak
2012-07-16 11:42 ` Tero Kristo
2012-07-16 11:42 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 2/8] ARM: OMAP3+: voltage/pwrdm/clkdm/clock add recursive usecount tracking Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 10:15 ` Rajendra Nayak
2012-07-16 10:15 ` Rajendra Nayak
2012-07-27 19:14 ` Kevin Hilman
2012-07-27 19:14 ` Kevin Hilman
2012-08-06 23:31 ` Kevin Hilman
2012-08-06 23:31 ` Kevin Hilman
2012-09-07 9:23 ` Tero Kristo
2012-09-07 9:23 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 3/8] ARM: OMAP3+: voltage: add support for voltagedomain usecounts Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 10:23 ` Rajendra Nayak
2012-07-16 10:23 ` Rajendra Nayak
2012-07-24 20:58 ` Vishwanath Sripathy
2012-07-24 20:58 ` Vishwanath Sripathy
2012-07-25 8:07 ` Tero Kristo
2012-07-25 8:07 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 4/8] ARM: OMAP3: add manual control for mpu / core pwrdm usecounting Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 10:30 ` Rajendra Nayak
2012-07-16 10:30 ` Rajendra Nayak
2012-07-27 19:36 ` Kevin Hilman
2012-07-27 19:36 ` Kevin Hilman
2012-07-30 8:40 ` Tero Kristo
2012-07-30 8:40 ` Tero Kristo
2012-08-06 10:14 ` Jean Pihet
2012-08-06 10:14 ` Jean Pihet
2012-09-07 9:30 ` Tero Kristo
2012-09-07 9:30 ` Tero Kristo
2012-09-07 21:48 ` Kevin Hilman
2012-09-07 21:48 ` Kevin Hilman
2012-08-06 23:32 ` Kevin Hilman
2012-08-06 23:32 ` Kevin Hilman
2012-07-13 14:19 ` [PATCHv4 5/8] ARM: OMAP3: set autoidle flag for sdrc_ick Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 10:39 ` Rajendra Nayak
2012-07-16 10:39 ` Rajendra Nayak
2012-07-13 14:19 ` [PATCHv4 6/8] ARM: OMAP: pm-debug: enhanced usecount debug support Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 10:50 ` Rajendra Nayak
2012-07-16 10:50 ` Rajendra Nayak
2012-07-16 11:45 ` Tero Kristo
2012-07-16 11:45 ` Tero Kristo
2012-07-16 12:14 ` Rajendra Nayak
2012-07-16 12:14 ` Rajendra Nayak
2012-07-27 19:55 ` Kevin Hilman
2012-07-27 19:55 ` Kevin Hilman
2012-07-30 8:36 ` Tero Kristo [this message]
2012-07-30 8:36 ` Tero Kristo
2012-07-13 14:19 ` [PATCHv4 7/8] ARM: OMAP: clockdomain: add support for preventing autodep delete Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-07-16 11:00 ` Rajendra Nayak
2012-07-16 11:00 ` Rajendra Nayak
2012-07-17 14:56 ` Tero Kristo
2012-07-17 14:56 ` Tero Kristo
2012-07-17 21:31 ` Paul Walmsley
2012-07-17 21:31 ` Paul Walmsley
2012-07-18 7:15 ` Rajendra Nayak
2012-07-18 7:15 ` Rajendra Nayak
2012-07-18 8:05 ` Tero Kristo
2012-07-18 8:05 ` Tero Kristo
2012-07-18 9:04 ` Rajendra Nayak
2012-07-18 9:04 ` Rajendra Nayak
2012-07-18 9:16 ` Tero Kristo
2012-07-18 9:16 ` Tero Kristo
2012-07-27 20:12 ` Kevin Hilman
2012-07-27 20:12 ` Kevin Hilman
2012-07-13 14:19 ` [PATCHv4 8/8] ARM: OMAP3: do not delete per_clkdm autodeps during idle Tero Kristo
2012-07-13 14:19 ` Tero Kristo
2012-09-18 22:25 ` Paul Walmsley
2012-09-18 22:25 ` Paul Walmsley
2012-09-18 22:43 ` Paul Walmsley
2012-09-18 22:43 ` Paul Walmsley
2012-09-19 22:15 ` Kevin Hilman
2012-09-19 22:15 ` Kevin Hilman
2012-10-16 7:29 ` Paul Walmsley
2012-10-16 7:29 ` Paul Walmsley
2012-10-17 0:39 ` Kevin Hilman
2012-10-17 0:39 ` Kevin Hilman
2012-10-31 11:59 ` Tero Kristo
2012-10-31 11:59 ` Tero Kristo
2012-09-19 9:06 ` Tero Kristo
2012-09-19 9:06 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343637371.9847.11.camel@sokoban \
--to=t-kristo@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.