From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/5] fix error return code
Date: Tue, 14 Aug 2012 08:47:33 +0200 [thread overview]
Message-ID: <1344926858-1162-1-git-send-email-Julia.Lawall@lip6.fr> (raw)
These patches fix cases where the return code appears to be unintentially 0.
The complete semantic match that finds the problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier f;
expression ret,e;
constant C;
@@
f(...) { <+...
(
return -C;
|
ret = -C
... when != ret = e
return ret;
|
if (ret < 0) { ... return ret; }
)
...+> }
@s@
identifier r.f,ret;
@@
f(...) { <+... return ret; ...+> }
@@
identifier r.f,s.ret;
expression e,e1,e2,e3,e4,x;
@@
f(...) { <+...
(
if (\(ret != 0\|ret < 0\) || ...) { ... return ...; }
|
ret = 0
)
... when != ret = e1
*x = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\|ioremap\|ioremap_nocache\|devm_ioremap\|devm_ioremap_nocache\)(...);
... when != x = e2
when != ret = e3
*if (x == NULL || ...)
{
... when != ret = e4
* return ret;
}
...+> }
// </smpl>
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/5] fix error return code
Date: Tue, 14 Aug 2012 06:47:33 +0000 [thread overview]
Message-ID: <1344926858-1162-1-git-send-email-Julia.Lawall@lip6.fr> (raw)
These patches fix cases where the return code appears to be unintentially 0.
The complete semantic match that finds the problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
identifier f;
expression ret,e;
constant C;
@@
f(...) { <+...
(
return -C;
|
ret = -C
... when != ret = e
return ret;
|
if (ret < 0) { ... return ret; }
)
...+> }
@s@
identifier r.f,ret;
@@
f(...) { <+... return ret; ...+> }
@@
identifier r.f,s.ret;
expression e,e1,e2,e3,e4,x;
@@
f(...) { <+...
(
if (\(ret != 0\|ret < 0\) || ...) { ... return ...; }
|
ret = 0
)
... when != ret = e1
*x = \(kmalloc\|kzalloc\|kcalloc\|devm_kzalloc\|ioremap\|ioremap_nocache\|devm_ioremap\|devm_ioremap_nocache\)(...);
... when != x = e2
when != ret = e3
*if (x = NULL || ...)
{
... when != ret = e4
* return ret;
}
...+> }
// </smpl>
next reply other threads:[~2012-08-14 6:47 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 6:47 Julia Lawall [this message]
2012-08-14 6:47 ` [PATCH 0/5] fix error return code Julia Lawall
2012-08-14 6:47 ` [PATCH 1/5] drivers/usb/gadget/s3c-hsotg.c: " Julia Lawall
2012-08-14 6:47 ` Julia Lawall
2012-08-14 6:47 ` [PATCH 2/5] drivers/tty/moxa.c: " Julia Lawall
2012-08-14 6:47 ` Julia Lawall
2012-08-14 6:47 ` [PATCH 3/5] drivers/usb/wusbcore/wa-hc.c: " Julia Lawall
2012-08-14 6:47 ` Julia Lawall
2012-08-14 6:47 ` [PATCH 4/5] drivers/usb/host/ohci-platform.c: " Julia Lawall
2012-08-14 6:47 ` Julia Lawall
2012-08-15 14:37 ` Alan Stern
2012-08-15 14:37 ` Alan Stern
2012-08-14 6:47 ` [PATCH 5/5] drivers/usb/host/ehci-platform.c: " Julia Lawall
2012-08-14 6:47 ` Julia Lawall
2012-08-15 14:37 ` Alan Stern
2012-08-15 14:37 ` Alan Stern
2012-08-14 12:58 [PATCH 0/5] " Julia Lawall
2012-08-14 12:58 ` Julia Lawall
2012-08-14 12:58 ` [PATCH 1/5] drivers/cdrom/gdrom.c: " Julia Lawall
2012-08-14 12:58 ` Julia Lawall
2012-08-14 12:58 ` [PATCH 2/5] drivers/dma/amba-pl08x.c: " Julia Lawall
2012-08-14 12:58 ` Julia Lawall
2012-08-22 4:29 ` Vinod Koul
2012-08-22 4:41 ` Vinod Koul
2012-08-14 12:58 ` [PATCH 3/5] drivers/net/ethernet/freescale/fs_enet: " Julia Lawall
2012-08-14 12:58 ` Julia Lawall
2012-08-14 12:58 ` Julia Lawall
2012-08-15 0:01 ` David Miller
2012-08-15 0:01 ` David Miller
2012-08-15 0:01 ` David Miller
2012-08-14 12:58 ` [PATCH 4/5] drivers/net/ethernet/mellanox/mlx4/mcg.c: " Julia Lawall
2012-08-14 12:58 ` Julia Lawall
2012-08-15 0:01 ` David Miller
2012-08-15 0:01 ` David Miller
2012-08-14 12:58 ` [PATCH 5/5] drivers/infiniband/hw/qib/qib_iba7322.c: " Julia Lawall
2012-08-14 12:58 ` Julia Lawall
[not found] ` <1344949115-13266-6-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2012-08-14 13:14 ` Marciniszyn, Mike
2012-08-14 13:14 ` Marciniszyn, Mike
2012-08-14 13:14 ` Marciniszyn, Mike
2014-08-07 12:49 [PATCH 0/5] " Julia Lawall
2014-08-07 12:49 ` Julia Lawall
2014-08-07 12:49 ` Julia Lawall
2014-08-07 12:49 ` Julia Lawall
2014-08-07 12:49 ` [PATCH 1/5] avr32: " Julia Lawall
2014-08-07 12:49 ` Julia Lawall
2014-08-07 13:00 ` Hans-Christian Egtvedt
2014-08-07 13:00 ` Hans-Christian Egtvedt
2014-08-07 12:49 ` [PATCH 3/5] drivers/atm/atmtcp.c: " Julia Lawall
2014-08-07 12:49 ` Julia Lawall
2014-08-07 13:10 ` chas williams - CONTRACTOR
2014-08-07 13:10 ` chas williams - CONTRACTOR
2014-08-07 13:25 ` Julia Lawall
2014-08-07 13:25 ` Julia Lawall
2014-08-07 13:31 ` Julia Lawall
2014-08-07 13:31 ` Julia Lawall
2014-08-07 13:41 ` chas williams - CONTRACTOR
2014-08-07 13:41 ` chas williams - CONTRACTOR
2014-08-07 23:05 ` David Miller
2014-08-07 23:05 ` David Miller
2014-08-07 12:49 ` [PATCH 2/5] solos-pci: " Julia Lawall
2014-08-07 12:49 ` Julia Lawall
2014-08-07 13:14 ` chas williams - CONTRACTOR
2014-08-07 13:14 ` chas williams - CONTRACTOR
2014-08-07 23:04 ` David Miller
2014-08-07 23:04 ` David Miller
2014-08-07 12:49 ` [PATCH 4/5] netfilter: nf_tables: " Julia Lawall
2014-08-07 12:49 ` Julia Lawall
2014-08-11 16:41 ` Pablo Neira Ayuso
2014-08-11 16:41 ` Pablo Neira Ayuso
2014-08-07 12:49 ` [PATCH 5/5] kexec: " Julia Lawall
2014-08-07 12:49 ` Julia Lawall
2014-08-07 12:49 ` Julia Lawall
2014-11-23 13:11 [PATCH 0/5] " Julia Lawall
2014-11-23 13:11 ` Julia Lawall
2014-11-23 13:11 ` Julia Lawall
2014-11-23 13:11 ` Julia Lawall
2014-11-23 13:11 ` [PATCH 1/5] mptfusion: " Julia Lawall
2014-11-23 13:11 ` Julia Lawall
2014-11-23 13:11 ` [PATCH 2/5] drm/exynos/ipp: " Julia Lawall
2014-11-23 13:11 ` Julia Lawall
2014-11-23 13:11 ` Julia Lawall
2014-11-23 13:11 ` [PATCH 3/5] electra_cf: " Julia Lawall
2014-11-23 13:11 ` Julia Lawall
2014-11-23 13:11 ` [PATCH 4/5] drm/rcar-du: " Julia Lawall
2014-11-23 13:11 ` Julia Lawall
2014-11-26 22:01 ` Laurent Pinchart
2014-11-26 22:01 ` Laurent Pinchart
2014-11-23 13:11 ` [PATCH 5/5] drivers/gpu/drm: " Julia Lawall
2014-11-23 13:11 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344926858-1162-1-git-send-email-Julia.Lawall@lip6.fr \
--to=julia.lawall@lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.