From: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> To: linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org, Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>, Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> Subject: [PATCHv6 12/24] i2c: omap: bus: add a receiver flag Date: Tue, 14 Aug 2012 19:48:54 +0530 [thread overview] Message-ID: <1344953946-13005-13-git-send-email-shubhrajyoti@ti.com> (raw) In-Reply-To: <1344953946-13005-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> From: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> that way we can ignore TX IRQs while in receiver mode and ignore RX IRQs while in transmitter mode. Signed-off-by: Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> [Remove unnecessary braces] Signed-off-by: Shubhrajyoti D <shubhrajyoti-l0cyMroinI0@public.gmane.org> --- drivers/i2c/busses/i2c-omap.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index e9907b5..fa54d41 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -199,6 +199,7 @@ struct omap_i2c_dev { */ u8 rev; unsigned b_hw:1; /* bad h/w fixes */ + unsigned receiver:1; /* true when we're in receiver mode */ u16 iestate; /* Saved interrupt register */ u16 pscstate; u16 scllstate; @@ -492,6 +493,7 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap, INIT_COMPLETION(dev->cmd_complete); dev->cmd_err = 0; + dev->receiver = !!(msg->flags & I2C_M_RD); w = OMAP_I2C_CON_EN | OMAP_I2C_CON_MST | OMAP_I2C_CON_STT; @@ -837,6 +839,12 @@ omap_i2c_isr(int this_irq, void *dev_id) stat = omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG); stat &= bits; + /* If we're in receiver mode, ignore XDR/XRDY */ + if (dev->receiver) + stat &= ~(OMAP_I2C_STAT_XDR | OMAP_I2C_STAT_XRDY); + else + stat &= ~(OMAP_I2C_STAT_RDR | OMAP_I2C_STAT_RRDY); + if (!stat) { /* my work here is done */ return IRQ_HANDLED; -- 1.7.5.4
WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti D) To: linux-arm-kernel@lists.infradead.org Subject: [PATCHv6 12/24] i2c: omap: bus: add a receiver flag Date: Tue, 14 Aug 2012 19:48:54 +0530 [thread overview] Message-ID: <1344953946-13005-13-git-send-email-shubhrajyoti@ti.com> (raw) In-Reply-To: <1344953946-13005-1-git-send-email-shubhrajyoti@ti.com> From: Felipe Balbi <balbi@ti.com> that way we can ignore TX IRQs while in receiver mode and ignore RX IRQs while in transmitter mode. Signed-off-by: Felipe Balbi <balbi@ti.com> [Remove unnecessary braces] Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com> --- drivers/i2c/busses/i2c-omap.c | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c index e9907b5..fa54d41 100644 --- a/drivers/i2c/busses/i2c-omap.c +++ b/drivers/i2c/busses/i2c-omap.c @@ -199,6 +199,7 @@ struct omap_i2c_dev { */ u8 rev; unsigned b_hw:1; /* bad h/w fixes */ + unsigned receiver:1; /* true when we're in receiver mode */ u16 iestate; /* Saved interrupt register */ u16 pscstate; u16 scllstate; @@ -492,6 +493,7 @@ static int omap_i2c_xfer_msg(struct i2c_adapter *adap, INIT_COMPLETION(dev->cmd_complete); dev->cmd_err = 0; + dev->receiver = !!(msg->flags & I2C_M_RD); w = OMAP_I2C_CON_EN | OMAP_I2C_CON_MST | OMAP_I2C_CON_STT; @@ -837,6 +839,12 @@ omap_i2c_isr(int this_irq, void *dev_id) stat = omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG); stat &= bits; + /* If we're in receiver mode, ignore XDR/XRDY */ + if (dev->receiver) + stat &= ~(OMAP_I2C_STAT_XDR | OMAP_I2C_STAT_XRDY); + else + stat &= ~(OMAP_I2C_STAT_RDR | OMAP_I2C_STAT_RRDY); + if (!stat) { /* my work here is done */ return IRQ_HANDLED; -- 1.7.5.4
next prev parent reply other threads:[~2012-08-14 14:18 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-08-14 14:18 [PATCHv6 00/24] I2C big cleanup Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 01/24] i2c: omap: switch to devm_* API Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 02/24] i2c: omap: simplify num_bytes handling Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 03/24] i2c: omap: decrease indentation level on data handling Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 04/24] i2c: omap: add blank lines Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 05/24] i2c: omap: simplify omap_i2c_ack_stat() Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 07/24] i2c: omap: improve i462 errata handling Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 08/24] i2c: omap: re-factor receive/transmit data loop Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 09/24] i2c: omap: switch over to do {} while loop Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 11/24] i2c: omap: switch to platform_get_irq() Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 13/24] i2c: omap: simplify errata check Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 14/24] i2c: omap: always return IRQ_HANDLED Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D [not found] ` <1344953946-13005-15-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> 2012-08-16 3:18 ` Hebbar, Gururaja 2012-08-16 3:18 ` Hebbar, Gururaja 2012-08-14 14:18 ` [PATCHv6 15/24] i2c: omap: simplify IRQ exit path Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 16/24] i2c: omap: resize fifos before each message Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 17/24] i2c: omap: get rid of the "complete" label Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D [not found] ` <1344953946-13005-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> 2012-08-14 14:18 ` [PATCHv6 06/24] i2c: omap: split out [XR]DR and [XR]RDY Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` [PATCHv6 10/24] i2c: omap: ack IRQ in parts Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D 2012-08-14 14:18 ` Shubhrajyoti D [this message] 2012-08-14 14:18 ` [PATCHv6 12/24] i2c: omap: bus: add a receiver flag Shubhrajyoti D 2012-08-14 14:19 ` [PATCHv6 18/24] i2c: omap: remove redundant status read Shubhrajyoti D 2012-08-14 14:19 ` Shubhrajyoti D 2012-08-14 14:19 ` [PATCHv6 19/24] i2c: omap: always return IRQ_HANDLED Shubhrajyoti D 2012-08-14 14:19 ` Shubhrajyoti D 2012-08-14 14:19 ` [PATCHv6 20/24] i2c: omap: switch to threaded IRQ support Shubhrajyoti D 2012-08-14 14:19 ` Shubhrajyoti D 2012-08-14 14:19 ` [PATCHv6 21/24] i2c: omap: remove unnecessary pm_runtime_suspended check Shubhrajyoti D 2012-08-14 14:19 ` Shubhrajyoti D 2012-08-14 14:19 ` [PATCHv6 22/24] i2c: omap: switch over to autosuspend API Shubhrajyoti D 2012-08-14 14:19 ` Shubhrajyoti D 2012-08-14 14:19 ` [PATCHv6 23/24] i2c: omap: sanitize exit path Shubhrajyoti D 2012-08-14 14:19 ` Shubhrajyoti D 2012-08-14 14:19 ` [PATCHv6 24/24] i2c: omap: Prevent NULL pointer dereference in remove Shubhrajyoti D 2012-08-14 14:19 ` Shubhrajyoti D [not found] ` <1344953946-13005-25-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org> 2012-08-15 6:03 ` Felipe Balbi 2012-08-15 6:03 ` Felipe Balbi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1344953946-13005-13-git-send-email-shubhrajyoti@ti.com \ --to=shubhrajyoti-l0cymroini0@public.gmane.org \ --cc=balbi-l0cyMroinI0@public.gmane.org \ --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \ --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \ --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \ --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.