All of lore.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: alan@linux.intel.com
Cc: Tony Lindgren <tony@atomide.com>, Kevin Hilman <khilman@ti.com>,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	Linux ARM Kernel Mailing List 
	<linux-arm-kernel@lists.infradead.org>,
	linux-serial@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	Shubhrajyoti Datta <shubhrajyoti@ti.com>,
	Felipe Balbi <balbi@ti.com>
Subject: [PATCH v2 00/13] OMAP Serial patches
Date: Tue, 21 Aug 2012 15:15:58 +0300	[thread overview]
Message-ID: <1345551371-18862-1-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1345540555-24359-1-git-send-email-balbi@ti.com>

Hi guys,

here's a series of cleanup patches to the OMAP serial
driver. A later series could be made re-implementing
DMA using the DMA Engine API. Note that for RX DMA
we could be using RX Timeout IRQ as a hint that we better
use PIO instead ;-)

All patches were tested on my pandaboard, but I'd really
like to receive Tested-by on other platforms.

After this goes in, I'll probably try to get UART wakeup
working again and only after that look at DMA.

Changes since v1:

	. improved commit log on patch 9/13 (formerly 10/13)
	. removed patch 2/13
	. added a new patch switching from spin_lock_irqsave() to spin_lock and
		spin_unlock_irqrestore to spin_unlock

Retested with my pandaboard, UART continues to work:

 # grep -i uart /proc/interrupts
 106:        124          0       GIC  OMAP UART2
 #  grep -i uart /proc/interrupts
 106:        189          0       GIC  OMAP UART2
 #  grep -i uart /proc/interrupts
 106:        255          0       GIC  OMAP UART2
 #  grep -i uart /proc/interrupts
 106:        321          0       GIC  OMAP UART2
 #  grep -i uart /proc/interrupts
 106:        387          0       GIC  OMAP UART2
 #  grep -i uart /proc/interrupts
 106:        453          0       GIC  OMAP UART2
 #  grep -i uart /proc/interrupts
 106:        519          0       GIC  OMAP UART2

cheers

ps: if anyone knows a better test for UART, let me know.

for convenience of anyone testing, patches are available on my git tree [1] on
branch uart

[1] git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git uart

Felipe Balbi (13):
  serial: omap: define and use to_uart_omap_port()
  serial: omap: define helpers for pdata function pointers
  serial: omap: don't access the platform_device
  serial: omap: drop DMA support
  serial: add OMAP-specific defines
  serial: omap: simplify IRQ handling
  serial: omap: refactor receive_chars() into rdi/rlsi handlers
  serial: omap: move THRE check to transmit_chars()
  serial: omap: stick to put_autosuspend
  serial: omap: set dev->drvdata before enabling pm_runtime
  serial: omap: drop unnecessary check from remove
  serial: omap: make sure to suspend device before remove
  serial: omap: don't save IRQ flags on hardirq

 arch/arm/mach-omap2/serial.c                  |  15 +-
 arch/arm/plat-omap/include/plat/omap-serial.h |  12 +-
 drivers/tty/serial/omap-serial.c              | 713 +++++++++-----------------
 include/linux/serial_reg.h                    |   4 +
 4 files changed, 254 insertions(+), 490 deletions(-)

-- 
1.7.12.rc3


WARNING: multiple messages have this Message-ID (diff)
From: balbi@ti.com (Felipe Balbi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 00/13] OMAP Serial patches
Date: Tue, 21 Aug 2012 15:15:58 +0300	[thread overview]
Message-ID: <1345551371-18862-1-git-send-email-balbi@ti.com> (raw)
In-Reply-To: <1345540555-24359-1-git-send-email-balbi@ti.com>

Hi guys,

here's a series of cleanup patches to the OMAP serial
driver. A later series could be made re-implementing
DMA using the DMA Engine API. Note that for RX DMA
we could be using RX Timeout IRQ as a hint that we better
use PIO instead ;-)

All patches were tested on my pandaboard, but I'd really
like to receive Tested-by on other platforms.

After this goes in, I'll probably try to get UART wakeup
working again and only after that look at DMA.

Changes since v1:

	. improved commit log on patch 9/13 (formerly 10/13)
	. removed patch 2/13
	. added a new patch switching from spin_lock_irqsave() to spin_lock and
		spin_unlock_irqrestore to spin_unlock

Retested with my pandaboard, UART continues to work:

 # grep -i uart /proc/interrupts
 106:        124          0       GIC  OMAP UART2
 #  grep -i uart /proc/interrupts
 106:        189          0       GIC  OMAP UART2
 #  grep -i uart /proc/interrupts
 106:        255          0       GIC  OMAP UART2
 #  grep -i uart /proc/interrupts
 106:        321          0       GIC  OMAP UART2
 #  grep -i uart /proc/interrupts
 106:        387          0       GIC  OMAP UART2
 #  grep -i uart /proc/interrupts
 106:        453          0       GIC  OMAP UART2
 #  grep -i uart /proc/interrupts
 106:        519          0       GIC  OMAP UART2

cheers

ps: if anyone knows a better test for UART, let me know.

for convenience of anyone testing, patches are available on my git tree [1] on
branch uart

[1] git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git uart

Felipe Balbi (13):
  serial: omap: define and use to_uart_omap_port()
  serial: omap: define helpers for pdata function pointers
  serial: omap: don't access the platform_device
  serial: omap: drop DMA support
  serial: add OMAP-specific defines
  serial: omap: simplify IRQ handling
  serial: omap: refactor receive_chars() into rdi/rlsi handlers
  serial: omap: move THRE check to transmit_chars()
  serial: omap: stick to put_autosuspend
  serial: omap: set dev->drvdata before enabling pm_runtime
  serial: omap: drop unnecessary check from remove
  serial: omap: make sure to suspend device before remove
  serial: omap: don't save IRQ flags on hardirq

 arch/arm/mach-omap2/serial.c                  |  15 +-
 arch/arm/plat-omap/include/plat/omap-serial.h |  12 +-
 drivers/tty/serial/omap-serial.c              | 713 +++++++++-----------------
 include/linux/serial_reg.h                    |   4 +
 4 files changed, 254 insertions(+), 490 deletions(-)

-- 
1.7.12.rc3

  parent reply	other threads:[~2012-08-21 12:20 UTC|newest]

Thread overview: 129+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21  9:15 [RFC/PATCH 00/13] OMAP UART patches Felipe Balbi
2012-08-21  9:15 ` Felipe Balbi
2012-08-21  9:15 ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 01/13] serial: omap: define and use to_uart_omap_port() Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 02/13] serial: omap: always return IRQ_HANDLED Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21 11:50   ` Alan Cox
2012-08-21 11:50     ` Alan Cox
2012-08-21 11:50     ` Alan Cox
2012-08-21 11:54     ` Felipe Balbi
2012-08-21 11:54       ` Felipe Balbi
2012-08-21 11:54       ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 03/13] serial: omap: define helpers for pdata function pointers Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 04/13] serial: omap: don't access the platform_device Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 05/13] serial: omap: drop DMA support Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:44   ` Shilimkar, Santosh
2012-08-21  9:44     ` Shilimkar, Santosh
2012-08-21  9:44     ` Shilimkar, Santosh
2012-08-21 10:20     ` Felipe Balbi
2012-08-21 10:20       ` Felipe Balbi
2012-08-21 10:20       ` Felipe Balbi
2012-08-21 10:35       ` Shilimkar, Santosh
2012-08-21 10:35         ` Shilimkar, Santosh
2012-08-21 10:35         ` Shilimkar, Santosh
2012-08-21 10:34         ` Felipe Balbi
2012-08-21 10:34           ` Felipe Balbi
2012-08-21 10:34           ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 06/13] serial: add OMAP-specific defines Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 07/13] serial: omap: simplify IRQ handling Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 08/13] serial: omap: refactor receive_chars() into rdi/rlsi handlers Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 09/13] serial: omap: move THRE check to transmit_chars() Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 10/13] serial: omap: stick to put_autosuspend Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21 10:42   ` Shilimkar, Santosh
2012-08-21 10:42     ` Shilimkar, Santosh
2012-08-21 10:42     ` Shilimkar, Santosh
2012-08-21 10:57     ` Felipe Balbi
2012-08-21 10:57       ` Felipe Balbi
2012-08-21 10:57       ` Felipe Balbi
2012-08-21 11:05       ` Shilimkar, Santosh
2012-08-21 11:05         ` Shilimkar, Santosh
2012-08-21 11:05         ` Shilimkar, Santosh
2012-08-21 11:02         ` Felipe Balbi
2012-08-21 11:02           ` Felipe Balbi
2012-08-21 11:02           ` Felipe Balbi
2012-08-21 11:09           ` Felipe Balbi
2012-08-21 11:09             ` Felipe Balbi
2012-08-21 11:09             ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 11/13] serial: omap: set dev->drvdata before enabling pm_runtime Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 12/13] serial: omap: drop unnecessary check from remove Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15 ` [RFC/PATCH 13/13] serial: omap: make sure to suspend device before remove Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21  9:15   ` Felipe Balbi
2012-08-21 10:43 ` [RFC/PATCH 00/13] OMAP UART patches Shilimkar, Santosh
2012-08-21 10:43   ` Shilimkar, Santosh
2012-08-21 10:43   ` Shilimkar, Santosh
2012-08-21 12:15 ` Felipe Balbi [this message]
2012-08-21 12:15   ` [PATCH v2 00/13] OMAP Serial patches Felipe Balbi
2012-08-21 12:15   ` Felipe Balbi
2012-08-21 12:15   ` [PATCH v2 01/13] serial: omap: define and use to_uart_omap_port() Felipe Balbi
2012-08-21 12:15     ` Felipe Balbi
2012-08-21 12:15     ` Felipe Balbi
2012-08-21 12:16   ` [PATCH v2 02/13] serial: omap: define helpers for pdata function pointers Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16   ` [PATCH v2 03/13] serial: omap: don't access the platform_device Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16   ` [PATCH v2 04/13] serial: omap: drop DMA support Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16   ` [PATCH v2 05/13] serial: add OMAP-specific defines Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16   ` [PATCH v2 06/13] serial: omap: simplify IRQ handling Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16   ` [PATCH v2 07/13] serial: omap: refactor receive_chars() into rdi/rlsi handlers Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16   ` [PATCH v2 08/13] serial: omap: move THRE check to transmit_chars() Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16   ` [PATCH v2 09/13] serial: omap: stick to put_autosuspend Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16   ` [PATCH v2 10/13] serial: omap: set dev->drvdata before enabling pm_runtime Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16   ` [PATCH v2 11/13] serial: omap: drop unnecessary check from remove Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16   ` [PATCH v2 12/13] serial: omap: make sure to suspend device before remove Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16   ` [PATCH v2 13/13] serial: omap: don't save IRQ flags on hardirq Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 12:16     ` Felipe Balbi
2012-08-21 13:01   ` [PATCH v2 00/13] OMAP Serial patches Felipe Balbi
2012-08-21 13:01     ` Felipe Balbi
2012-08-21 13:01     ` Felipe Balbi
2012-08-21 15:07     ` Felipe Balbi
2012-08-21 15:07       ` Felipe Balbi
2012-08-21 15:07       ` Felipe Balbi
2012-08-23  6:26   ` Felipe Balbi
2012-08-23  6:26     ` Felipe Balbi
2012-08-23  6:26     ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345551371-18862-1-git-send-email-balbi@ti.com \
    --to=balbi@ti.com \
    --cc=alan@linux.intel.com \
    --cc=khilman@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    --cc=shubhrajyoti@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.