From: Shubhrajyoti D <shubhrajyoti@ti.com>
To: linux-omap@vger.kernel.org
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
ben-linux@fluff.org, tony@atomide.com, w.sang@pengutronix.de,
Felipe Balbi <balbi@ti.com>, Shubhrajyoti D <shubhrajyoti@ti.com>
Subject: [PATCHv7 13/23] i2c: omap: simplify errata check
Date: Tue, 11 Sep 2012 15:12:08 +0530 [thread overview]
Message-ID: <1347356538-23835-14-git-send-email-shubhrajyoti@ti.com> (raw)
In-Reply-To: <1347356538-23835-1-git-send-email-shubhrajyoti@ti.com>
From: Felipe Balbi <balbi@ti.com>
omap_i2c_dev is allocated with kzalloc(),
so we need not initialize b_hw to zero.
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/i2c/busses/i2c-omap.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 3be147a..7918e48 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1095,9 +1095,7 @@ omap_i2c_probe(struct platform_device *pdev)
dev->fifo_size = (dev->fifo_size / 2);
- if (dev->rev >= OMAP_I2C_REV_ON_3630_4430)
- dev->b_hw = 0; /* Disable hardware fixes */
- else
+ if (dev->rev < OMAP_I2C_REV_ON_3630_4430)
dev->b_hw = 1; /* Enable hardware fixes */
/* calculate wakeup latency constraint for MPU */
--
1.7.5.4
WARNING: multiple messages have this Message-ID (diff)
From: shubhrajyoti@ti.com (Shubhrajyoti D)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv7 13/23] i2c: omap: simplify errata check
Date: Tue, 11 Sep 2012 15:12:08 +0530 [thread overview]
Message-ID: <1347356538-23835-14-git-send-email-shubhrajyoti@ti.com> (raw)
In-Reply-To: <1347356538-23835-1-git-send-email-shubhrajyoti@ti.com>
From: Felipe Balbi <balbi@ti.com>
omap_i2c_dev is allocated with kzalloc(),
so we need not initialize b_hw to zero.
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Shubhrajyoti D <shubhrajyoti@ti.com>
---
drivers/i2c/busses/i2c-omap.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
index 3be147a..7918e48 100644
--- a/drivers/i2c/busses/i2c-omap.c
+++ b/drivers/i2c/busses/i2c-omap.c
@@ -1095,9 +1095,7 @@ omap_i2c_probe(struct platform_device *pdev)
dev->fifo_size = (dev->fifo_size / 2);
- if (dev->rev >= OMAP_I2C_REV_ON_3630_4430)
- dev->b_hw = 0; /* Disable hardware fixes */
- else
+ if (dev->rev < OMAP_I2C_REV_ON_3630_4430)
dev->b_hw = 1; /* Enable hardware fixes */
/* calculate wakeup latency constraint for MPU */
--
1.7.5.4
next prev parent reply other threads:[~2012-09-11 9:42 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 9:41 [PATCHv7 00/23]I2C big cleanup Shubhrajyoti D
2012-09-11 9:41 ` Shubhrajyoti D
2012-09-11 9:41 ` [PATCHv7 01/23] i2c: omap: switch to devm_* API Shubhrajyoti D
2012-09-11 9:41 ` Shubhrajyoti D
2012-09-11 9:41 ` [PATCHv7 02/23] i2c: omap: simplify num_bytes handling Shubhrajyoti D
2012-09-11 9:41 ` Shubhrajyoti D
2012-09-11 9:41 ` [PATCHv7 04/23] i2c: omap: add blank lines Shubhrajyoti D
2012-09-11 9:41 ` Shubhrajyoti D
[not found] ` <1347356538-23835-1-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-09-11 9:41 ` [PATCHv7 03/23] i2c: omap: decrease indentation level on data handling Shubhrajyoti D
2012-09-11 9:41 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 05/23] i2c: omap: simplify omap_i2c_ack_stat() Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 06/23] i2c: omap: split out [XR]DR and [XR]RDY Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 09/23] i2c: omap: switch over to do {} while loop Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 15/23] i2c: omap: simplify IRQ exit path Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 18/23] i2c: omap: remove redundant status read Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
[not found] ` <1347356538-23835-19-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-09-11 21:54 ` Wolfram Sang
2012-09-11 21:54 ` Wolfram Sang
[not found] ` <20120911215441.GC27031-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-12 6:51 ` Shubhrajyoti
2012-09-12 6:51 ` Shubhrajyoti
2012-09-11 9:42 ` [PATCHv7 20/23] i2c: omap: switch to threaded IRQ support Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 21:51 ` Wolfram Sang
2012-09-11 21:51 ` Wolfram Sang
[not found] ` <20120911215112.GA27031-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-12 6:25 ` Shubhrajyoti
2012-09-12 6:25 ` Shubhrajyoti
2012-09-12 11:51 ` Wolfram Sang
2012-09-12 11:51 ` Wolfram Sang
2012-09-11 9:42 ` [PATCHv7 22/23] i2c: omap: switch over to autosuspend API Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 23/23] i2c: omap: sanitize exit path Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 22:00 ` [PATCHv7 00/23]I2C big cleanup Wolfram Sang
2012-09-11 22:00 ` Wolfram Sang
2012-09-12 10:11 ` Shubhrajyoti
2012-09-12 10:11 ` Shubhrajyoti
[not found] ` <50505FDC.4090500-l0cyMroinI0@public.gmane.org>
2012-09-12 10:18 ` Wolfram Sang
2012-09-12 10:18 ` Wolfram Sang
[not found] ` <20120912101850.GB2624-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-12 13:44 ` Wolfram Sang
2012-09-12 13:44 ` Wolfram Sang
[not found] ` <20120912134427.GC16547-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-12 14:40 ` Shubhrajyoti Datta
2012-09-12 14:40 ` Shubhrajyoti Datta
2012-09-11 9:42 ` [PATCHv7 07/23] i2c: omap: improve i462 errata handling Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 08/23] i2c: omap: re-factor receive/transmit data loop Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 10/23] i2c: omap: ack IRQ in parts Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 11/23] i2c: omap: switch to platform_get_irq() Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 12/23] i2c: omap: bus: add a receiver flag Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D [this message]
2012-09-11 9:42 ` [PATCHv7 13/23] i2c: omap: simplify errata check Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 14/23] i2c: omap: always return IRQ_HANDLED Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 16/23] i2c: omap: resize fifos before each message Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 17/23] i2c: omap: get rid of the "complete" label Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 9:42 ` [PATCHv7 19/23] i2c: omap: always return IRQ_HANDLED Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
[not found] ` <1347356538-23835-20-git-send-email-shubhrajyoti-l0cyMroinI0@public.gmane.org>
2012-09-11 21:53 ` Wolfram Sang
2012-09-11 21:53 ` Wolfram Sang
[not found] ` <20120911215341.GB27031-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2012-09-12 6:42 ` Shubhrajyoti
2012-09-12 6:42 ` Shubhrajyoti
2012-09-11 9:42 ` [PATCHv7 21/23] i2c: omap: remove unnecessary pm_runtime_suspended check Shubhrajyoti D
2012-09-11 9:42 ` Shubhrajyoti D
2012-09-11 10:18 ` [PATCHv7 00/23]I2C big cleanup Shubhrajyoti
2012-09-11 10:18 ` Shubhrajyoti
2012-09-11 12:05 ` Felipe Balbi
2012-09-11 12:05 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347356538-23835-14-git-send-email-shubhrajyoti@ti.com \
--to=shubhrajyoti@ti.com \
--cc=balbi@ti.com \
--cc=ben-linux@fluff.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.