From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <a0393947@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 09/21] OMAPDSS: DISPC: Calculate scaling limits in a more generic way
Date: Fri, 14 Sep 2012 10:18:13 +0000 [thread overview]
Message-ID: <1347617893.2559.73.camel@deskari> (raw)
In-Reply-To: <505300FC.3020706@ti.com>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
On Fri, 2012-09-14 at 15:33 +0530, Archit Taneja wrote:
> On Friday 14 September 2012 03:19 PM, Tomi Valkeinen wrote:
> > I see your reasoning. I'm a bit reluctant to add a new clock term to
> > omapdss. You can't (probably) find it in the TRM. Does the TRM talk
> > about clocks with regard to WB?
>
> Yes, you can't find the word pixel clock linked to WB in the TRM.
Is there some other term for the clock related to WB?
> Yes, we could do that. I can check if zero leads to some bad results, or
> we could just bypass the scaler clock stuff if the pixel clock is 0.
I think 0 value would make more sense than a dummy 1. 1 is still a valid
clock, and it could go unnoticed in some other code paths that would use
the function to get the clock.
Of course, the scaler check function could internally check if the pck
is 0, and then use 1 in its calculations, if that makes the function
simpler.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Archit Taneja <a0393947@ti.com>
Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 09/21] OMAPDSS: DISPC: Calculate scaling limits in a more generic way
Date: Fri, 14 Sep 2012 13:18:13 +0300 [thread overview]
Message-ID: <1347617893.2559.73.camel@deskari> (raw)
In-Reply-To: <505300FC.3020706@ti.com>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
On Fri, 2012-09-14 at 15:33 +0530, Archit Taneja wrote:
> On Friday 14 September 2012 03:19 PM, Tomi Valkeinen wrote:
> > I see your reasoning. I'm a bit reluctant to add a new clock term to
> > omapdss. You can't (probably) find it in the TRM. Does the TRM talk
> > about clocks with regard to WB?
>
> Yes, you can't find the word pixel clock linked to WB in the TRM.
Is there some other term for the clock related to WB?
> Yes, we could do that. I can check if zero leads to some bad results, or
> we could just bypass the scaler clock stuff if the pixel clock is 0.
I think 0 value would make more sense than a dummy 1. 1 is still a valid
clock, and it could go unnoticed in some other code paths that would use
the function to get the clock.
Of course, the scaler check function could internally check if the pck
is 0, and then use 1 in its calculations, if that makes the function
simpler.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-09-14 10:18 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-13 12:14 [PATCH 00/21] OMAPDSS: DISPC changes for writeback pipeline Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 01/21] OMAPDSS: DISPC: Constify omap_overlay_info in dispc_ovl_setup() Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 02/21] OMAPDSS: DISPC: Rename scalar related functions from dispc_ovl_* to dispc_plane_* Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 03/21] OMAPDSS: DISPC: Rename fifo/burst " Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 04/21] OMAPDSS: DISPC: Rename misc " Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 05/21] OMAPDSS: DISPC: Simplify function names for setting pipeline input and output sizes Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 06/21] OMAPDSS: DISPC: Pass overlay caps as a parameter to dispc plane functions Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 07/21] OMAPDSS: OVERLAY: Add position and replication as overlay caps Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 08/21] OMAPDSS: DISPC: Make dispc_ovl_setup call dispc_plane_setup Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 09/21] OMAPDSS: DISPC: Calculate scaling limits in a more generic way Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-14 8:53 ` Tomi Valkeinen
2012-09-14 8:53 ` Tomi Valkeinen
2012-09-14 9:13 ` Archit Taneja
2012-09-14 9:25 ` Archit Taneja
2012-09-14 9:49 ` Tomi Valkeinen
2012-09-14 9:49 ` Tomi Valkeinen
2012-09-14 10:03 ` Archit Taneja
2012-09-14 10:15 ` Archit Taneja
2012-09-14 10:18 ` Tomi Valkeinen [this message]
2012-09-14 10:18 ` Tomi Valkeinen
2012-09-13 12:14 ` [PATCH 10/21] OMAPDSS: DISPC: Allow both upscaling and downscaling of chroma Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 11/21] OMAPDSS: DISPC: Add writeback register offsets and dss features structs Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 12/21] OMAPDSS: DISPC: Configure input and output sizes for writeback Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 13/21] OMAPDSS: DISPC: Pass dummy scalar output rates for writeback pipeline Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 14/21] OMAPDSS: DISPC: Downscale chroma if plane is writeback Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:14 ` [PATCH 15/21] OMAPDSS: DISPC: Don't set chroma resampling bit for writeback Archit Taneja
2012-09-13 12:26 ` Archit Taneja
2012-09-13 12:15 ` [PATCH 16/21] OMAPDSS: DISPC: Add function to set channel in " Archit Taneja
2012-09-13 12:27 ` Archit Taneja
2012-09-13 12:15 ` [PATCH 17/21] OMAPDSS: DISPC: Configure overlay-like parameters in dispc_wb_setup Archit Taneja
2012-09-13 12:27 ` Archit Taneja
2012-09-13 12:15 ` [PATCH 18/21] OMAPDSS: DISPC: Configure writeback specific parameters in dispc_wb_setup() Archit Taneja
2012-09-13 12:27 ` Archit Taneja
2012-09-13 12:15 ` [PATCH 19/21] OMAPDSS: DISPC: Configure writeback FIFOs Archit Taneja
2012-09-13 12:27 ` Archit Taneja
2012-09-13 12:15 ` [PATCH 20/21] OMAPDSS: DISPC: Add manager like functions for writeback Archit Taneja
2012-09-13 12:27 ` Archit Taneja
2012-09-13 12:15 ` [PATCH 21/21] OMAPDSS: DISPC: Configure color conversion coefficients " Archit Taneja
2012-09-13 12:27 ` Archit Taneja
2012-09-14 9:07 ` Tomi Valkeinen
2012-09-14 9:07 ` Tomi Valkeinen
2012-09-14 8:27 ` [PATCH 00/21] OMAPDSS: DISPC changes for writeback pipeline Tomi Valkeinen
2012-09-14 8:27 ` Tomi Valkeinen
2012-09-14 8:46 ` Tomi Valkeinen
2012-09-14 8:46 ` Tomi Valkeinen
2012-09-14 10:24 ` Archit Taneja
2012-09-14 10:36 ` Archit Taneja
2012-09-14 10:57 ` Tomi Valkeinen
2012-09-14 10:57 ` Tomi Valkeinen
2012-09-14 10:13 ` Archit Taneja
2012-09-14 10:25 ` Archit Taneja
2012-09-14 10:53 ` Tomi Valkeinen
2012-09-14 10:53 ` Tomi Valkeinen
2012-09-25 6:18 ` [PATCH v2 00/18] " Archit Taneja
2012-09-25 6:30 ` Archit Taneja
2012-09-25 6:19 ` Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 01/18] OMAPDSS: DISPC: Constify omap_overlay_info in dispc_ovl_setup() Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 02/18] OMAPDSS: DISPC: Simplify function names for setting pipeline input and output sizes Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 03/18] OMAPDSS: DISPC: Pass overlay caps as a parameter to dispc plane functions Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 04/18] OMAPDSS: OVERLAY: Add position and replication as overlay caps Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 05/18] OMAPDSS: DISPC: Make dispc_ovl_setup call dispc_ovl_setup_common Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 06/18] OMAPDSS: DISPC: Don't pass channel out when configuring overlays Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 07/18] OMAPDSS: DIPSC: Relax scaling limitations when in memory to memory mode Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 08/18] OMAPDSS: DISPC: Allow both upscaling and downscaling of chroma Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 09/18] OMAPDSS: DISPC: Add writeback register offsets and dss features structs Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 10/18] OMAPDSS: DISPC: Configure input and output sizes for writeback Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 14:33 ` Tomi Valkeinen
2012-09-25 14:33 ` Tomi Valkeinen
2012-09-26 6:22 ` Archit Taneja
2012-09-26 6:34 ` Archit Taneja
2012-09-26 6:34 ` Tomi Valkeinen
2012-09-26 6:34 ` Tomi Valkeinen
2012-09-25 6:19 ` [PATCH v2 11/18] OMAPDSS: DISPC: Downscale chroma if plane is writeback Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 12/18] OMAPDSS: DISPC: Don't set chroma resampling bit for writeback Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 13/18] OMAPDSS: DISPC: Add function to set channel in " Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 14/18] OMAPDSS: DISPC: Configure overlay-like parameters in dispc_wb_setup Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 15/18] OMAPDSS: DISPC: Configure writeback specific parameters in dispc_wb_setup() Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 16/18] OMAPDSS: DISPC: Configure writeback FIFOs Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 14:50 ` Tomi Valkeinen
2012-09-25 14:50 ` Tomi Valkeinen
2012-09-26 5:31 ` Archit Taneja
2012-09-26 5:43 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 17/18] OMAPDSS: DISPC: Add manager like functions for writeback Archit Taneja
2012-09-25 6:31 ` Archit Taneja
2012-09-25 6:19 ` [PATCH v2 18/18] OMAPDSS: DISPC: Configure color conversion coefficients " Archit Taneja
2012-09-25 6:31 ` Archit Taneja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347617893.2559.73.camel@deskari \
--to=tomi.valkeinen@ti.com \
--cc=a0393947@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.