From: Zhang Rui <rui.zhang@intel.com>
To: Amit Kachhap <amit.kachhap@linaro.org>
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
linux-pm@vger.kernel.org, patches@linaro.org,
akpm@linux-foundation.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH-Resend] thermal: Exynos: Add missing dependency
Date: Thu, 15 Nov 2012 15:04:25 +0800 [thread overview]
Message-ID: <1352963065.2080.12.camel@rzhang1-mobl4> (raw)
In-Reply-To: <CAK44p21smO8rrKoJF=47ywRCeagDudvFzZ7DhJ7TZCT7Mqv7kA@mail.gmail.com>
On Thu, 2012-11-15 at 12:31 +0530, Amit Kachhap wrote:
> On 15 November 2012 12:09, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> > CPU_FREQ_TABLE depends on CPU_FREQ. Selecting CPU_FREQ_TABLE without checking
> > for dependencies gives the following compilation warnings:
> > warning: (ARCH_TEGRA_2x_SOC && ARCH_TEGRA_3x_SOC && UX500_SOC_DB8500 &&
> > CPU_THERMAL && EXYNOS_THERMAL) selects CPU_FREQ_TABLE which has unmet
> > direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ)
> >
> > Cc: Amit Daniel Kachhap <amit.kachhap@linaro.org>
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > ---
> > drivers/thermal/Kconfig | 3 +--
> > 1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> > index 266c15e..6124c4b 100644
> > --- a/drivers/thermal/Kconfig
> > +++ b/drivers/thermal/Kconfig
> > @@ -50,8 +50,7 @@ config RCAR_THERMAL
> >
> > config EXYNOS_THERMAL
> > tristate "Temperature sensor on Samsung EXYNOS"
> > - depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) && THERMAL
> > - select CPU_FREQ_TABLE
> Hi Sachin/Rui,
>
> "select CPU_FREQ_TABLE" should be there even if CONFIG_CPU_FREQ is
> enabled. Only some governors enable it.
But CPU_THERMAL will select it, right?
> See drivers/cpufreq/Kconfig
> Also "depends THERMAL" should be there otherwise menuconfig
> parent/child relationship is broken.
>
this should be solved by my patch 1/2. :)
thanks,
rui
> Thanks,
> Amit Daniel
>
> > + depends on (ARCH_EXYNOS4 || ARCH_EXYNOS5) && CPU_THERMAL
> > help
> > If you say yes here you get support for TMU (Thermal Managment
> > Unit) on SAMSUNG EXYNOS series of SoC.
> > --
> > 1.7.4.1
> >
next prev parent reply other threads:[~2012-11-15 7:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 6:39 [PATCH-Resend] thermal: Exynos: Add missing dependency Sachin Kamat
2012-11-15 7:01 ` Amit Kachhap
2012-11-15 7:04 ` Zhang Rui [this message]
2012-11-15 7:07 ` Amit Kachhap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352963065.2080.12.camel@rzhang1-mobl4 \
--to=rui.zhang@intel.com \
--cc=akpm@linux-foundation.org \
--cc=amit.kachhap@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.