From: Jason Wang <jasowang@redhat.com> To: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, shajnocz@redhat.com Cc: krkumar2@in.ibm.com, kvm@vger.kernel.org, mprivozn@redhat.com, rusty@rustcorp.com.au, jwhan@filewood.snu.ac.kr, gaowanlong@cn.fujitsu.com, Jason Wang <jasowang@redhat.com> Subject: [PATCH V4 RESEND 14/22] tap: introduce a helper to get the name of an interface Date: Fri, 1 Feb 2013 15:39:48 +0800 [thread overview] Message-ID: <1359704396-55327-15-git-send-email-jasowang@redhat.com> (raw) In-Reply-To: <1359704396-55327-1-git-send-email-jasowang@redhat.com> This patch introduces a helper tap_get_ifname() to get the device name of tap device. This is needed when ifname is unspecified in the command line and qemu were asked to create tap device by itself. In this situation, the name were allocated by kernel, so if multiqueue is asked, we need to fetch its name after creating the first queue. Only linux has this support since it's the only platform that supports multiqueue tap. Signed-off-by: Jason Wang <jasowang@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- include/net/tap.h | 1 + net/tap-aix.c | 5 +++++ net/tap-bsd.c | 5 +++++ net/tap-haiku.c | 5 +++++ net/tap-linux.c | 14 ++++++++++++++ net/tap-solaris.c | 5 +++++ net/tap_int.h | 1 + 7 files changed, 36 insertions(+), 0 deletions(-) diff --git a/include/net/tap.h b/include/net/tap.h index a994f20..c3eb85a 100644 --- a/include/net/tap.h +++ b/include/net/tap.h @@ -37,6 +37,7 @@ void tap_set_offload(NetClientState *nc, int csum, int tso4, int tso6, int ecn, void tap_set_vnet_hdr_len(NetClientState *nc, int len); int tap_enable(NetClientState *nc); int tap_disable(NetClientState *nc); +int tap_get_ifname(NetClientState *nc, char *ifname); int tap_get_fd(NetClientState *nc); diff --git a/net/tap-aix.c b/net/tap-aix.c index 66e0574..0e1eac3 100644 --- a/net/tap-aix.c +++ b/net/tap-aix.c @@ -69,3 +69,8 @@ int tap_fd_disable(int fd) { return -1; } + +int tap_fd_get_ifname(int fd, char *ifname) +{ + return -1; +} diff --git a/net/tap-bsd.c b/net/tap-bsd.c index 5ed2d16..4f22109 100644 --- a/net/tap-bsd.c +++ b/net/tap-bsd.c @@ -155,3 +155,8 @@ int tap_fd_disable(int fd) { return -1; } + +int tap_fd_get_ifname(int fd, char *ifname) +{ + return -1; +} diff --git a/net/tap-haiku.c b/net/tap-haiku.c index 0f1b1fe..b3b5fbb 100644 --- a/net/tap-haiku.c +++ b/net/tap-haiku.c @@ -69,3 +69,8 @@ int tap_fd_disable(int fd) { return -1; } + +int tap_fd_get_ifname(int fd, char *ifname) +{ + return -1; +} diff --git a/net/tap-linux.c b/net/tap-linux.c index 42376cc..3b21662 100644 --- a/net/tap-linux.c +++ b/net/tap-linux.c @@ -260,3 +260,17 @@ int tap_fd_disable(int fd) return ret; } + +int tap_fd_get_ifname(int fd, char *ifname) +{ + struct ifreq ifr; + + if (ioctl(fd, TUNGETIFF, &ifr) != 0) { + error_report("TUNGETIFF ioctl() failed: %s", + strerror(errno)); + return -1; + } + + pstrcpy(ifname, sizeof(ifr.ifr_name), ifr.ifr_name); + return 0; +} diff --git a/net/tap-solaris.c b/net/tap-solaris.c index cc08e9e..214d95e 100644 --- a/net/tap-solaris.c +++ b/net/tap-solaris.c @@ -235,3 +235,8 @@ int tap_fd_disable(int fd) { return -1; } + +int tap_fd_get_ifname(int fd, char *ifname) +{ + return -1; +} diff --git a/net/tap_int.h b/net/tap_int.h index ca1c21b..125f83d 100644 --- a/net/tap_int.h +++ b/net/tap_int.h @@ -44,5 +44,6 @@ void tap_fd_set_offload(int fd, int csum, int tso4, int tso6, int ecn, int ufo); void tap_fd_set_vnet_hdr_len(int fd, int len); int tap_fd_enable(int fd); int tap_fd_disable(int fd); +int tap_fd_get_ifname(int fd, char *ifname); #endif /* QEMU_TAP_H */ -- 1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: aliguori@us.ibm.com, mst@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, shajnocz@redhat.com Cc: krkumar2@in.ibm.com, kvm@vger.kernel.org, mprivozn@redhat.com, Jason Wang <jasowang@redhat.com>, rusty@rustcorp.com.au, jwhan@filewood.snu.ac.kr, gaowanlong@cn.fujitsu.com Subject: [Qemu-devel] [PATCH V4 RESEND 14/22] tap: introduce a helper to get the name of an interface Date: Fri, 1 Feb 2013 15:39:48 +0800 [thread overview] Message-ID: <1359704396-55327-15-git-send-email-jasowang@redhat.com> (raw) In-Reply-To: <1359704396-55327-1-git-send-email-jasowang@redhat.com> This patch introduces a helper tap_get_ifname() to get the device name of tap device. This is needed when ifname is unspecified in the command line and qemu were asked to create tap device by itself. In this situation, the name were allocated by kernel, so if multiqueue is asked, we need to fetch its name after creating the first queue. Only linux has this support since it's the only platform that supports multiqueue tap. Signed-off-by: Jason Wang <jasowang@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- include/net/tap.h | 1 + net/tap-aix.c | 5 +++++ net/tap-bsd.c | 5 +++++ net/tap-haiku.c | 5 +++++ net/tap-linux.c | 14 ++++++++++++++ net/tap-solaris.c | 5 +++++ net/tap_int.h | 1 + 7 files changed, 36 insertions(+), 0 deletions(-) diff --git a/include/net/tap.h b/include/net/tap.h index a994f20..c3eb85a 100644 --- a/include/net/tap.h +++ b/include/net/tap.h @@ -37,6 +37,7 @@ void tap_set_offload(NetClientState *nc, int csum, int tso4, int tso6, int ecn, void tap_set_vnet_hdr_len(NetClientState *nc, int len); int tap_enable(NetClientState *nc); int tap_disable(NetClientState *nc); +int tap_get_ifname(NetClientState *nc, char *ifname); int tap_get_fd(NetClientState *nc); diff --git a/net/tap-aix.c b/net/tap-aix.c index 66e0574..0e1eac3 100644 --- a/net/tap-aix.c +++ b/net/tap-aix.c @@ -69,3 +69,8 @@ int tap_fd_disable(int fd) { return -1; } + +int tap_fd_get_ifname(int fd, char *ifname) +{ + return -1; +} diff --git a/net/tap-bsd.c b/net/tap-bsd.c index 5ed2d16..4f22109 100644 --- a/net/tap-bsd.c +++ b/net/tap-bsd.c @@ -155,3 +155,8 @@ int tap_fd_disable(int fd) { return -1; } + +int tap_fd_get_ifname(int fd, char *ifname) +{ + return -1; +} diff --git a/net/tap-haiku.c b/net/tap-haiku.c index 0f1b1fe..b3b5fbb 100644 --- a/net/tap-haiku.c +++ b/net/tap-haiku.c @@ -69,3 +69,8 @@ int tap_fd_disable(int fd) { return -1; } + +int tap_fd_get_ifname(int fd, char *ifname) +{ + return -1; +} diff --git a/net/tap-linux.c b/net/tap-linux.c index 42376cc..3b21662 100644 --- a/net/tap-linux.c +++ b/net/tap-linux.c @@ -260,3 +260,17 @@ int tap_fd_disable(int fd) return ret; } + +int tap_fd_get_ifname(int fd, char *ifname) +{ + struct ifreq ifr; + + if (ioctl(fd, TUNGETIFF, &ifr) != 0) { + error_report("TUNGETIFF ioctl() failed: %s", + strerror(errno)); + return -1; + } + + pstrcpy(ifname, sizeof(ifr.ifr_name), ifr.ifr_name); + return 0; +} diff --git a/net/tap-solaris.c b/net/tap-solaris.c index cc08e9e..214d95e 100644 --- a/net/tap-solaris.c +++ b/net/tap-solaris.c @@ -235,3 +235,8 @@ int tap_fd_disable(int fd) { return -1; } + +int tap_fd_get_ifname(int fd, char *ifname) +{ + return -1; +} diff --git a/net/tap_int.h b/net/tap_int.h index ca1c21b..125f83d 100644 --- a/net/tap_int.h +++ b/net/tap_int.h @@ -44,5 +44,6 @@ void tap_fd_set_offload(int fd, int csum, int tso4, int tso6, int ecn, int ufo); void tap_fd_set_vnet_hdr_len(int fd, int len); int tap_fd_enable(int fd); int tap_fd_disable(int fd); +int tap_fd_get_ifname(int fd, char *ifname); #endif /* QEMU_TAP_H */ -- 1.7.1
next prev parent reply other threads:[~2013-02-01 7:49 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-01 7:39 [PATCH V4 RESEND 00/22] Multiqueue virtio-net Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 01/22] net: tap: using bool instead of bitfield Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 02/22] net: tap: use abort() instead of assert(0) Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 03/22] net: introduce qemu_get_queue() Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 04/22] net: introduce qemu_get_nic() Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 05/22] net: intorduce qemu_del_nic() Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 18:00 ` Eric Blake 2013-02-01 18:00 ` [Qemu-devel] " Eric Blake 2013-02-01 7:39 ` [PATCH V4 RESEND 06/22] net: introduce qemu_find_net_clients_except() Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 07/22] net: introduce qemu_net_client_setup() Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 08/22] net: introduce NetClientState destructor Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 09/22] net: multiqueue support Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-12 21:21 ` Alexander Graf 2013-02-19 7:45 ` Jason Wang 2013-02-12 21:24 ` [Qemu-devel] " Andreas Färber 2013-02-01 7:39 ` [PATCH V4 RESEND 10/22] tap: import linux multiqueue constants Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 11/22] tap: factor out common tap initialization Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 12/22] tap: add Linux multiqueue support Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 13/22] tap: support enabling or disabling a queue Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` Jason Wang [this message] 2013-02-01 7:39 ` [Qemu-devel] [PATCH V4 RESEND 14/22] tap: introduce a helper to get the name of an interface Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 15/22] tap: multiqueue support Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 22:43 ` Eric Blake 2013-02-01 22:43 ` Eric Blake 2013-02-11 10:28 ` Markus Armbruster 2013-02-20 9:28 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 17/22] virtio: introduce virtio_del_queue() Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 18/22] virtio: add a queue_index to VirtQueue Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 19/22] virtio-net: separate virtqueue from VirtIONet Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 20/22] virtio-net: multiqueue support Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 21/22] virtio-net: migration support for multiqueue Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 7:39 ` [PATCH V4 RESEND 22/22] virtio-net: compat multiqueue support Jason Wang 2013-02-01 7:39 ` [Qemu-devel] " Jason Wang 2013-02-01 8:22 ` [PATCH V4 RESEND 00/22] Multiqueue virtio-net Jason Wang 2013-02-01 8:22 ` [Qemu-devel] " Jason Wang 2013-02-04 22:53 ` Anthony Liguori
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1359704396-55327-15-git-send-email-jasowang@redhat.com \ --to=jasowang@redhat.com \ --cc=aliguori@us.ibm.com \ --cc=blauwirbel@gmail.com \ --cc=gaowanlong@cn.fujitsu.com \ --cc=jwhan@filewood.snu.ac.kr \ --cc=krkumar2@in.ibm.com \ --cc=kvm@vger.kernel.org \ --cc=mprivozn@redhat.com \ --cc=mst@redhat.com \ --cc=qemu-devel@nongnu.org \ --cc=rusty@rustcorp.com.au \ --cc=shajnocz@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.