All of lore.kernel.org
 help / color / mirror / Atom feed
From: xiaowei.hu at oracle.com <xiaowei.hu@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH]Remove unecessary ERROR when removing non-empty directory
Date: Tue, 28 May 2013 09:12:39 +0800	[thread overview]
Message-ID: <1369703559-25053-1-git-send-email-xiaowei.hu@oracle.com> (raw)

From: "Xiaowei.Hu" <xiaowei.hu@oracle.com>

Suppress the error message from being printed in ocfs2_rename
Did same thing with Goldwyn Rodrigues last patch.

While removing a non-empty directory, the kernel dumps a message:
(mv,29521,1):ocfs2_rename:1474 ERROR: status = -39 

Signed-off-by: Xiaowei Hu <xiaowei.hu@oracle.com>

---
 fs/ocfs2/namei.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ocfs2/namei.c b/fs/ocfs2/namei.c
index 50c93a8..8ef1776 100644
--- a/fs/ocfs2/namei.c
+++ b/fs/ocfs2/namei.c
@@ -1470,7 +1470,7 @@ bail:
 	brelse(old_dir_bh);
 	brelse(new_dir_bh);
 
-	if (status)
+	if (status && (status != -ENOTEMPTY))
 		mlog_errno(status);
 
 	return status;
-- 
1.7.11.7

             reply	other threads:[~2013-05-28  1:12 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28  1:12 xiaowei.hu at oracle.com [this message]
2013-05-28 11:08 ` [Ocfs2-devel] [PATCH]Remove unecessary ERROR when removing non-empty directory Jeff Liu
  -- strict thread matches above, loose matches on Subject: below --
2013-05-20 15:06 [Ocfs2-devel] [PATCH] Remove " Goldwyn Rodrigues
2013-05-22 22:53 ` Sunil Mushran
2013-05-24  6:20 ` xiaowei.hu
2013-05-27  6:53   ` Jeff Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369703559-25053-1-git-send-email-xiaowei.hu@oracle.com \
    --to=xiaowei.hu@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.