From: Wolfram Sang <wsa@the-dreams.de>
To: linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
David Woodhouse <dwmw2@infradead.org>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
Josh Wu <josh.wu@atmel.com>,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
Linus Walleij <linus.walleij@linaro.org>,
linux-mtd@lists.infradead.org
Subject: [PATCH 05/12] drivers/mtd/nand: don't use devm_pinctrl_get_select_default() in probe
Date: Wed, 10 Jul 2013 16:57:40 +0100 [thread overview]
Message-ID: <1373471889-18107-5-git-send-email-wsa@the-dreams.de> (raw)
In-Reply-To: <1373471889-18107-1-git-send-email-wsa@the-dreams.de>
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/mtd/nand/atmel_nand.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 2d23d29..4653b64a 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -41,7 +41,6 @@
#include <linux/gpio.h>
#include <linux/io.h>
#include <linux/platform_data/atmel.h>
-#include <linux/pinctrl/consumer.h>
#include <mach/cpu.h>
@@ -1470,7 +1469,6 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
struct resource *mem;
struct mtd_part_parser_data ppdata = {};
int res;
- struct pinctrl *pinctrl;
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!mem) {
@@ -1515,13 +1513,6 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
nand_chip->IO_ADDR_W = host->io_base;
nand_chip->cmd_ctrl = atmel_nand_cmd_ctrl;
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl)) {
- dev_err(host->dev, "Failed to request pinctrl\n");
- res = PTR_ERR(pinctrl);
- goto err_ecc_ioremap;
- }
-
if (gpio_is_valid(host->board.rdy_pin)) {
res = gpio_request(host->board.rdy_pin, "nand_rdy");
if (res < 0) {
--
1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-kernel@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Josh Wu <josh.wu@atmel.com>,
linux-mtd@lists.infradead.org,
Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: [PATCH 05/12] drivers/mtd/nand: don't use devm_pinctrl_get_select_default() in probe
Date: Wed, 10 Jul 2013 16:57:40 +0100 [thread overview]
Message-ID: <1373471889-18107-5-git-send-email-wsa@the-dreams.de> (raw)
In-Reply-To: <1373471889-18107-1-git-send-email-wsa@the-dreams.de>
Since commit ab78029 (drivers/pinctrl: grab default handles from device core),
we can rely on device core for setting the default pins. Compile tested only.
Acked-by: Linus Walleij <linus.walleij@linaro.org> (personally at LCE13)
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---
drivers/mtd/nand/atmel_nand.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c
index 2d23d29..4653b64a 100644
--- a/drivers/mtd/nand/atmel_nand.c
+++ b/drivers/mtd/nand/atmel_nand.c
@@ -41,7 +41,6 @@
#include <linux/gpio.h>
#include <linux/io.h>
#include <linux/platform_data/atmel.h>
-#include <linux/pinctrl/consumer.h>
#include <mach/cpu.h>
@@ -1470,7 +1469,6 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
struct resource *mem;
struct mtd_part_parser_data ppdata = {};
int res;
- struct pinctrl *pinctrl;
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!mem) {
@@ -1515,13 +1513,6 @@ static int __init atmel_nand_probe(struct platform_device *pdev)
nand_chip->IO_ADDR_W = host->io_base;
nand_chip->cmd_ctrl = atmel_nand_cmd_ctrl;
- pinctrl = devm_pinctrl_get_select_default(&pdev->dev);
- if (IS_ERR(pinctrl)) {
- dev_err(host->dev, "Failed to request pinctrl\n");
- res = PTR_ERR(pinctrl);
- goto err_ecc_ioremap;
- }
-
if (gpio_is_valid(host->board.rdy_pin)) {
res = gpio_request(host->board.rdy_pin, "nand_rdy");
if (res < 0) {
--
1.7.10.4
next prev parent reply other threads:[~2013-07-10 15:59 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-10 15:57 [PATCH 01/12] drivers/gpu/drm/tilcdc: don't use devm_pinctrl_get_select_default() in probe Wolfram Sang
2013-07-10 15:57 ` [PATCH 02/12] drivers/i2c/busses: " Wolfram Sang
2013-07-10 15:57 ` Wolfram Sang
2013-08-07 15:37 ` Wolfram Sang
2013-08-07 15:37 ` Wolfram Sang
2013-07-10 15:57 ` [PATCH 03/12] drivers/misc: " Wolfram Sang
2013-07-10 23:13 ` Arnd Bergmann
2013-07-20 17:45 ` Linus Walleij
2013-07-20 17:50 ` Greg KH
2013-07-10 15:57 ` [PATCH 04/12] drivers/mmc/host: " Wolfram Sang
2013-07-10 15:57 ` Wolfram Sang
2013-07-10 15:57 ` Wolfram Sang
2013-07-10 19:57 ` Marek Vasut
2013-07-10 19:57 ` Marek Vasut
2013-07-12 3:39 ` Barry Song
2013-07-12 3:39 ` Barry Song
2013-07-10 15:57 ` Wolfram Sang [this message]
2013-07-10 15:57 ` [PATCH 05/12] drivers/mtd/nand: " Wolfram Sang
2013-08-02 15:51 ` Artem Bityutskiy
2013-08-02 15:51 ` Artem Bityutskiy
2013-07-10 15:57 ` [PATCH 06/12] drivers/mtd/nand/gpmi-nand: " Wolfram Sang
2013-07-10 15:57 ` Wolfram Sang
2013-07-11 2:14 ` Huang Shijie
2013-07-11 2:14 ` Huang Shijie
2013-07-11 2:19 ` Huang Shijie
2013-07-11 2:19 ` Huang Shijie
2013-07-20 17:48 ` Linus Walleij
2013-07-20 17:48 ` Linus Walleij
2013-08-02 15:37 ` Artem Bityutskiy
2013-08-02 15:37 ` Artem Bityutskiy
2013-07-10 15:57 ` [PATCH 07/12] drivers/net/can/c_can: " Wolfram Sang
2013-07-10 21:02 ` Marc Kleine-Budde
2013-07-10 21:14 ` David Miller
2013-07-12 0:18 ` David Miller
2013-07-10 15:57 ` [PATCH 08/12] drivers/net/ethernet/cadence: " Wolfram Sang
2013-07-11 7:40 ` Nicolas Ferre
2013-07-12 0:19 ` David Miller
2013-07-10 15:57 ` [PATCH 09/12] drivers/net/ieee802154: " Wolfram Sang
2013-07-12 0:19 ` David Miller
2013-07-12 0:19 ` David Miller
2013-07-10 15:57 ` [PATCH 10/12] drivers/pwm: " Wolfram Sang
2013-07-10 15:57 ` [PATCH 11/12] drivers/tty/serial: " Wolfram Sang
2013-07-11 7:40 ` Nicolas Ferre
2013-07-11 7:40 ` Nicolas Ferre
2013-07-20 17:46 ` Linus Walleij
2013-07-20 17:50 ` Greg KH
2013-07-10 15:57 ` [PATCH 12/12] drivers/video: " Wolfram Sang
2013-07-10 15:57 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1373471889-18107-5-git-send-email-wsa@the-dreams.de \
--to=wsa@the-dreams.de \
--cc=artem.bityutskiy@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=josh.wu@atmel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.