From: Lukasz Majewski <l.majewski@samsung.com> To: Zhang Rui <rui.zhang@intel.com>, Eduardo Valentin <eduardo.valentin@ti.com>, kgene.kim@samsung.com Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>, Linux PM list <linux-pm@vger.kernel.org>, Jonghwa Lee <jonghwa3.lee@samsung.com>, Lukasz Majewski <l.majewski@samsung.com>, Lukasz Majewski <l.majewski@majess.pl>, linux-kernel <linux-kernel@vger.kernel.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>, Tomasz Figa <t.figa@samsung.com>, Myungjoo Ham <myungjoo.ham@samsung.com>, devicetree@vger.kernel.org, Amit Daniel Kachhap <amit.daniel@samsung.com>, linux-samsung-soc@vger.kernel.org Subject: [PATCH v2 1/5] thermal: exynos: Remove check for thermal device pointer at exynos_report_trigger() Date: Wed, 09 Oct 2013 08:29:50 +0200 [thread overview] Message-ID: <1381300194-13134-2-git-send-email-l.majewski@samsung.com> (raw) In-Reply-To: <1381300194-13134-1-git-send-email-l.majewski@samsung.com> The commit 4de0bdaa9677d11406c9becb70c60887c957e1f0 ("thermal: exynos: Add support for instance based register/unregister") broke check for presence of therm_dev at global thermal zone in exynos_report_trigger(). The resulting wrong test prevents thermal_zone_device_update() call, which calls handlers for situation when trip points are passed. Such behavior prevents thermal driver from proper reaction (when TMU interrupt is raised) in a situation when overheating is detected at TMU hardware. It turns out, that after exynos thermal subsystem redesign (at v3.12) this check is not needed, since it is not possible to register thermal zone without valid thermal device. Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> Reviewed-by: Tomasz Figa <t.figa@samsung.com> --- Changes for v2: - Remove check for th_zone->therm_dev at exynos_report_trigger() drivers/thermal/samsung/exynos_thermal_common.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers/thermal/samsung/exynos_thermal_common.c index f10a6ad..c2301da 100644 --- a/drivers/thermal/samsung/exynos_thermal_common.c +++ b/drivers/thermal/samsung/exynos_thermal_common.c @@ -310,8 +310,6 @@ void exynos_report_trigger(struct thermal_sensor_conf *conf) } th_zone = conf->pzone_data; - if (th_zone->therm_dev) - return; if (th_zone->bind == false) { for (i = 0; i < th_zone->cool_dev_size; i++) { -- 1.7.10.4
WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> To: Zhang Rui <rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, Eduardo Valentin <eduardo.valentin-l0cyMroinI0@public.gmane.org>, kgene.kim-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org Cc: "Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>, Linux PM list <linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Jonghwa Lee <jonghwa3.lee-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, Lukasz Majewski <l.majewski-AM3owJQeAb5mR6Xm/wNWPw@public.gmane.org>, linux-kernel <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Bartlomiej Zolnierkiewicz <b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, Myungjoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Amit Daniel Kachhap <amit.daniel-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: [PATCH v2 1/5] thermal: exynos: Remove check for thermal device pointer at exynos_report_trigger() Date: Wed, 09 Oct 2013 08:29:50 +0200 [thread overview] Message-ID: <1381300194-13134-2-git-send-email-l.majewski@samsung.com> (raw) In-Reply-To: <1381300194-13134-1-git-send-email-l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> The commit 4de0bdaa9677d11406c9becb70c60887c957e1f0 ("thermal: exynos: Add support for instance based register/unregister") broke check for presence of therm_dev at global thermal zone in exynos_report_trigger(). The resulting wrong test prevents thermal_zone_device_update() call, which calls handlers for situation when trip points are passed. Such behavior prevents thermal driver from proper reaction (when TMU interrupt is raised) in a situation when overheating is detected at TMU hardware. It turns out, that after exynos thermal subsystem redesign (at v3.12) this check is not needed, since it is not possible to register thermal zone without valid thermal device. Signed-off-by: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Reviewed-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> --- Changes for v2: - Remove check for th_zone->therm_dev at exynos_report_trigger() drivers/thermal/samsung/exynos_thermal_common.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers/thermal/samsung/exynos_thermal_common.c index f10a6ad..c2301da 100644 --- a/drivers/thermal/samsung/exynos_thermal_common.c +++ b/drivers/thermal/samsung/exynos_thermal_common.c @@ -310,8 +310,6 @@ void exynos_report_trigger(struct thermal_sensor_conf *conf) } th_zone = conf->pzone_data; - if (th_zone->therm_dev) - return; if (th_zone->bind == false) { for (i = 0; i < th_zone->cool_dev_size; i++) { -- 1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-10-09 6:30 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-09-24 8:08 [PATCH 0/6] thermal: exynos: Fixes for v3.12 Lukasz Majewski 2013-09-24 8:08 ` [PATCH 1/6] thermal: exynos: fix: Return from exynos_report_trigger() when therm_dev is NULL Lukasz Majewski 2013-09-30 10:52 ` amit daniel kachhap 2013-09-30 10:52 ` amit daniel kachhap 2013-10-03 21:40 ` Eduardo Valentin 2013-10-03 21:40 ` Eduardo Valentin 2013-10-04 9:56 ` Lukasz Majewski 2013-10-04 9:56 ` Lukasz Majewski 2013-09-24 8:08 ` [PATCH 2/6] thermal: exynos: Provide separate TMU data for Exynos4412 Lukasz Majewski 2013-09-30 11:43 ` amit daniel kachhap 2013-09-30 11:43 ` amit daniel kachhap 2013-10-03 22:01 ` Eduardo Valentin 2013-10-03 22:01 ` Eduardo Valentin 2013-10-04 10:04 ` Lukasz Majewski 2013-09-24 8:08 ` [PATCH 3/6] thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412 Lukasz Majewski 2013-09-30 11:59 ` amit daniel kachhap 2013-09-30 11:59 ` amit daniel kachhap 2013-10-01 6:55 ` Lukasz Majewski 2013-10-01 6:55 ` Lukasz Majewski 2013-10-03 22:05 ` Eduardo Valentin 2013-10-03 22:05 ` Eduardo Valentin 2013-10-04 10:20 ` Lukasz Majewski 2013-09-24 8:08 ` [PATCH 4/6] thermal: exynos: Replace SOC_ARCH_EXYNOS with SOC_ARCH_EXYNOS5250 Lukasz Majewski 2013-09-30 12:02 ` amit daniel kachhap 2013-09-30 12:02 ` amit daniel kachhap 2013-10-03 22:08 ` Eduardo Valentin 2013-10-03 22:08 ` Eduardo Valentin 2013-10-04 10:13 ` Bartlomiej Zolnierkiewicz 2013-10-04 10:23 ` Lukasz Majewski 2013-10-04 10:47 ` Bartlomiej Zolnierkiewicz 2013-10-04 15:07 ` Eduardo Valentin 2013-10-04 15:07 ` Eduardo Valentin 2013-09-24 8:08 ` [PATCH 5/6] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12 Lukasz Majewski 2013-09-24 8:08 ` [PATCH 6/6] ARM: dts: exynos4412-trats2: Enable TMU support at Trats2 Lukasz Majewski 2013-09-24 9:29 ` [PATCH 0/6] thermal: exynos: Fixes for v3.12 Tomasz Figa 2013-10-03 13:29 ` Lukasz Majewski 2013-10-09 6:29 ` [PATCH v2 0/5] " Lukasz Majewski 2013-10-09 6:29 ` Lukasz Majewski [this message] 2013-10-09 6:29 ` [PATCH v2 1/5] thermal: exynos: Remove check for thermal device pointer at exynos_report_trigger() Lukasz Majewski 2013-10-09 6:29 ` [PATCH v2 2/5] thermal: exynos: Provide separate TMU data for Exynos4412 Lukasz Majewski 2013-10-09 6:29 ` Lukasz Majewski 2013-10-14 14:20 ` Eduardo Valentin 2013-10-14 14:20 ` Eduardo Valentin 2013-10-14 14:52 ` Lukasz Majewski 2013-10-09 6:29 ` [PATCH v2 3/5] thermal: exynos: Provide initial setting for TMU's test MUX address at Exynos4412 Lukasz Majewski 2013-10-14 14:24 ` Eduardo Valentin 2013-10-14 14:24 ` Eduardo Valentin 2013-10-14 15:00 ` Lukasz Majewski 2013-10-14 19:20 ` Eduardo Valentin 2013-10-14 19:20 ` Eduardo Valentin 2013-10-09 6:29 ` [PATCH v2 4/5] ARM: dts: exynos4x12: Device tree node definition for TMU on Exynos4x12 Lukasz Majewski 2013-10-15 6:27 ` Lukasz Majewski 2013-10-15 13:37 ` Eduardo Valentin 2013-11-27 7:11 ` Lukasz Majewski 2013-11-27 11:34 ` kgene 2013-11-27 12:39 ` Lukasz Majewski 2013-12-09 8:33 ` Lukasz Majewski 2014-11-14 10:03 ` [RESEND PATCH 1/2] " Lukasz Majewski 2014-11-14 10:03 ` Lukasz Majewski 2014-11-14 10:03 ` Lukasz Majewski 2014-11-14 10:03 ` [RESEND PATCH 2/2] ARM: dts: exynos4412-trats2: Enable TMU support at Trats2 Lukasz Majewski 2014-11-14 10:03 ` Lukasz Majewski 2014-11-14 10:03 ` Lukasz Majewski 2013-10-09 6:29 ` [PATCH v2 5/5] " Lukasz Majewski 2013-10-15 6:29 ` Lukasz Majewski 2013-11-27 7:12 ` Lukasz Majewski 2013-11-27 11:36 ` kgene 2014-11-14 9:26 ` Lukasz Majewski 2013-10-14 5:46 ` [PATCH v2 0/5] thermal: exynos: Fixes for v3.12 Lukasz Majewski 2013-10-14 5:52 ` Zhang, Rui 2013-10-14 5:52 ` Zhang, Rui 2013-10-14 19:13 ` Eduardo Valentin 2013-10-14 19:13 ` Eduardo Valentin 2013-10-14 19:22 ` Eduardo Valentin 2013-10-14 19:22 ` Eduardo Valentin 2013-10-15 6:23 ` Lukasz Majewski 2013-10-15 6:23 ` Lukasz Majewski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1381300194-13134-2-git-send-email-l.majewski@samsung.com \ --to=l.majewski@samsung.com \ --cc=amit.daniel@samsung.com \ --cc=b.zolnierkie@samsung.com \ --cc=devicetree@vger.kernel.org \ --cc=eduardo.valentin@ti.com \ --cc=jonghwa3.lee@samsung.com \ --cc=kgene.kim@samsung.com \ --cc=l.majewski@majess.pl \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=myungjoo.ham@samsung.com \ --cc=rjw@rjwysocki.net \ --cc=rui.zhang@intel.com \ --cc=t.figa@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.