From: Ian Campbell <ijc@hellion.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Ben Peddell <klightspeed@killerwolves.net>,
Jason Cooper <jason@lakedaemon.net>,
pawel.moll@arm.com, Kumar Gala <galak@codeaurora.org>,
linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/4] ARM: Kirkwood: Add support for many Synology NAS devices
Date: Thu, 06 Feb 2014 16:52:04 +0000 [thread overview]
Message-ID: <1391705524.2162.10.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <20140206165003.GJ29860@lunn.ch>
On Thu, 2014-02-06 at 17:50 +0100, Andrew Lunn wrote:
> On Thu, Feb 06, 2014 at 04:39:25PM +0000, Ian Campbell wrote:
> > On Thu, 2014-02-06 at 10:39 -0500, Jason Cooper wrote:
> > >
> > > > + pmx_fan_33: pmx-fan-33 {
> > > > + marvell,pins = "mpp33";
> > > > + marvell,function = "gpo";
> > > > + };
> >
> > Typo I think.
>
> Hi Ian
>
> drivers/pinctrl/mvebu/pinctrl-kirkwood.c:
>
> MPP_MODE(33,
> MPP_VAR_FUNCTION(0x0, "gpo", NULL, V(0, 1, 1, 1, 1, 0)),
> MPP_VAR_FUNCTION(0x2, "tdm", "dtx", V(0, 0, 1, 1, 1, 0)),
> MPP_VAR_FUNCTION(0x3, "ge1", "txctl", V(0, 1, 1, 1, 1, 0)),
> MPP_VAR_FUNCTION(0xb, "lcd", "d13", V(0, 0, 0, 0, 1, 0))),
> MPP_MODE(34,
>
> It is output only.
Oops, Sorry for the noise!
>
> I actually had the opposite bug in v1, setup two gpo's as gpio's.
>
> Andrew
>
WARNING: multiple messages have this Message-ID (diff)
From: ijc@hellion.org.uk (Ian Campbell)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] ARM: Kirkwood: Add support for many Synology NAS devices
Date: Thu, 06 Feb 2014 16:52:04 +0000 [thread overview]
Message-ID: <1391705524.2162.10.camel@kazak.uk.xensource.com> (raw)
In-Reply-To: <20140206165003.GJ29860@lunn.ch>
On Thu, 2014-02-06 at 17:50 +0100, Andrew Lunn wrote:
> On Thu, Feb 06, 2014 at 04:39:25PM +0000, Ian Campbell wrote:
> > On Thu, 2014-02-06 at 10:39 -0500, Jason Cooper wrote:
> > >
> > > > + pmx_fan_33: pmx-fan-33 {
> > > > + marvell,pins = "mpp33";
> > > > + marvell,function = "gpo";
> > > > + };
> >
> > Typo I think.
>
> Hi Ian
>
> drivers/pinctrl/mvebu/pinctrl-kirkwood.c:
>
> MPP_MODE(33,
> MPP_VAR_FUNCTION(0x0, "gpo", NULL, V(0, 1, 1, 1, 1, 0)),
> MPP_VAR_FUNCTION(0x2, "tdm", "dtx", V(0, 0, 1, 1, 1, 0)),
> MPP_VAR_FUNCTION(0x3, "ge1", "txctl", V(0, 1, 1, 1, 1, 0)),
> MPP_VAR_FUNCTION(0xb, "lcd", "d13", V(0, 0, 0, 0, 1, 0))),
> MPP_MODE(34,
>
> It is output only.
Oops, Sorry for the noise!
>
> I actually had the opposite bug in v1, setup two gpo's as gpio's.
>
> Andrew
>
next prev parent reply other threads:[~2014-02-06 16:52 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 21:05 [PATCH 0/4] DT support for kirkwood based Synology NAS boxes Andrew Lunn
2014-02-05 21:05 ` [PATCH 1/4] Power: Reset: Generalize qnap-poweroff to with on Synology devices Andrew Lunn
2014-02-06 15:12 ` Jason Cooper
2014-02-05 21:05 ` [PATCH 2/4] DT: Vendor prefixes: Add ricoh, ssi and synology Andrew Lunn
[not found] ` <1391634309-3123-3-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2014-02-06 15:19 ` Jason Cooper
2014-02-06 15:19 ` Jason Cooper
2014-02-06 15:49 ` Rob Herring
2014-02-05 21:05 ` [PATCH 3/4] DT: i2c: Trivial: Add sii,s35390a Andrew Lunn
[not found] ` <1391634309-3123-4-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2014-02-06 15:21 ` Jason Cooper
2014-02-06 15:21 ` Jason Cooper
2014-02-05 21:05 ` [PATCH 4/4] ARM: Kirkwood: Add support for many Synology NAS devices Andrew Lunn
2014-02-06 15:39 ` Jason Cooper
2014-02-06 15:39 ` Jason Cooper
2014-02-06 16:01 ` Andrew Lunn
2014-02-06 16:01 ` Andrew Lunn
2014-02-06 16:38 ` Arnd Bergmann
2014-02-06 16:38 ` Arnd Bergmann
2014-02-06 17:03 ` Andrew Lunn
2014-02-06 17:03 ` Andrew Lunn
[not found] ` <20140206170333.GK29860-g2DYL2Zd6BY@public.gmane.org>
2014-02-06 17:26 ` Jason Cooper
2014-02-06 17:26 ` Jason Cooper
[not found] ` <20140206160126.GH29860-g2DYL2Zd6BY@public.gmane.org>
2014-02-07 7:44 ` Ben Peddell
2014-02-07 7:44 ` Ben Peddell
2014-02-10 11:41 ` Ian Campbell
2014-02-10 11:41 ` Ian Campbell
2014-02-06 16:39 ` Ian Campbell
2014-02-06 16:39 ` Ian Campbell
[not found] ` <1391704765.2162.7.camel-ommiHX4a84BXesXXhkcM7miJhflN2719@public.gmane.org>
2014-02-06 16:50 ` Andrew Lunn
2014-02-06 16:50 ` Andrew Lunn
2014-02-06 16:52 ` Ian Campbell [this message]
2014-02-06 16:52 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391705524.2162.10.camel@kazak.uk.xensource.com \
--to=ijc@hellion.org.uk \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=jason@lakedaemon.net \
--cc=klightspeed@killerwolves.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.