From: Hsin-Yu Chao <hychao@chromium.org>
To: linux-arm-kernel@lists.infradead.org
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Dylan Reid <dgreid@chromium.org>,
Chih-Chung Chang <chihchung@chromium.org>,
Xi Wang <xi.wang@gmail.com>, Hsin-Yu Chao <hychao@chromium.org>,
Ian Minett <ian_minett@creativelabs.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] ALSA: hda/ca0132 - Fix recording from mode id 0x8
Date: Fri, 7 Feb 2014 11:35:30 +0800 [thread overview]
Message-ID: <1391744130-15043-2-git-send-email-hychao@chromium.org> (raw)
In-Reply-To: <1391744130-15043-1-git-send-email-hychao@chromium.org>
The Chromebook Pixel has a microphone under the keyboard that
is attached to node id 0x8. Before this fix, recording would
always go to the main internal mic (node id 0x7).
Signed-off-by: Hsin-Yu Chao <hychao@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
---
sound/pci/hda/patch_ca0132.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index 59104dc..d5aabce 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -2770,9 +2770,7 @@ static int ca0132_capture_pcm_prepare(struct hda_pcm_stream *hinfo,
unsigned int format,
struct snd_pcm_substream *substream)
{
- struct ca0132_spec *spec = codec->spec;
-
- snd_hda_codec_setup_stream(codec, spec->adcs[substream->number],
+ snd_hda_codec_setup_stream(codec, hinfo->nid,
stream_tag, 0, format);
return 0;
--
1.9.0.rc1.175.g0b1dcb5
WARNING: multiple messages have this Message-ID (diff)
From: hychao@chromium.org (Hsin-Yu Chao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ALSA: hda/ca0132 - Fix recording from mode id 0x8
Date: Fri, 7 Feb 2014 11:35:30 +0800 [thread overview]
Message-ID: <1391744130-15043-2-git-send-email-hychao@chromium.org> (raw)
In-Reply-To: <1391744130-15043-1-git-send-email-hychao@chromium.org>
The Chromebook Pixel has a microphone under the keyboard that
is attached to node id 0x8. Before this fix, recording would
always go to the main internal mic (node id 0x7).
Signed-off-by: Hsin-Yu Chao <hychao@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>
---
sound/pci/hda/patch_ca0132.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/sound/pci/hda/patch_ca0132.c b/sound/pci/hda/patch_ca0132.c
index 59104dc..d5aabce 100644
--- a/sound/pci/hda/patch_ca0132.c
+++ b/sound/pci/hda/patch_ca0132.c
@@ -2770,9 +2770,7 @@ static int ca0132_capture_pcm_prepare(struct hda_pcm_stream *hinfo,
unsigned int format,
struct snd_pcm_substream *substream)
{
- struct ca0132_spec *spec = codec->spec;
-
- snd_hda_codec_setup_stream(codec, spec->adcs[substream->number],
+ snd_hda_codec_setup_stream(codec, hinfo->nid,
stream_tag, 0, format);
return 0;
--
1.9.0.rc1.175.g0b1dcb5
next prev parent reply other threads:[~2014-02-07 3:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-07 3:35 [PATCH 1/2] ALSA: hda/ca0132 - setup/cleanup streams Hsin-Yu Chao
2014-02-07 3:35 ` Hsin-Yu Chao
2014-02-07 3:35 ` Hsin-Yu Chao
2014-02-07 3:35 ` Hsin-Yu Chao [this message]
2014-02-07 3:35 ` [PATCH 2/2] ALSA: hda/ca0132 - Fix recording from mode id 0x8 Hsin-Yu Chao
2014-02-07 11:05 ` Takashi Iwai
2014-02-07 11:05 ` Takashi Iwai
2014-02-19 6:30 ` Hsin-Yu Chao
2014-02-19 6:30 ` Hsin-Yu Chao
2014-02-19 6:30 ` Hsin-Yu Chao
2014-02-07 10:59 ` [PATCH 1/2] ALSA: hda/ca0132 - setup/cleanup streams Takashi Iwai
2014-02-07 10:59 ` Takashi Iwai
2014-02-07 11:12 ` Takashi Iwai
2014-02-07 11:12 ` Takashi Iwai
2014-02-19 6:27 ` Hsin-Yu Chao
2014-02-19 6:27 ` Hsin-Yu Chao
2014-02-19 6:27 ` Hsin-Yu Chao
2014-02-19 6:51 ` Takashi Iwai
2014-02-19 6:51 ` Takashi Iwai
2014-02-19 6:51 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1391744130-15043-2-git-send-email-hychao@chromium.org \
--to=hychao@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=chihchung@chromium.org \
--cc=dgreid@chromium.org \
--cc=ian_minett@creativelabs.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.