From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<linux-omap@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<dmaengine@vger.kernel.org>
Cc: <davinci-linux-open-source@linux.davincidsp.com>, <joelf@ti.com>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Tony Lindgren <tony@atomide.com>, <nsekhar@ti.com>,
Jyri Sarha <jsarha@ti.com>, <mporter@linaro.org>,
<vinod.koul@intel.com>, <dan.j.williams@intel.com>
Subject: [PATCH 09/18] dma: edma: Simplify direction configuration in edma_config_pset()
Date: Thu, 13 Mar 2014 11:18:31 +0200 [thread overview]
Message-ID: <1394702320-21743-10-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1394702320-21743-1-git-send-email-peter.ujfalusi@ti.com>
We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the
check for the direction has been already done in the function calling
edma_config_pset().
The error reporting is redundant and also the "else if ()" can be removed.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/dma/edma.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index 1877319379fc..e4f4a0cef58c 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -368,14 +368,12 @@ static int edma_config_pset(struct dma_chan *chan, struct edmacc_param *pset,
src_cidx = cidx;
dst_bidx = 0;
dst_cidx = 0;
- } else if (direction == DMA_DEV_TO_MEM) {
+ } else {
+ /* DMA_DEV_TO_MEM */
src_bidx = 0;
src_cidx = 0;
dst_bidx = acnt;
dst_cidx = cidx;
- } else {
- dev_err(dev, "%s: direction not implemented yet\n", __func__);
- return -EINVAL;
}
pset->opt = EDMA_TCC(EDMA_CHAN_SLOT(echan->ch_num));
--
1.9.0
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
To: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: davinci-linux-open-source-VycZQUHpC/PFrsHnngEfi1aTQe2KTcn/@public.gmane.org,
joelf-l0cyMroinI0@public.gmane.org,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jyri Sarha <jsarha-l0cyMroinI0@public.gmane.org>,
Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Subject: [PATCH 09/18] dma: edma: Simplify direction configuration in edma_config_pset()
Date: Thu, 13 Mar 2014 11:18:31 +0200 [thread overview]
Message-ID: <1394702320-21743-10-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1394702320-21743-1-git-send-email-peter.ujfalusi-l0cyMroinI0@public.gmane.org>
We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the
check for the direction has been already done in the function calling
edma_config_pset().
The error reporting is redundant and also the "else if ()" can be removed.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi-l0cyMroinI0@public.gmane.org>
---
drivers/dma/edma.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index 1877319379fc..e4f4a0cef58c 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -368,14 +368,12 @@ static int edma_config_pset(struct dma_chan *chan, struct edmacc_param *pset,
src_cidx = cidx;
dst_bidx = 0;
dst_cidx = 0;
- } else if (direction == DMA_DEV_TO_MEM) {
+ } else {
+ /* DMA_DEV_TO_MEM */
src_bidx = 0;
src_cidx = 0;
dst_bidx = acnt;
dst_cidx = cidx;
- } else {
- dev_err(dev, "%s: direction not implemented yet\n", __func__);
- return -EINVAL;
}
pset->opt = EDMA_TCC(EDMA_CHAN_SLOT(echan->ch_num));
--
1.9.0
WARNING: multiple messages have this Message-ID (diff)
From: peter.ujfalusi@ti.com (Peter Ujfalusi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/18] dma: edma: Simplify direction configuration in edma_config_pset()
Date: Thu, 13 Mar 2014 11:18:31 +0200 [thread overview]
Message-ID: <1394702320-21743-10-git-send-email-peter.ujfalusi@ti.com> (raw)
In-Reply-To: <1394702320-21743-1-git-send-email-peter.ujfalusi@ti.com>
We only support DEV_TO_MEM or MEM_TO_DEV directions with edma driver and the
check for the direction has been already done in the function calling
edma_config_pset().
The error reporting is redundant and also the "else if ()" can be removed.
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
---
drivers/dma/edma.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c
index 1877319379fc..e4f4a0cef58c 100644
--- a/drivers/dma/edma.c
+++ b/drivers/dma/edma.c
@@ -368,14 +368,12 @@ static int edma_config_pset(struct dma_chan *chan, struct edmacc_param *pset,
src_cidx = cidx;
dst_bidx = 0;
dst_cidx = 0;
- } else if (direction == DMA_DEV_TO_MEM) {
+ } else {
+ /* DMA_DEV_TO_MEM */
src_bidx = 0;
src_cidx = 0;
dst_bidx = acnt;
dst_cidx = cidx;
- } else {
- dev_err(dev, "%s: direction not implemented yet\n", __func__);
- return -EINVAL;
}
pset->opt = EDMA_TCC(EDMA_CHAN_SLOT(echan->ch_num));
--
1.9.0
next prev parent reply other threads:[~2014-03-13 9:23 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 9:18 [PATCH 00/18] edma/ASoC: dmaengine PCM for AM335x and AM447x Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 01/18] platform_data: edma: Be precise with the paRAM struct Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 02/18] dma: edma: Add support for DMA_PAUSE/RESUME operation Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 03/18] dma: edma: Set DMA_CYCLIC capability flag Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 04/18] arm: common: edma: Select event queue 1 as default when booted with DT Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 05/18] arm: common: edma: Save the number of event queues/TCs Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 06/18] arm: common: edma: API to request non default queue for a channel Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 07/18] DMA: edma: Use different eventq for cyclic channels Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 08/18] dma: edma: Implement device_slave_caps callback Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi [this message]
2014-03-13 9:18 ` [PATCH 09/18] dma: edma: Simplify direction configuration in edma_config_pset() Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 10/18] dma: edma: Reduce debug print verbosity for non verbose debugging Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 12:53 ` Shevchenko, Andriy
2014-03-13 12:53 ` Shevchenko, Andriy
2014-03-13 12:53 ` Shevchenko, Andriy
2014-03-13 13:37 ` Peter Ujfalusi
2014-03-13 13:37 ` Peter Ujfalusi
2014-03-13 13:37 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 11/18] dma: edma: Prefix debug prints where the text were identical in prep callbacks Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 12/18] dma: edma: Add channel number to debug prints Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 13/18] dma: edma: Print the direction value as well when it is not supported Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 13:03 ` Shevchenko, Andriy
2014-03-13 13:03 ` Shevchenko, Andriy
2014-03-13 13:03 ` Shevchenko, Andriy
2014-03-13 13:40 ` [alsa-devel] " Peter Ujfalusi
2014-03-13 13:40 ` Peter Ujfalusi
2014-03-13 13:40 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 14/18] ASoC: davinci: Add edma dmaengine platform driver Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 10:28 ` [alsa-devel] " Lars-Peter Clausen
2014-03-13 10:28 ` Lars-Peter Clausen
2014-03-13 11:56 ` Peter Ujfalusi
2014-03-13 11:56 ` Peter Ujfalusi
2014-03-13 11:56 ` Peter Ujfalusi
2014-03-13 12:09 ` Lars-Peter Clausen
2014-03-13 12:09 ` Lars-Peter Clausen
2014-03-13 13:03 ` Peter Ujfalusi
2014-03-13 13:03 ` Peter Ujfalusi
2014-03-13 13:03 ` Peter Ujfalusi
2014-03-13 13:38 ` [alsa-devel] " Lars-Peter Clausen
2014-03-13 13:38 ` Lars-Peter Clausen
2014-03-13 13:38 ` Lars-Peter Clausen
2014-03-13 9:18 ` [PATCH 15/18] ASoC: davinci-mcasp: Use dmaengine based platform driver for AM335x/447x Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 16/18] ASoC: davinci-mcasp: Provide correct filter_data for dmaengine for non-DT boot Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 17/18] ASoC: davinci-mcasp: Assign the dma_data earlier in dai_probe callback Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` [PATCH 18/18] ASoC: davinci-mcasp: Place constraint on the period size based on FIFO config Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 9:18 ` Peter Ujfalusi
2014-03-13 13:46 ` [PATCH 00/18] edma/ASoC: dmaengine PCM for AM335x and AM447x Mark Brown
2014-03-13 13:46 ` Mark Brown
2014-03-14 9:38 ` Peter Ujfalusi
2014-03-14 9:38 ` Peter Ujfalusi
2014-03-14 9:38 ` Peter Ujfalusi
2014-03-14 10:13 ` Mark Brown
2014-03-14 10:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1394702320-21743-10-git-send-email-peter.ujfalusi@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=dmaengine@vger.kernel.org \
--cc=joelf@ti.com \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mporter@linaro.org \
--cc=nsekhar@ti.com \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.