All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	H Peter Anvin <h.peter.anvin@intel.com>,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, x86@kernel.org
Subject: [PATCH 4/6] x86: Use clwb in clflush_cache_range
Date: Tue, 11 Nov 2014 11:43:14 -0700	[thread overview]
Message-ID: <1415731396-19364-5-git-send-email-ross.zwisler@linux.intel.com> (raw)
In-Reply-To: <1415731396-19364-1-git-send-email-ross.zwisler@linux.intel.com>

If clwb is available on the system, use it in clflush_cache_range.
If clwb is not available, fall back to clflushopt if you can.
If clflushopt is not supported, fall all the way back to clflush.

Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: H Peter Anvin <h.peter.anvin@intel.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org
Cc: x86@kernel.org
---
 arch/x86/mm/pageattr.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
index 36de293..5229d45 100644
--- a/arch/x86/mm/pageattr.c
+++ b/arch/x86/mm/pageattr.c
@@ -126,8 +126,8 @@ within(unsigned long addr, unsigned long start, unsigned long end)
  * @vaddr:	virtual start address
  * @size:	number of bytes to flush
  *
- * clflushopt is an unordered instruction which needs fencing with mfence or
- * sfence to avoid ordering issues.
+ * clflushopt and clwb are unordered instructions which need fencing with
+ * mfence or sfence to avoid ordering issues.
  */
 void clflush_cache_range(void *vaddr, unsigned int size)
 {
@@ -136,11 +136,11 @@ void clflush_cache_range(void *vaddr, unsigned int size)
 	mb();
 
 	for (; vaddr < vend; vaddr += boot_cpu_data.x86_clflush_size)
-		clflushopt(vaddr);
+		clwb(vaddr);
 	/*
 	 * Flush any possible final partial cacheline:
 	 */
-	clflushopt(vend);
+	clwb(vend);
 
 	mb();
 }
-- 
1.9.3


  parent reply	other threads:[~2014-11-11 18:44 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-11 18:43 [PATCH 0/6] add support for new persistent memory instructions Ross Zwisler
2014-11-11 18:43 ` [PATCH 1/6] x86: Add support for the pcommit instruction Ross Zwisler
2014-11-13  3:25   ` Andy Lutomirski
2014-11-14 21:07     ` Ross Zwisler
2014-11-14 21:09       ` Andy Lutomirski
2014-11-11 18:43 ` [PATCH 2/6] x86/alternative: Add alternative_io_2 Ross Zwisler
2014-11-11 18:43 ` [PATCH 3/6] x86: Add support for the clwb instruction Ross Zwisler
2014-11-11 19:12   ` Borislav Petkov
2014-11-11 19:19     ` Borislav Petkov
2014-11-11 19:19       ` Borislav Petkov
2014-11-11 19:40       ` Ross Zwisler
2014-11-11 19:46         ` Borislav Petkov
2014-11-11 19:46           ` Borislav Petkov
2014-11-11 19:54           ` Ross Zwisler
2014-11-11 19:48     ` Ross Zwisler
2014-11-11 19:54       ` Borislav Petkov
2014-11-11 19:54         ` Borislav Petkov
2014-11-12 12:39   ` Borislav Petkov
2014-11-12 12:39     ` Borislav Petkov
2014-11-12 13:38     ` Anvin, H Peter
2014-11-12 14:12       ` Borislav Petkov
2014-11-12 14:12         ` Borislav Petkov
2014-11-13 17:47         ` Ross Zwisler
2014-11-11 18:43 ` Ross Zwisler [this message]
2014-11-11 18:43 ` [PATCH 5/6] x86: Use clwb in drm_clflush_page Ross Zwisler
2014-11-11 18:43 ` [PATCH 6/6] x86: Use clwb in drm_clflush_virt_range Ross Zwisler
2014-11-13  3:14   ` Andy Lutomirski
2014-11-13 11:20     ` Borislav Petkov
2014-11-13 11:20       ` Borislav Petkov
2014-11-13 16:38       ` Andy Lutomirski
2014-11-13 17:11         ` Borislav Petkov
2014-11-13 17:11           ` Borislav Petkov
2014-11-13 17:33           ` Ville Syrjälä
2014-11-13 17:47             ` Borislav Petkov
2014-11-13 17:47               ` Borislav Petkov
2014-11-13 18:14               ` Ville Syrjälä
2014-11-13 18:14                 ` Ville Syrjälä
2014-11-13 18:43             ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415731396-19364-5-git-send-email-ross.zwisler@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=h.peter.anvin@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.