From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Vinod Koul <vkoul@kernel.org>, David S Miller <davem@davemloft.net>
Cc: linux-arm-msm@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
netdev@vger.kernel.org, Niklas Cassel <niklas.cassel@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"Nori, Sekhar" <nsekhar@ti.com>,
Marc Gonzalez <marc.w.gonzalez@free.fr>
Subject: Re: [PATCH net-next v3 0/2] net: phy: at803x: Update delays for RGMII modes
Date: Tue, 19 Feb 2019 10:09:59 +0200 [thread overview]
Message-ID: <141dced0-aae3-e283-6579-a13cd8452e72@ti.com> (raw)
In-Reply-To: <20190219061800.31025-1-vkoul@kernel.org>
Hi Vinod,
On 19/02/2019 8.17, Vinod Koul wrote:
> Peter[1] reported that patch cd28d1d6e52e: ("net: phy: at803x: Disable
> phy delay for RGMII mode") caused regression on am335x-evmsk board.
> This board expects the Phy delay to be enabled but specified RGMII mode
> which refers to delays being disabled. So fix this by disabling delay only
> for RGMII mode and enable for RGMII_ID and RGMII_TXID/RXID modes.
>
> While at it, as pointed by Dave, don't inline the helpers.
>
> [1]: https://www.spinics.net/lists/netdev/msg550749.html
Not sure what was changed since v2, but with
https://patchwork.ozlabs.org/project/netdev/list/?series=92672
ethernet is working on am335x-evmsk. thank you:
Tested-by: Peter Ujfalusi <peter.ujflausi@ti.com>
> Vinod Koul (2):
> net: phy: at803x: don't inline helpers
> net: phy: at803x: disable delay only for RGMII mode
>
> drivers/net/phy/at803x.c | 51 ++++++++++++++++++++++++++++++----------
> 1 file changed, 38 insertions(+), 13 deletions(-)
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Vinod Koul <vkoul@kernel.org>, David S Miller <davem@davemloft.net>
Cc: <linux-arm-msm@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
<netdev@vger.kernel.org>,
Niklas Cassel <niklas.cassel@linaro.org>,
Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
"Nori, Sekhar" <nsekhar@ti.com>,
Marc Gonzalez <marc.w.gonzalez@free.fr>
Subject: Re: [PATCH net-next v3 0/2] net: phy: at803x: Update delays for RGMII modes
Date: Tue, 19 Feb 2019 10:09:59 +0200 [thread overview]
Message-ID: <141dced0-aae3-e283-6579-a13cd8452e72@ti.com> (raw)
In-Reply-To: <20190219061800.31025-1-vkoul@kernel.org>
Hi Vinod,
On 19/02/2019 8.17, Vinod Koul wrote:
> Peter[1] reported that patch cd28d1d6e52e: ("net: phy: at803x: Disable
> phy delay for RGMII mode") caused regression on am335x-evmsk board.
> This board expects the Phy delay to be enabled but specified RGMII mode
> which refers to delays being disabled. So fix this by disabling delay only
> for RGMII mode and enable for RGMII_ID and RGMII_TXID/RXID modes.
>
> While at it, as pointed by Dave, don't inline the helpers.
>
> [1]: https://www.spinics.net/lists/netdev/msg550749.html
Not sure what was changed since v2, but with
https://patchwork.ozlabs.org/project/netdev/list/?series=92672
ethernet is working on am335x-evmsk. thank you:
Tested-by: Peter Ujfalusi <peter.ujflausi@ti.com>
> Vinod Koul (2):
> net: phy: at803x: don't inline helpers
> net: phy: at803x: disable delay only for RGMII mode
>
> drivers/net/phy/at803x.c | 51 ++++++++++++++++++++++++++++++----------
> 1 file changed, 38 insertions(+), 13 deletions(-)
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2019-02-19 8:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 6:17 [PATCH net-next v3 0/2] net: phy: at803x: Update delays for RGMII modes Vinod Koul
2019-02-19 6:17 ` [PATCH net-next v3 1/2] net: phy: at803x: don't inline helpers Vinod Koul
2019-02-19 11:44 ` Marc Gonzalez
2019-02-19 11:44 ` Marc Gonzalez
2019-02-19 6:18 ` [PATCH net-next v3 2/2] net: phy: at803x: disable delay only for RGMII mode Vinod Koul
2019-02-19 11:57 ` Marc Gonzalez
2019-02-19 12:33 ` Niklas Cassel
2019-02-19 12:41 ` Marc Gonzalez
2019-02-19 8:09 ` Peter Ujfalusi [this message]
2019-02-19 8:09 ` [PATCH net-next v3 0/2] net: phy: at803x: Update delays for RGMII modes Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=141dced0-aae3-e283-6579-a13cd8452e72@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=andrew@lunn.ch \
--cc=bjorn.andersson@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=netdev@vger.kernel.org \
--cc=niklas.cassel@linaro.org \
--cc=nsekhar@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.