From: greearb@candelatech.com To: ath10k@lists.infradead.org Cc: linux-wireless@vger.kernel.org, Ben Greear <greearb@candelatech.com> Subject: [PATCH 4/8] ath10k: make dbglog debug messages be 'warn' level. Date: Mon, 12 Jan 2015 11:41:45 -0800 [thread overview] Message-ID: <1421091709-19891-4-git-send-email-greearb@candelatech.com> (raw) In-Reply-To: <1421091709-19891-1-git-send-email-greearb@candelatech.com> From: Ben Greear <greearb@candelatech.com> This only happens on firmware crash, and it appears this logic is not always perfect, so make sure the information is printed to logs at higher level. Signed-off-by: Ben Greear <greearb@candelatech.com> --- drivers/net/wireless/ath/ath10k/pci.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 0f7e845..dee0d5a 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1132,9 +1132,8 @@ static void ath10k_pci_dump_dbglog(struct ath10k *ar) return; } - ath10k_dbg(ar, ATH10K_DBG_PCI, - "debug log header, dbuf: 0x%x dropped: %i\n", - le32_to_cpu(dbg_hdr.dbuf), le32_to_cpu(dbg_hdr.dropped)); + ath10k_warn(ar, "debug log header, dbuf: 0x%x dropped: %i\n", + le32_to_cpu(dbg_hdr.dbuf), le32_to_cpu(dbg_hdr.dropped)); dbufp = le32_to_cpu(dbg_hdr.dbuf); /* i is for logging purposes and sanity check in case firmware buffers @@ -1154,11 +1153,10 @@ static void ath10k_pci_dump_dbglog(struct ath10k *ar) len = le32_to_cpu(dbuf.length); - ath10k_dbg(ar, ATH10K_DBG_PCI, - "[%i] next: 0x%x buf: 0x%x sz: %i len: %i count: %i free: %i\n", - i, le32_to_cpu(dbuf.next), le32_to_cpu(dbuf.buffer), - le32_to_cpu(dbuf.bufsize), len, - le32_to_cpu(dbuf.count), le32_to_cpu(dbuf.free)); + ath10k_warn(ar, "[%i] next: 0x%x buf: 0x%x sz: %i len: %i count: %i free: %i\n", + i, le32_to_cpu(dbuf.next), le32_to_cpu(dbuf.buffer), + le32_to_cpu(dbuf.bufsize), len, + le32_to_cpu(dbuf.count), le32_to_cpu(dbuf.free)); if (dbuf.buffer == 0 || len == 0) goto next; -- 1.7.11.7
WARNING: multiple messages have this Message-ID (diff)
From: greearb@candelatech.com To: ath10k@lists.infradead.org Cc: Ben Greear <greearb@candelatech.com>, linux-wireless@vger.kernel.org Subject: [PATCH 4/8] ath10k: make dbglog debug messages be 'warn' level. Date: Mon, 12 Jan 2015 11:41:45 -0800 [thread overview] Message-ID: <1421091709-19891-4-git-send-email-greearb@candelatech.com> (raw) In-Reply-To: <1421091709-19891-1-git-send-email-greearb@candelatech.com> From: Ben Greear <greearb@candelatech.com> This only happens on firmware crash, and it appears this logic is not always perfect, so make sure the information is printed to logs at higher level. Signed-off-by: Ben Greear <greearb@candelatech.com> --- drivers/net/wireless/ath/ath10k/pci.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/pci.c b/drivers/net/wireless/ath/ath10k/pci.c index 0f7e845..dee0d5a 100644 --- a/drivers/net/wireless/ath/ath10k/pci.c +++ b/drivers/net/wireless/ath/ath10k/pci.c @@ -1132,9 +1132,8 @@ static void ath10k_pci_dump_dbglog(struct ath10k *ar) return; } - ath10k_dbg(ar, ATH10K_DBG_PCI, - "debug log header, dbuf: 0x%x dropped: %i\n", - le32_to_cpu(dbg_hdr.dbuf), le32_to_cpu(dbg_hdr.dropped)); + ath10k_warn(ar, "debug log header, dbuf: 0x%x dropped: %i\n", + le32_to_cpu(dbg_hdr.dbuf), le32_to_cpu(dbg_hdr.dropped)); dbufp = le32_to_cpu(dbg_hdr.dbuf); /* i is for logging purposes and sanity check in case firmware buffers @@ -1154,11 +1153,10 @@ static void ath10k_pci_dump_dbglog(struct ath10k *ar) len = le32_to_cpu(dbuf.length); - ath10k_dbg(ar, ATH10K_DBG_PCI, - "[%i] next: 0x%x buf: 0x%x sz: %i len: %i count: %i free: %i\n", - i, le32_to_cpu(dbuf.next), le32_to_cpu(dbuf.buffer), - le32_to_cpu(dbuf.bufsize), len, - le32_to_cpu(dbuf.count), le32_to_cpu(dbuf.free)); + ath10k_warn(ar, "[%i] next: 0x%x buf: 0x%x sz: %i len: %i count: %i free: %i\n", + i, le32_to_cpu(dbuf.next), le32_to_cpu(dbuf.buffer), + le32_to_cpu(dbuf.bufsize), len, + le32_to_cpu(dbuf.count), le32_to_cpu(dbuf.free)); if (dbuf.buffer == 0 || len == 0) goto next; -- 1.7.11.7 _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2015-01-12 19:42 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-01-12 19:41 [PATCH 1/8] ath10k: scan should handle scan-start-failed event properly greearb 2015-01-12 19:41 ` greearb 2015-01-12 19:41 ` [PATCH 2/8] ath10k: add wmi-id to htc credits debugging greearb 2015-01-12 19:41 ` greearb 2015-01-12 19:41 ` [PATCH 3/8] ath10k: fix spelling mistakes and add details to mac logging greearb 2015-01-12 19:41 ` greearb 2015-01-12 19:41 ` greearb [this message] 2015-01-12 19:41 ` [PATCH 4/8] ath10k: make dbglog debug messages be 'warn' level greearb 2015-01-12 19:41 ` [RFC 5/8] ath10k: add firmware wmi keep-alive message greearb 2015-01-12 19:41 ` greearb 2015-01-12 19:41 ` [PATCH 6/8] ath10k: fix spelling in htt code comment greearb 2015-01-12 19:41 ` greearb 2015-01-12 19:41 ` [PATCH 7/8] ath10k: start using htt/pci/ce transfer_id properly greearb 2015-01-12 19:41 ` greearb 2015-01-12 19:41 ` [PATCH 8/8] ath10k: fix CE_DESC_FLAGS_META_DATA_LSB definition greearb 2015-01-12 19:41 ` greearb -- strict thread matches above, loose matches on Subject: below -- 2015-01-12 18:32 [PATCH 1/8] ath10k: scan should handle scan-start-failed event properly greearb 2015-01-12 18:32 ` [PATCH 4/8] ath10k: make dbglog debug messages be 'warn' level greearb 2015-01-12 18:32 ` greearb 2015-02-04 7:44 ` Kalle Valo 2015-02-04 7:44 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1421091709-19891-4-git-send-email-greearb@candelatech.com \ --to=greearb@candelatech.com \ --cc=ath10k@lists.infradead.org \ --cc=linux-wireless@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.