From: Trond Myklebust <trond.myklebust@primarydata.com>
To: linux-nfs@vger.kernel.org
Subject: [PATCH 03/11] SUNRPC: Do not clear the source port in xs_reset_transport
Date: Sun, 8 Feb 2015 22:07:34 -0500 [thread overview]
Message-ID: <1423451262-84493-4-git-send-email-trond.myklebust@primarydata.com> (raw)
In-Reply-To: <1423451262-84493-3-git-send-email-trond.myklebust@primarydata.com>
Now that we can reuse bound ports after a close, we never really want to
clear the transport's source port after it has been set. Doing so really
messes up the NFSv3 DRC on the server.
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
---
net/sunrpc/xprtsock.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 20f25a837e06..ea1882f97912 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -811,8 +811,6 @@ static void xs_reset_transport(struct sock_xprt *transport)
if (sk == NULL)
return;
- transport->srcport = 0;
-
write_lock_bh(&sk->sk_callback_lock);
transport->inet = NULL;
transport->sock = NULL;
--
2.1.0
next prev parent reply other threads:[~2015-02-09 3:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 3:07 [PATCH 00/11] Fix TCP connection port number reuse in NFSv3 Trond Myklebust
2015-02-09 3:07 ` [PATCH 01/11] SUNRPC: Set SO_REUSEPORT socket option for TCP connections Trond Myklebust
2015-02-09 3:07 ` [PATCH 02/11] SUNRPC: Handle EADDRINUSE on connect Trond Myklebust
2015-02-09 3:07 ` Trond Myklebust [this message]
2015-02-09 3:07 ` [PATCH 04/11] SUNRPC: Ensure xs_reset_transport() resets the close connection flags Trond Myklebust
2015-02-09 3:07 ` [PATCH 05/11] SUNRPC: Add helpers to prevent socket create from racing Trond Myklebust
2015-02-09 3:07 ` [PATCH 06/11] SUNRPC: TCP/UDP always close the old socket before reconnecting Trond Myklebust
2015-02-09 3:07 ` [PATCH 07/11] SUNRPC: Remove TCP client connection reset hack Trond Myklebust
2015-02-09 3:07 ` [PATCH 08/11] SUNRPC: Kill the special TCP close mechanisms Trond Myklebust
2015-02-09 3:07 ` [PATCH 09/11] SUNRPC: Remove TCP socket linger code Trond Myklebust
2015-02-09 3:07 ` [PATCH 10/11] SUNRPC: Cleanup to remove remaining uses of XPRT_CONNECTION_ABORT Trond Myklebust
2015-02-09 3:07 ` [PATCH 11/11] SUNRPC: Remove the redundant XPRT_CONNECTION_CLOSE flag Trond Myklebust
2015-02-09 15:31 ` [PATCH 09/11] SUNRPC: Remove TCP socket linger code Anna Schumaker
2015-02-09 15:37 ` Trond Myklebust
2015-02-09 15:39 ` Anna Schumaker
2015-02-09 15:59 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423451262-84493-4-git-send-email-trond.myklebust@primarydata.com \
--to=trond.myklebust@primarydata.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.