From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 09/11] SUNRPC: Remove TCP socket linger code
Date: Mon, 9 Feb 2015 10:39:38 -0500 [thread overview]
Message-ID: <54D8D4BA.906@Netapp.com> (raw)
In-Reply-To: <CAHQdGtQi-TZghQYZzYPOAiRtqSAw0YWSv3z6hCgUEm1usV6uFA@mail.gmail.com>
On 02/09/2015 10:37 AM, Trond Myklebust wrote:
> On Mon, Feb 9, 2015 at 10:31 AM, Anna Schumaker
> <Anna.Schumaker@netapp.com> wrote:
>>
>> Hi Trond,
>>
>> On 02/08/2015 10:07 PM, Trond Myklebust wrote:
>>> Now that we no longer use the partial shutdown code when closing the
>>> socket, we no longer need to worry about the TCP linger2 state.
>>
>> Can you also remove the "#define XS_TCP_LINGER_TO" and xs_tcp_fin_timeout from the top of xprtsock.c? It looks like they don't have any users after this patch.
>>
>> Thanks,
>> Anna
>
>
> Technically, those are part of the user ABI (being in the
> xs_tunables_table), so we should probably proceed with care before
> removing them.
Okay. Maybe at least move xs_tcp_fin_timeout so it's under CONFIG_SUNRPC_DEBUG to match when the tunables_table is defined?
>
>
>
next prev parent reply other threads:[~2015-02-09 15:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 3:07 [PATCH 00/11] Fix TCP connection port number reuse in NFSv3 Trond Myklebust
2015-02-09 3:07 ` [PATCH 01/11] SUNRPC: Set SO_REUSEPORT socket option for TCP connections Trond Myklebust
2015-02-09 3:07 ` [PATCH 02/11] SUNRPC: Handle EADDRINUSE on connect Trond Myklebust
2015-02-09 3:07 ` [PATCH 03/11] SUNRPC: Do not clear the source port in xs_reset_transport Trond Myklebust
2015-02-09 3:07 ` [PATCH 04/11] SUNRPC: Ensure xs_reset_transport() resets the close connection flags Trond Myklebust
2015-02-09 3:07 ` [PATCH 05/11] SUNRPC: Add helpers to prevent socket create from racing Trond Myklebust
2015-02-09 3:07 ` [PATCH 06/11] SUNRPC: TCP/UDP always close the old socket before reconnecting Trond Myklebust
2015-02-09 3:07 ` [PATCH 07/11] SUNRPC: Remove TCP client connection reset hack Trond Myklebust
2015-02-09 3:07 ` [PATCH 08/11] SUNRPC: Kill the special TCP close mechanisms Trond Myklebust
2015-02-09 3:07 ` [PATCH 09/11] SUNRPC: Remove TCP socket linger code Trond Myklebust
2015-02-09 3:07 ` [PATCH 10/11] SUNRPC: Cleanup to remove remaining uses of XPRT_CONNECTION_ABORT Trond Myklebust
2015-02-09 3:07 ` [PATCH 11/11] SUNRPC: Remove the redundant XPRT_CONNECTION_CLOSE flag Trond Myklebust
2015-02-09 15:31 ` [PATCH 09/11] SUNRPC: Remove TCP socket linger code Anna Schumaker
2015-02-09 15:37 ` Trond Myklebust
2015-02-09 15:39 ` Anna Schumaker [this message]
2015-02-09 15:59 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54D8D4BA.906@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.