From: Julia Lawall <Julia.Lawall@lip6.fr> To: Jaroslav Kysela <perex@perex.cz> Cc: kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH 7/9] sound/pci/sis7019.c: fix error return code Date: Sun, 5 Apr 2015 13:38:29 +0200 [thread overview] Message-ID: <1428233914-4503-5-git-send-email-Julia.Lawall@lip6.fr> (raw) In-Reply-To: <1428233914-4503-1-git-send-email-Julia.Lawall@lip6.fr> From: Julia Lawall <Julia.Lawall@lip6.fr> Initialize rc before returning on failure, as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- sound/pci/sis7019.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/pci/sis7019.c b/sound/pci/sis7019.c index 535efe2..51e4340 100644 --- a/sound/pci/sis7019.c +++ b/sound/pci/sis7019.c @@ -1377,8 +1377,9 @@ static int __devinit sis_chip_create(struct snd_card *card, if (rc) goto error_out_cleanup; - if (request_irq(pci->irq, sis_interrupt, IRQF_SHARED, KBUILD_MODNAME, - sis)) { + rc = request_irq(pci->irq, sis_interrupt, IRQF_SHARED, KBUILD_MODNAME, + sis); + if (rc) { dev_err(&pci->dev, "unable to allocate irq %d\n", sis->irq); goto error_out_cleanup; }
WARNING: multiple messages have this Message-ID (diff)
From: Julia Lawall <Julia.Lawall@lip6.fr> To: Jaroslav Kysela <perex@perex.cz> Cc: kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH 7/9] sound/pci/sis7019.c: fix error return code Date: Sun, 05 Apr 2015 11:38:29 +0000 [thread overview] Message-ID: <1428233914-4503-5-git-send-email-Julia.Lawall@lip6.fr> (raw) In-Reply-To: <1428233914-4503-1-git-send-email-Julia.Lawall@lip6.fr> From: Julia Lawall <Julia.Lawall@lip6.fr> Initialize rc before returning on failure, as done elsewhere in the function. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // <smpl> ( if@p1 (\(ret < 0\|ret != 0\)) { ... return ret; } | ret@p1 = 0 ) ... when != ret = e1 when != &ret *if(...) { ... when != ret = e2 when forall return ret; } // </smpl> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr> --- sound/pci/sis7019.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/sound/pci/sis7019.c b/sound/pci/sis7019.c index 535efe2..51e4340 100644 --- a/sound/pci/sis7019.c +++ b/sound/pci/sis7019.c @@ -1377,8 +1377,9 @@ static int __devinit sis_chip_create(struct snd_card *card, if (rc) goto error_out_cleanup; - if (request_irq(pci->irq, sis_interrupt, IRQF_SHARED, KBUILD_MODNAME, - sis)) { + rc = request_irq(pci->irq, sis_interrupt, IRQF_SHARED, KBUILD_MODNAME, + sis); + if (rc) { dev_err(&pci->dev, "unable to allocate irq %d\n", sis->irq); goto error_out_cleanup; }
next prev parent reply other threads:[~2015-04-05 11:47 UTC|newest] Thread overview: 117+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-05 11:38 [PATCH 0/10] fix error return code Julia Lawall 2015-04-05 11:38 ` Julia Lawall 2015-04-05 11:38 ` [PATCH 2/10] sound/soc/fsl/imx-sgtl5000.c: " Julia Lawall 2015-04-05 11:38 ` Julia Lawall 2015-04-05 12:13 ` Julia Lawall 2015-04-05 12:13 ` Julia Lawall 2015-04-05 11:38 ` [PATCH 1/10] sound/soc/ux500/ux500_msp_i2s.c: better use devm functions and " Julia Lawall 2015-04-05 11:38 ` Julia Lawall 2015-04-05 12:12 ` Julia Lawall 2015-04-05 12:12 ` [PATCH 1/10] sound/soc/ux500/ux500_msp_i2s.c: better use devm functions and fix error return cod Julia Lawall 2015-04-05 11:38 ` [PATCH 8/9] sound/pci/rme9652/hdspm.c: fix error return code Julia Lawall 2015-04-05 11:38 ` Julia Lawall 2015-04-05 12:13 ` Julia Lawall 2015-04-05 12:13 ` Julia Lawall 2015-04-05 11:38 ` Julia Lawall [this message] 2015-04-05 11:38 ` [PATCH 7/9] sound/pci/sis7019.c: " Julia Lawall 2015-04-05 12:13 ` Julia Lawall 2015-04-05 12:13 ` Julia Lawall 2015-04-05 11:38 ` [PATCH 6/9] sound/pci/ctxfi/ctatc.c: " Julia Lawall 2015-04-05 11:38 ` Julia Lawall 2015-04-05 12:13 ` Julia Lawall 2015-04-05 12:13 ` Julia Lawall 2015-04-05 11:38 ` [PATCH 5/9] sound/atmel/ac97c.c: " Julia Lawall 2015-04-05 11:38 ` Julia Lawall 2015-04-05 12:13 ` Julia Lawall 2015-04-05 12:13 ` Julia Lawall 2015-04-05 11:38 ` [PATCH 3/10] sound/atmel/abdac.c: " Julia Lawall 2015-04-05 11:38 ` Julia Lawall 2015-04-05 12:12 ` Julia Lawall 2015-04-05 12:12 ` Julia Lawall 2015-04-05 11:38 ` [PATCH 9/9] sound/ppc/snd_ps3.c: " Julia Lawall 2015-04-05 11:38 ` Julia Lawall 2015-04-05 11:38 ` Julia Lawall 2015-04-05 11:38 ` Julia Lawall 2015-04-05 11:52 ` Geert Uytterhoeven 2015-04-05 11:52 ` Geert Uytterhoeven 2015-04-05 11:52 ` Geert Uytterhoeven 2015-04-05 12:12 ` Julia Lawall 2015-04-05 12:12 ` Julia Lawall 2015-04-05 12:12 ` Julia Lawall 2015-04-05 11:38 ` [PATCH 4/9] sound/soc/omap/am3517evm.c: " Julia Lawall 2015-04-05 11:38 ` Julia Lawall 2015-04-05 12:13 ` Julia Lawall 2015-04-05 12:13 ` Julia Lawall 2015-04-05 12:12 ` [PATCH 0/10] " Julia Lawall 2015-04-05 12:12 ` Julia Lawall -- strict thread matches above, loose matches on Subject: below -- 2014-11-23 12:48 Julia Lawall 2014-11-23 12:48 ` Julia Lawall 2014-11-23 12:48 ` [PATCH 2/10] sound/soc/fsl/imx-sgtl5000.c: " Julia Lawall 2014-11-23 12:48 ` Julia Lawall 2014-11-23 12:48 ` [PATCH 1/10] sound/soc/ux500/ux500_msp_i2s.c: better use devm functions and " Julia Lawall 2014-11-23 12:48 ` Julia Lawall 2014-11-23 12:48 ` [PATCH 8/9] sound/pci/rme9652/hdspm.c: " Julia Lawall 2014-11-23 12:48 ` Julia Lawall 2014-11-23 12:48 ` [PATCH 7/9] sound/pci/sis7019.c: " Julia Lawall 2014-11-23 12:48 ` Julia Lawall 2014-11-23 12:48 ` [PATCH 6/9] sound/pci/ctxfi/ctatc.c: " Julia Lawall 2014-11-23 12:48 ` Julia Lawall 2014-11-23 17:15 ` Sudip Mukherjee 2014-11-23 17:27 ` Sudip Mukherjee 2014-11-23 17:15 ` Sudip Mukherjee 2014-11-23 19:11 ` Julia Lawall 2014-11-23 19:11 ` Julia Lawall 2014-11-23 12:48 ` [PATCH 5/9] sound/atmel/ac97c.c: " Julia Lawall 2014-11-23 12:48 ` Julia Lawall 2014-11-23 12:48 ` [PATCH 3/10] sound/atmel/abdac.c: " Julia Lawall 2014-11-23 12:48 ` Julia Lawall 2014-11-23 12:48 ` [PATCH 9/9] sound/ppc/snd_ps3.c: " Julia Lawall 2014-11-23 12:48 ` Julia Lawall 2014-11-23 12:48 ` Julia Lawall 2014-11-23 13:18 ` Julia Lawall 2014-11-23 12:48 ` [PATCH 4/9] sound/soc/omap/am3517evm.c: " Julia Lawall 2014-11-23 12:48 ` Julia Lawall 2014-11-23 13:15 ` [PATCH 0/10] " Julia Lawall 2014-11-23 13:15 ` Julia Lawall 2012-08-19 7:02 Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` [PATCH 2/10] sound/soc/fsl/imx-sgtl5000.c: " Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-20 19:44 ` Mark Brown 2012-08-20 19:44 ` Mark Brown 2012-08-20 19:44 ` Mark Brown 2012-08-19 7:02 ` [PATCH 1/10] sound/soc/ux500/ux500_msp_i2s.c: better use devm functions and " Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` [PATCH 8/9] sound/pci/rme9652/hdspm.c: " Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` [PATCH 7/9] sound/pci/sis7019.c: " Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 23:04 ` David Dillow 2012-08-19 23:04 ` David Dillow 2012-08-19 7:02 ` [PATCH 6/9] sound/pci/ctxfi/ctatc.c: " Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` [PATCH 5/9] sound/atmel/ac97c.c: " Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` [PATCH 3/10] sound/atmel/abdac.c: " Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` [PATCH 9/9] sound/ppc/snd_ps3.c: " Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:02 ` Julia Lawall 2012-08-19 7:03 ` [PATCH 4/9] sound/soc/omap/am3517evm.c: " Julia Lawall 2012-08-19 7:03 ` Julia Lawall 2012-08-20 6:09 ` Jarkko Nikula 2012-08-20 6:09 ` Jarkko Nikula 2012-08-20 9:04 ` [alsa-devel] [PATCH 0/10] " Takashi Iwai 2012-08-20 9:04 ` Takashi Iwai 2012-08-20 9:04 ` [alsa-devel] " Takashi Iwai 2012-08-20 9:15 ` Julia Lawall 2012-08-20 9:15 ` Julia Lawall 2012-08-20 9:15 ` [alsa-devel] " Julia Lawall
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1428233914-4503-5-git-send-email-Julia.Lawall@lip6.fr \ --to=julia.lawall@lip6.fr \ --cc=alsa-devel@alsa-project.org \ --cc=kernel-janitors@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=tiwai@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.