From: Paul Bolle <pebolle@tiscali.nl> To: "Matias Bjørling" <m@bjorling.me> Cc: hch@infradead.org, axboe@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, javier@paletta.io, keith.busch@intel.com Subject: Re: [PATCH 3/5 v2] lightnvm: RRPC target Date: Thu, 16 Apr 2015 11:12:39 +0200 [thread overview] Message-ID: <1429175559.16771.47.camel@x220> (raw) In-Reply-To: <1429101284-19490-4-git-send-email-m@bjorling.me> On Wed, 2015-04-15 at 14:34 +0200, Matias Bjørling wrote: > --- /dev/null > +++ b/drivers/lightnvm/Kconfig > +menuconfig NVM > + bool "Open-Channel SSD target support" > + depends on BLK_DEV_NVM > + help > + Say Y here to get to enable Open-channel SSDs. > + > + Open-Channel SSDs implement a set of extension to SSDs, that > + exposes direct access to the underlying non-volatile memory. > + > + If you say N, all options in this submenu will be skipped and disabled > + only do this if you know what you are doing. > + > +if NVM > + > +config NVM_RRPC > + tristate "Round-robin Hybrid Open-Channel SSD" > + depends on BLK_DEV_NVM NVM implies BLK_DEV_NVM so this dependency isn't really needed. > + ---help--- > + Allows an open-channel SSD to be exposed as a block device to the > + host. The target is implemented using a linear mapping table and > + cost-based garbage collection. It is optimized for 4K IO sizes. > + > + See Documentation/nvm-rrpc.txt for details. This file isn't part of this series, is it? > + > +endif # NVM > diff --git a/drivers/lightnvm/Makefile b/drivers/lightnvm/Makefile > new file mode 100644 > index 0000000..80d75a8 > --- /dev/null > +++ b/drivers/lightnvm/Makefile > @@ -0,0 +1,5 @@ > +# > +# Makefile for Open-Channel SSDs. > +# > + > +obj-$(CONFIG_NVM) += rrpc.o I suppose you meant to use obj-$(CONFIG_NVM_RRPC) += rrpc.o because otherwise setting NVM_RRPC has no effect. > --- /dev/null > +++ b/drivers/lightnvm/rrpc.c > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License version > + * 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. This states the license is GPL v2. > +MODULE_LICENSE("GPL"); And (according to include/linux/module.h) the license ident "GPL" states the license is GPL v2 or later. So either the comment at the top of this file or the license ident needs to change. Thanks, Paul Bolle
WARNING: multiple messages have this Message-ID (diff)
From: pebolle@tiscali.nl (Paul Bolle) Subject: [PATCH 3/5 v2] lightnvm: RRPC target Date: Thu, 16 Apr 2015 11:12:39 +0200 [thread overview] Message-ID: <1429175559.16771.47.camel@x220> (raw) In-Reply-To: <1429101284-19490-4-git-send-email-m@bjorling.me> On Wed, 2015-04-15@14:34 +0200, Matias Bj?rling wrote: > --- /dev/null > +++ b/drivers/lightnvm/Kconfig > +menuconfig NVM > + bool "Open-Channel SSD target support" > + depends on BLK_DEV_NVM > + help > + Say Y here to get to enable Open-channel SSDs. > + > + Open-Channel SSDs implement a set of extension to SSDs, that > + exposes direct access to the underlying non-volatile memory. > + > + If you say N, all options in this submenu will be skipped and disabled > + only do this if you know what you are doing. > + > +if NVM > + > +config NVM_RRPC > + tristate "Round-robin Hybrid Open-Channel SSD" > + depends on BLK_DEV_NVM NVM implies BLK_DEV_NVM so this dependency isn't really needed. > + ---help--- > + Allows an open-channel SSD to be exposed as a block device to the > + host. The target is implemented using a linear mapping table and > + cost-based garbage collection. It is optimized for 4K IO sizes. > + > + See Documentation/nvm-rrpc.txt for details. This file isn't part of this series, is it? > + > +endif # NVM > diff --git a/drivers/lightnvm/Makefile b/drivers/lightnvm/Makefile > new file mode 100644 > index 0000000..80d75a8 > --- /dev/null > +++ b/drivers/lightnvm/Makefile > @@ -0,0 +1,5 @@ > +# > +# Makefile for Open-Channel SSDs. > +# > + > +obj-$(CONFIG_NVM) += rrpc.o I suppose you meant to use obj-$(CONFIG_NVM_RRPC) += rrpc.o because otherwise setting NVM_RRPC has no effect. > --- /dev/null > +++ b/drivers/lightnvm/rrpc.c > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License version > + * 2 as published by the Free Software Foundation. > + * > + * This program is distributed in the hope that it will be useful, but > + * WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * General Public License for more details. This states the license is GPL v2. > +MODULE_LICENSE("GPL"); And (according to include/linux/module.h) the license ident "GPL" states the license is GPL v2 or later. So either the comment at the top of this file or the license ident needs to change. Thanks, Paul Bolle
next prev parent reply other threads:[~2015-04-16 9:12 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-15 12:34 [PATCH 0/5 v2] Support for Open-Channel SSDs Matias Bjørling 2015-04-15 12:34 ` Matias Bjørling 2015-04-15 12:34 ` [PATCH 1/5 v2] blk-mq: Add prep/unprep support Matias Bjørling 2015-04-15 12:34 ` Matias Bjørling 2015-04-17 6:34 ` Christoph Hellwig 2015-04-17 6:34 ` Christoph Hellwig 2015-04-17 8:15 ` Matias Bjørling 2015-04-17 8:15 ` Matias Bjørling 2015-04-17 17:46 ` Christoph Hellwig 2015-04-17 17:46 ` Christoph Hellwig 2015-04-18 6:45 ` Matias Bjorling 2015-04-18 6:45 ` Matias Bjorling 2015-04-18 20:16 ` Christoph Hellwig 2015-04-18 20:16 ` Christoph Hellwig 2015-04-19 18:12 ` Matias Bjorling 2015-04-19 18:12 ` Matias Bjorling 2015-04-15 12:34 ` [PATCH 2/5 v2] blk-mq: Support for Open-Channel SSDs Matias Bjørling 2015-04-15 12:34 ` Matias Bjørling 2015-04-15 12:34 ` Matias Bjørling 2015-04-16 9:10 ` Paul Bolle 2015-04-16 9:10 ` Paul Bolle 2015-04-16 10:23 ` Matias Bjørling 2015-04-16 10:23 ` Matias Bjørling 2015-04-16 10:23 ` Matias Bjørling 2015-04-16 11:34 ` Paul Bolle 2015-04-16 11:34 ` Paul Bolle 2015-04-16 11:34 ` Paul Bolle 2015-04-16 13:29 ` Matias Bjørling 2015-04-16 13:29 ` Matias Bjørling 2015-04-16 13:29 ` Matias Bjørling 2015-04-15 12:34 ` [PATCH 3/5 v2] lightnvm: RRPC target Matias Bjørling 2015-04-15 12:34 ` Matias Bjørling 2015-04-15 12:34 ` Matias Bjørling 2015-04-16 9:12 ` Paul Bolle [this message] 2015-04-16 9:12 ` Paul Bolle 2015-04-15 12:34 ` [PATCH 4/5 v2] null_blk: LightNVM support Matias Bjørling 2015-04-15 12:34 ` Matias Bjørling 2015-04-15 12:34 ` [PATCH 5/5 v2] nvme: " Matias Bjørling 2015-04-15 12:34 ` Matias Bjørling 2015-04-16 14:55 ` Keith Busch 2015-04-16 14:55 ` Keith Busch 2015-04-16 15:14 ` Javier González 2015-04-16 15:14 ` Javier González 2015-04-16 15:52 ` Keith Busch 2015-04-16 15:52 ` Keith Busch 2015-04-16 16:01 ` James R. Bergsten 2015-04-16 16:01 ` James R. Bergsten 2015-04-16 16:01 ` James R. Bergsten 2015-04-16 16:12 ` Keith Busch 2015-04-16 16:12 ` Keith Busch 2015-04-16 17:17 ` Matias Bjorling 2015-04-16 17:17 ` Matias Bjorling 2015-04-16 17:17 ` Matias Bjorling
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1429175559.16771.47.camel@x220 \ --to=pebolle@tiscali.nl \ --cc=axboe@fb.com \ --cc=hch@infradead.org \ --cc=javier@paletta.io \ --cc=keith.busch@intel.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=m@bjorling.me \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.