From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com
Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: [PATCH v3 00/10] KVM: MTRR fixes and some cleanups
Date: Wed, 13 May 2015 14:42:18 +0800 [thread overview]
Message-ID: <1431499348-25188-1-git-send-email-guangrong.xiao@linux.intel.com> (raw)
Changelog in v3:
thanks for Paolo's comment:
- do not apply for_each_rmap_spte to kvm_zap_rmapp and kvm_mmu_unlink_parents
- fix a cosmetic issue in slot_handle_level_range
- introduce PT_MAX_HUGEPAGE_LEVEL to clean up the code
- improve code Indentation
Changelog in v2:
- fix the bit description in changelog of the first patch, thanks
David Matlack for pointing it out
all follow changes are from Paolo's comment and really appreciate it:
- reorder the whole patchset to make it is more readable
- redesign the iterator APIs
- make TLB clean if @lock_flush_tlb is true in slot_handle_level()
- make MTRR update be generic
This are some MTRR bugs if legacy IOMMU device is used on Intel's CPU:
- In current code, whenever guest MTRR registers are changed
kvm_mmu_reset_context is called to switch to the new root shadow page
table, however, it's useless since:
1) the cache type is not cached into shadow page's attribute so that the
original root shadow page will be reused
2) the cache type is set on the last spte, that means we should sync the
last sptes when MTRR is changed
We can fix it by dropping all the spte in the gfn range which is
being updated by MTRR
- some bugs are in get_mtrr_type();
1: bit 1 of mtrr_state->enabled is corresponding bit 11 of IA32_MTRR_DEF_TYPE
MSR which completely control MTRR's enablement that means other bits are
ignored if it is cleared
2: the fixed MTRR ranges are controlled by bit 0 of mtrr_state->enabled (bit
10 of IA32_MTRR_DEF_TYPE)
3: if MTRR is disabled, UC is applied to all of physical memory rather than
mtrr_state->def_type
- we need not to reset mmu once cache policy is changed since shadow page table
does not virtualize any cache policy
Also, these are some cleanups to make current MMU code more cleaner and help
us fixing the bug more easier.
Xiao Guangrong (10):
KVM: MMU: fix decoding cache type from MTRR
KVM: MMU: introduce for_each_rmap_spte()
KVM: MMU: introduce PT_MAX_HUGEPAGE_LEVEL
KVM: MMU: introduce for_each_slot_rmap_range
KVM: MMU: introduce slot_handle_level_range() and its helpers
KVM: MMU: use slot_handle_level and its helper to clean up the code
KVM: MMU: introduce kvm_zap_rmapp
KVM: MMU: introduce kvm_zap_gfn_range
KVM: MMU: fix MTRR update
KVM: x86: do not reset mmu if CR0.CD and CR0.NW are changed
arch/x86/kvm/mmu.c | 409 +++++++++++++++++++++++++----------------------
arch/x86/kvm/mmu.h | 2 +
arch/x86/kvm/mmu_audit.c | 4 +-
arch/x86/kvm/x86.c | 62 ++++++-
4 files changed, 281 insertions(+), 196 deletions(-)
--
2.1.0
next reply other threads:[~2015-05-13 6:46 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-13 6:42 Xiao Guangrong [this message]
2015-05-13 6:42 ` [PATCH v3 01/10] KVM: MMU: fix decoding cache type from MTRR Xiao Guangrong
2015-05-13 8:09 ` Wanpeng Li
2015-07-12 17:33 ` Alex Williamson
2015-07-12 18:59 ` Xiao Guangrong
2015-07-13 7:32 ` Paolo Bonzini
2015-07-13 14:45 ` Xiao Guangrong
2015-07-13 15:13 ` Paolo Bonzini
2015-07-13 15:15 ` Xiao Guangrong
2015-07-14 21:12 ` MTRR setup in OVMF [was: PATCH v3 01/10 KVM: MMU: fix decoding cache type from MTRR] Laszlo Ersek
2015-07-14 21:15 ` Paolo Bonzini
2015-07-14 21:15 ` [edk2] " Paolo Bonzini
2015-07-14 21:29 ` Laszlo Ersek
2015-07-14 21:29 ` [edk2] " Laszlo Ersek
2015-07-14 22:37 ` Jordan Justen
2015-07-15 9:57 ` Laszlo Ersek
2015-07-15 9:57 ` [edk2] " Laszlo Ersek
2015-07-15 0:14 ` Fan, Jeff
2015-07-15 0:14 ` Fan, Jeff
2015-07-15 19:30 ` Xiao Guangrong
2015-07-15 19:41 ` Laszlo Ersek
2015-07-12 19:12 ` [PATCH v3 01/10] KVM: MMU: fix decoding cache type from MTRR Bandan Das
2015-05-13 6:42 ` [PATCH v3 02/10] KVM: MMU: introduce for_each_rmap_spte() Xiao Guangrong
2015-05-13 6:42 ` [PATCH v3 03/10] KVM: MMU: introduce PT_MAX_HUGEPAGE_LEVEL Xiao Guangrong
2015-05-13 6:42 ` [PATCH v3 04/10] KVM: MMU: introduce for_each_slot_rmap_range Xiao Guangrong
2015-05-13 6:42 ` [PATCH v3 05/10] KVM: MMU: introduce slot_handle_level_range() and its helpers Xiao Guangrong
2015-05-13 6:42 ` [PATCH v3 06/10] KVM: MMU: use slot_handle_level and its helper to clean up the code Xiao Guangrong
2015-05-13 6:42 ` [PATCH v3 07/10] KVM: MMU: introduce kvm_zap_rmapp Xiao Guangrong
2015-05-13 6:42 ` [PATCH v3 08/10] KVM: MMU: introduce kvm_zap_gfn_range Xiao Guangrong
2015-05-13 6:42 ` [PATCH v3 09/10] KVM: MMU: fix MTRR update Xiao Guangrong
2015-05-13 8:43 ` Wanpeng Li
2015-05-13 14:10 ` Paolo Bonzini
2015-05-14 0:16 ` Wanpeng Li
2015-05-14 8:43 ` Paolo Bonzini
2015-05-13 6:42 ` [PATCH v3 10/10] KVM: x86: do not reset mmu if CR0.CD and CR0.NW are changed Xiao Guangrong
2015-05-13 14:14 ` [PATCH v3 00/10] KVM: MTRR fixes and some cleanups Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1431499348-25188-1-git-send-email-guangrong.xiao@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.