All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Wanpeng Li <wanpeng.li@linux.intel.com>,
	Xiao Guangrong <guangrong.xiao@linux.intel.com>
Cc: gleb@kernel.org, mtosatti@redhat.com, kvm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 09/10] KVM: MMU: fix MTRR update
Date: Wed, 13 May 2015 16:10:08 +0200	[thread overview]
Message-ID: <55535B40.2060504@redhat.com> (raw)
In-Reply-To: <20150513084341.GA4910@kernel>



On 13/05/2015 10:43, Wanpeng Li wrote:
> kvm_mmu_reset_context
>   kvm_mmu_unload
>     mmu_free_roots
> 
> The original root shadow page will be freed in mmu_free_roots, where I
> miss?
> 
> Another question maybe not related to this patch:
> 
> If kvm_mmu_reset_context is just called to destroy the original root 
> shadow page and all the sptes will remain valid? 

SPTEs are kept around and cached.  The "role" field is used as the hash
key; if the role doesn't change, SPTEs are reused, so you have to zap
the SPTEs explicitly.

Paolo

  reply	other threads:[~2015-05-13 14:10 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-13  6:42 [PATCH v3 00/10] KVM: MTRR fixes and some cleanups Xiao Guangrong
2015-05-13  6:42 ` [PATCH v3 01/10] KVM: MMU: fix decoding cache type from MTRR Xiao Guangrong
2015-05-13  8:09   ` Wanpeng Li
2015-07-12 17:33   ` Alex Williamson
2015-07-12 18:59     ` Xiao Guangrong
2015-07-13  7:32       ` Paolo Bonzini
2015-07-13 14:45         ` Xiao Guangrong
2015-07-13 15:13           ` Paolo Bonzini
2015-07-13 15:15             ` Xiao Guangrong
2015-07-14 21:12               ` MTRR setup in OVMF [was: PATCH v3 01/10 KVM: MMU: fix decoding cache type from MTRR] Laszlo Ersek
2015-07-14 21:15                 ` Paolo Bonzini
2015-07-14 21:15                   ` [edk2] " Paolo Bonzini
2015-07-14 21:29                   ` Laszlo Ersek
2015-07-14 21:29                     ` [edk2] " Laszlo Ersek
2015-07-14 22:37                     ` Jordan Justen
2015-07-15  9:57                       ` Laszlo Ersek
2015-07-15  9:57                         ` [edk2] " Laszlo Ersek
2015-07-15  0:14                   ` Fan, Jeff
2015-07-15  0:14                     ` Fan, Jeff
2015-07-15 19:30                   ` Xiao Guangrong
2015-07-15 19:41                     ` Laszlo Ersek
2015-07-12 19:12     ` [PATCH v3 01/10] KVM: MMU: fix decoding cache type from MTRR Bandan Das
2015-05-13  6:42 ` [PATCH v3 02/10] KVM: MMU: introduce for_each_rmap_spte() Xiao Guangrong
2015-05-13  6:42 ` [PATCH v3 03/10] KVM: MMU: introduce PT_MAX_HUGEPAGE_LEVEL Xiao Guangrong
2015-05-13  6:42 ` [PATCH v3 04/10] KVM: MMU: introduce for_each_slot_rmap_range Xiao Guangrong
2015-05-13  6:42 ` [PATCH v3 05/10] KVM: MMU: introduce slot_handle_level_range() and its helpers Xiao Guangrong
2015-05-13  6:42 ` [PATCH v3 06/10] KVM: MMU: use slot_handle_level and its helper to clean up the code Xiao Guangrong
2015-05-13  6:42 ` [PATCH v3 07/10] KVM: MMU: introduce kvm_zap_rmapp Xiao Guangrong
2015-05-13  6:42 ` [PATCH v3 08/10] KVM: MMU: introduce kvm_zap_gfn_range Xiao Guangrong
2015-05-13  6:42 ` [PATCH v3 09/10] KVM: MMU: fix MTRR update Xiao Guangrong
2015-05-13  8:43   ` Wanpeng Li
2015-05-13 14:10     ` Paolo Bonzini [this message]
2015-05-14  0:16       ` Wanpeng Li
2015-05-14  8:43         ` Paolo Bonzini
2015-05-13  6:42 ` [PATCH v3 10/10] KVM: x86: do not reset mmu if CR0.CD and CR0.NW are changed Xiao Guangrong
2015-05-13 14:14 ` [PATCH v3 00/10] KVM: MTRR fixes and some cleanups Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55535B40.2060504@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=gleb@kernel.org \
    --cc=guangrong.xiao@linux.intel.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=wanpeng.li@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.