From: Toshi Kani <toshi.kani@hp.com>
To: Borislav Petkov <bp@alien8.de>
Cc: jgross@suse.com, Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@amacapital.net>,
arnd@arndb.de, Elliott@hp.com, hch@lst.de, hmh@hmh.eng.br,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
konrad.wilk@oracle.com, linux-mm <linux-mm@kvack.org>,
linux-nvdimm@lists.01.org, "Luis R. Rodriguez" <mcgrof@suse.com>,
stefan.bader@canonical.com, Thomas Gleixner <tglx@linutronix.de>,
x86-ml <x86@kernel.org>,
yigal@plexistor.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] x86/pat: Merge pat_init_cache_modes() into its caller
Date: Mon, 01 Jun 2015 12:15:54 -0600 [thread overview]
Message-ID: <1433182554.23540.112.camel@misato.fc.hp.com> (raw)
In-Reply-To: <20150531102338.GB20440@pd.tnic>
On Sun, 2015-05-31 at 12:23 +0200, Borislav Petkov wrote:
> On Sun, May 31, 2015 at 11:48:04AM +0200, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@suse.de>
> >
> > This way we can pass pat MSR value directly.
>
> This breaks xen as that function is used there, doh. :-\
>
> Jürgen,
>
> can you check the enlighten.c changes below please?
>
> I'm reading xen's PAT config from MSR_IA32_CR_PAT and handing it down to
> pat_init_cache_modes(). That shouldn't change current behavior AFAICT
> because pat_init_cache_modes() did it itself before.
>
> Right?
>
> Thanks.
>
> ---
> Author: Borislav Petkov <bp@suse.de>
> Date: Sat May 30 13:09:55 2015 +0200
>
> x86/pat: Emulate PAT when it is disabled
>
> In the case when PAT is disabled on the command line with "nopat" or
> when virtualization doesn't support PAT (correctly) - see
>
> 9d34cfdf4796 ("x86: Don't rely on VMWare emulating PAT MSR correctly").
>
> we emulate it using the PWT and PCD cache attribute bits. Get rid of
> boot_pat_state while at it.
>
> Based on a conglomerate patch from Toshi Kani.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Toshi Kani <toshi.kani@hp.com>
Thanks,
-Toshi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hp.com>
To: Borislav Petkov <bp@alien8.de>
Cc: jgross@suse.com, Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@amacapital.net>,
arnd@arndb.de, Elliott@hp.com, hch@lst.de, hmh@hmh.eng.br,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
konrad.wilk@oracle.com, linux-mm <linux-mm@kvack.org>,
linux-nvdimm@ml01.01.org, "Luis R. Rodriguez" <mcgrof@suse.com>,
stefan.bader@canonical.com, Thomas Gleixner <tglx@linutronix.de>,
x86-ml <x86@kernel.org>,
yigal@plexistor.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] x86/pat: Merge pat_init_cache_modes() into its caller
Date: Mon, 01 Jun 2015 12:15:54 -0600 [thread overview]
Message-ID: <1433182554.23540.112.camel@misato.fc.hp.com> (raw)
In-Reply-To: <20150531102338.GB20440@pd.tnic>
On Sun, 2015-05-31 at 12:23 +0200, Borislav Petkov wrote:
> On Sun, May 31, 2015 at 11:48:04AM +0200, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@suse.de>
> >
> > This way we can pass pat MSR value directly.
>
> This breaks xen as that function is used there, doh. :-\
>
> Jürgen,
>
> can you check the enlighten.c changes below please?
>
> I'm reading xen's PAT config from MSR_IA32_CR_PAT and handing it down to
> pat_init_cache_modes(). That shouldn't change current behavior AFAICT
> because pat_init_cache_modes() did it itself before.
>
> Right?
>
> Thanks.
>
> ---
> Author: Borislav Petkov <bp@suse.de>
> Date: Sat May 30 13:09:55 2015 +0200
>
> x86/pat: Emulate PAT when it is disabled
>
> In the case when PAT is disabled on the command line with "nopat" or
> when virtualization doesn't support PAT (correctly) - see
>
> 9d34cfdf4796 ("x86: Don't rely on VMWare emulating PAT MSR correctly").
>
> we emulate it using the PWT and PCD cache attribute bits. Get rid of
> boot_pat_state while at it.
>
> Based on a conglomerate patch from Toshi Kani.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Toshi Kani <toshi.kani@hp.com>
Thanks,
-Toshi
WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hp.com>
To: Borislav Petkov <bp@alien8.de>
Cc: jgross@suse.com, Andrew Morton <akpm@linux-foundation.org>,
Andy Lutomirski <luto@amacapital.net>,
arnd@arndb.de, Elliott@hp.com, hch@lst.de, hmh@hmh.eng.br,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
konrad.wilk@oracle.com, linux-mm <linux-mm@kvack.org>,
linux-nvdimm@lists.01.org, "Luis R. Rodriguez" <mcgrof@suse.com>,
stefan.bader@canonical.com, Thomas Gleixner <tglx@linutronix.de>,
x86-ml <x86@kernel.org>,
yigal@plexistor.com, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] x86/pat: Merge pat_init_cache_modes() into its caller
Date: Mon, 01 Jun 2015 12:15:54 -0600 [thread overview]
Message-ID: <1433182554.23540.112.camel@misato.fc.hp.com> (raw)
In-Reply-To: <20150531102338.GB20440@pd.tnic>
On Sun, 2015-05-31 at 12:23 +0200, Borislav Petkov wrote:
> On Sun, May 31, 2015 at 11:48:04AM +0200, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@suse.de>
> >
> > This way we can pass pat MSR value directly.
>
> This breaks xen as that function is used there, doh. :-\
>
> JA 1/4 rgen,
>
> can you check the enlighten.c changes below please?
>
> I'm reading xen's PAT config from MSR_IA32_CR_PAT and handing it down to
> pat_init_cache_modes(). That shouldn't change current behavior AFAICT
> because pat_init_cache_modes() did it itself before.
>
> Right?
>
> Thanks.
>
> ---
> Author: Borislav Petkov <bp@suse.de>
> Date: Sat May 30 13:09:55 2015 +0200
>
> x86/pat: Emulate PAT when it is disabled
>
> In the case when PAT is disabled on the command line with "nopat" or
> when virtualization doesn't support PAT (correctly) - see
>
> 9d34cfdf4796 ("x86: Don't rely on VMWare emulating PAT MSR correctly").
>
> we emulate it using the PWT and PCD cache attribute bits. Get rid of
> boot_pat_state while at it.
>
> Based on a conglomerate patch from Toshi Kani.
>
> Signed-off-by: Borislav Petkov <bp@suse.de>
Reviewed-by: Toshi Kani <toshi.kani@hp.com>
Thanks,
-Toshi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-06-01 18:15 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-29 22:58 [PATCH v11 0/12] Support Write-Through mapping on x86 Toshi Kani
2015-05-29 22:58 ` Toshi Kani
2015-05-29 22:58 ` [PATCH v11 1/12] x86, mm, pat: Cleanup init flags in pat_init() Toshi Kani
2015-05-29 22:58 ` Toshi Kani
2015-05-29 22:59 ` [PATCH v11 2/12] x86, mm, pat: Refactor !pat_enabled handling Toshi Kani
2015-05-29 22:59 ` Toshi Kani
2015-05-31 9:46 ` Borislav Petkov
2015-05-31 9:46 ` Borislav Petkov
2015-05-31 9:48 ` [PATCH 1/4] x86/pat: Untangle pat_init() Borislav Petkov
2015-05-31 9:48 ` Borislav Petkov
2015-05-31 9:48 ` [PATCH 2/4] x86/pat: Merge pat_init_cache_modes() into its caller Borislav Petkov
2015-05-31 9:48 ` Borislav Petkov
2015-05-31 10:15 ` Juergen Gross
2015-05-31 10:15 ` Juergen Gross
2015-05-31 10:24 ` Borislav Petkov
2015-05-31 10:24 ` Borislav Petkov
2015-05-31 10:23 ` Borislav Petkov
2015-05-31 10:23 ` Borislav Petkov
2015-05-31 10:23 ` Borislav Petkov
2015-05-31 11:02 ` Juergen Gross
2015-05-31 11:02 ` Juergen Gross
2015-05-31 11:02 ` Juergen Gross
2015-06-01 18:15 ` Toshi Kani [this message]
2015-06-01 18:15 ` Toshi Kani
2015-06-01 18:15 ` Toshi Kani
2015-05-31 9:48 ` [PATCH 3/4] x86/pat: Emulate PAT when it is disabled Borislav Petkov
2015-05-31 9:48 ` Borislav Petkov
2015-05-31 9:48 ` [PATCH 4/4] x86/pat: Remove pat_enabled() checks Borislav Petkov
2015-05-31 9:48 ` Borislav Petkov
2015-06-01 18:26 ` Toshi Kani
2015-06-01 18:26 ` Toshi Kani
2015-06-01 18:51 ` Borislav Petkov
2015-06-01 18:51 ` Borislav Petkov
2015-06-01 16:17 ` [PATCH 1/4] x86/pat: Untangle pat_init() Toshi Kani
2015-06-01 16:17 ` Toshi Kani
2015-06-01 15:50 ` [PATCH v11 2/12] x86, mm, pat: Refactor !pat_enabled handling Toshi Kani
2015-06-01 15:50 ` Toshi Kani
2015-05-29 22:59 ` [PATCH v11 3/12] x86, mm, pat: Set WT to PA7 slot of PAT MSR Toshi Kani
2015-05-29 22:59 ` Toshi Kani
2015-05-29 22:59 ` [PATCH v11 4/12] x86, mm, pat: Change reserve_memtype() for WT Toshi Kani
2015-05-29 22:59 ` Toshi Kani
2015-05-29 22:59 ` [PATCH v11 5/12] x86, asm: Change is_new_memtype_allowed() " Toshi Kani
2015-05-29 22:59 ` Toshi Kani
2015-05-29 22:59 ` [PATCH v11 6/12] x86, mm, asm-gen: Add ioremap_wt() " Toshi Kani
2015-05-29 22:59 ` Toshi Kani
2015-05-30 9:18 ` Geert Uytterhoeven
2015-05-30 9:18 ` Geert Uytterhoeven
2015-05-31 0:58 ` Toshi Kani
2015-05-31 0:58 ` Toshi Kani
2015-05-29 22:59 ` [PATCH v11 7/12] arch/*/asm/io.h: Add ioremap_wt() to all architectures Toshi Kani
2015-05-29 22:59 ` Toshi Kani
2015-05-29 22:59 ` [PATCH v11 8/12] video/fbdev, asm/io.h: Remove ioremap_writethrough() Toshi Kani
2015-05-29 22:59 ` Toshi Kani
2015-05-29 22:59 ` [PATCH v11 9/12] x86, mm, pat: Add pgprot_writethrough() for WT Toshi Kani
2015-05-29 22:59 ` Toshi Kani
2015-05-29 22:59 ` [PATCH v11 10/12] x86, mm, asm: Add WT support to set_page_memtype() Toshi Kani
2015-05-29 22:59 ` Toshi Kani
2015-05-29 22:59 ` [PATCH v11 11/12] x86, mm: Add set_memory_wt() for WT Toshi Kani
2015-05-29 22:59 ` Toshi Kani
2015-05-29 22:59 ` [PATCH v11 12/12] drivers/block/pmem: Map NVDIMM with ioremap_wt() Toshi Kani
2015-05-29 22:59 ` Toshi Kani
2015-05-30 1:18 ` Dan Williams
2015-05-30 1:18 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1433182554.23540.112.camel@misato.fc.hp.com \
--to=toshi.kani@hp.com \
--cc=Elliott@hp.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=hch@lst.de \
--cc=hmh@hmh.eng.br \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=luto@amacapital.net \
--cc=mcgrof@suse.com \
--cc=mingo@redhat.com \
--cc=stefan.bader@canonical.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yigal@plexistor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.