All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
	Daniel Vetter <daniel.vetter@intel.com>
Subject: [PATCH 2/9] drm/i915: Filter out no-op frontbuffer tracking flushes
Date: Thu, 18 Jun 2015 10:30:21 +0200	[thread overview]
Message-ID: <1434616228-28358-2-git-send-email-daniel.vetter@ffwll.ch> (raw)
In-Reply-To: <1434616228-28358-1-git-send-email-daniel.vetter@ffwll.ch>

Paulo noticed that the fbc frontbuffer tracking flush callback
occasionally gets a call without any bit set. This can happen when we
have to filter flush calls due to e.g. gpu rendering. Filter these
out.

Reported-by: Paulo Zanoni <przanoni@gmail.com>
Cc: Paulo Zanoni <przanoni@gmail.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/i915/intel_frontbuffer.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/intel_frontbuffer.c b/drivers/gpu/drm/i915/intel_frontbuffer.c
index 2a1611a7ce1d..899b6112bbe0 100644
--- a/drivers/gpu/drm/i915/intel_frontbuffer.c
+++ b/drivers/gpu/drm/i915/intel_frontbuffer.c
@@ -179,6 +179,9 @@ void intel_frontbuffer_flush(struct drm_device *dev,
 	frontbuffer_bits &= ~dev_priv->fb_tracking.busy_bits;
 	mutex_unlock(&dev_priv->fb_tracking.lock);
 
+	if (!frontbuffer_bits)
+		return;
+
 	intel_mark_fb_busy(dev, frontbuffer_bits, NULL);
 
 	intel_edp_drrs_flush(dev, frontbuffer_bits);
-- 
2.1.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-06-18  8:30 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-18  8:30 [PATCH 1/9] drm/i915: Clear fb_tracking.busy_bits also for synchronous flips Daniel Vetter
2015-06-18  8:30 ` Daniel Vetter [this message]
2015-06-23 19:02   ` [PATCH 2/9] drm/i915: Filter out no-op frontbuffer tracking flushes Paulo Zanoni
2015-06-18  8:30 ` [PATCH 3/9] drm/i915: debugfs for frontbuffer tracking Daniel Vetter
2015-06-23 19:06   ` Paulo Zanoni
2015-06-18  8:30 ` [PATCH 4/9] drm/i915: Nuke lvds downclock support Daniel Vetter
2015-06-18  9:00   ` Chris Wilson
2015-06-18  9:23     ` Daniel Vetter
2015-06-18  9:30       ` Chris Wilson
2015-06-23 21:18         ` Daniel Vetter
2015-06-24  7:42           ` Chris Wilson
2015-06-18  8:30 ` [PATCH 5/9] drm/i915: s/update/compute/ for gmch dpll register functions Daniel Vetter
2015-06-23 20:26   ` Paulo Zanoni
2015-06-23 21:20     ` Daniel Vetter
2015-06-18  8:30 ` [PATCH 6/9] drm/i915/drrs: Restrict buffer tracking to the DRRS pipe Daniel Vetter
2015-06-23 20:32   ` Paulo Zanoni
2015-06-18  8:30 ` [PATCH 7/9] drm/i915/psr: Restrict buffer tracking to the PSR pipe Daniel Vetter
2015-06-23 19:57   ` Paulo Zanoni
2015-06-23 21:00     ` Daniel Vetter
2015-06-18  8:30 ` [PATCH 8/9] drm/i915/psr: Restrict single-shot updates " Daniel Vetter
2015-06-18  8:53   ` Chris Wilson
2015-06-23 20:12   ` Paulo Zanoni
2015-06-18  8:30 ` [PATCH 9/9] drm/i915: Use to_i915 in intel_frontbuffer.c Daniel Vetter
2015-06-23 20:18   ` Paulo Zanoni
2015-06-18  8:32 ` [PATCH 1/9] drm/i915: Clear fb_tracking.busy_bits also for synchronous flips Ville Syrjälä
2015-06-18  8:43   ` Chris Wilson
2015-06-18  9:23   ` [PATCH] " Daniel Vetter
2015-06-23 18:59     ` Paulo Zanoni
2015-06-23 20:52       ` Daniel Vetter
2015-06-23 15:07 ` [PATCH igt] tests/kms_frontbuffer_tracking: add modesetfrombusy test Paulo Zanoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1434616228-28358-2-git-send-email-daniel.vetter@ffwll.ch \
    --to=daniel.vetter@ffwll.ch \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.