Re: [PATCH 6/9] drm/i915/drrs: Restrict buffer tracking to the DRRS pipe

From: Paulo Zanoni <przanoni@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
	Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 6/9] drm/i915/drrs: Restrict buffer tracking to the DRRS pipe
Date: Tue, 23 Jun 2015 17:32:57 -0300	[thread overview]
Message-ID: <CA+gsUGQbJtyjYGv1e2gEPeNH-thaiXGkqoi-3p9Q81BKxWO1Dw@mail.gmail.com> (raw)
In-Reply-To: <1434616228-28358-6-git-send-email-daniel.vetter@ffwll.ch>

2015-06-18 5:30 GMT-03:00 Daniel Vetter <daniel.vetter@ffwll.ch>:
> The current code tracks business across all pipes, but we're only
> really interested in the one pipe DRRS is enabled on. Fairly tiny
> optimization, but something I noticed while reading the code. But it
> might matter a bit when e.g. showing a video or something only on the
> external screen, while the panel is kept static.
>
> Also regroup the code slightly: First compute new bitmasks, then take
> appropriate actions.
>
> Cc: Ramalingam C <ramalingam.c@intel.com>
> Cc: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

PS: with this, everything except P4 has a R-B tag (but P1 has a change
request). I'll let you and Chris decide what to do on P4.

> ---
>  drivers/gpu/drm/i915/intel_dp.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index f52eef138247..3e8c88d119bb 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -5485,16 +5485,15 @@ void intel_edp_drrs_invalidate(struct drm_device *dev,
>         crtc = dp_to_dig_port(dev_priv->drrs.dp)->base.base.crtc;
>         pipe = to_intel_crtc(crtc)->pipe;
>
> +       frontbuffer_bits &= INTEL_FRONTBUFFER_ALL_MASK(pipe);
> +       dev_priv->drrs.busy_frontbuffer_bits |= frontbuffer_bits;
> +
>         /* invalidate means busy screen hence upclock */
> -       if (dev_priv->drrs.refresh_rate_type == DRRS_LOW_RR) {
> +       if (frontbuffer_bits && dev_priv->drrs.refresh_rate_type == DRRS_LOW_RR)
>                 intel_dp_set_drrs_state(dev_priv->dev,
>                                 dev_priv->drrs.dp->attached_connector->panel.
>                                 fixed_mode->vrefresh);
> -       }
> -
> -       frontbuffer_bits &= INTEL_FRONTBUFFER_ALL_MASK(pipe);
>
> -       dev_priv->drrs.busy_frontbuffer_bits |= frontbuffer_bits;
>         mutex_unlock(&dev_priv->drrs.mutex);
>  }
>
> @@ -5530,10 +5529,12 @@ void intel_edp_drrs_flush(struct drm_device *dev,
>
>         crtc = dp_to_dig_port(dev_priv->drrs.dp)->base.base.crtc;
>         pipe = to_intel_crtc(crtc)->pipe;
> +
> +       frontbuffer_bits &= INTEL_FRONTBUFFER_ALL_MASK(pipe);
>         dev_priv->drrs.busy_frontbuffer_bits &= ~frontbuffer_bits;
>
>         /* flush means busy screen hence upclock */
> -       if (dev_priv->drrs.refresh_rate_type == DRRS_LOW_RR)
> +       if (frontbuffer_bits && dev_priv->drrs.refresh_rate_type == DRRS_LOW_RR)
>                 intel_dp_set_drrs_state(dev_priv->dev,
>                                 dev_priv->drrs.dp->attached_connector->panel.
>                                 fixed_mode->vrefresh);
> --
> 2.1.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Paulo Zanoni
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx