From: Toshi Kani <toshi.kani@hp.com> To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org Cc: travis@sgi.com, roland@purestorage.com, dan.j.williams@intel.com, x86@kernel.org, linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/3] mm, x86: Fix ioremap RAM check interfaces Date: Fri, 19 Jun 2015 15:44:02 -0600 [thread overview] Message-ID: <1434750245-6304-1-git-send-email-toshi.kani@hp.com> (raw) ioremap() checks if a target range is RAM and fails the request if true. There are multiple issues in the iormap RAM check interfaces. 1. region_is_ram() does not work at all. 2. The RAM checks, region_is_ram() and __ioremap_caller() via walk_system_ram_range(), are redundant. 3. walk_system_ram_range() requires the RAM ranges page-aligned in the resource table. This restriction has allowed multiple ioremap calls to setup_data, which is not page-aligned. This patchset solves issue 1 and 2. Issue 3 is not addressed in this patchset, but is taken into the account that ioremap continues to allow such callers until it is addressed. --- Toshi Kani (3): 1/3 mm, x86: Fix warning in ioremap RAM check 2/3 mm, x86: Remove region_is_ram() call from ioremap 3/3 mm: Fix bugs in region_is_ram() --- arch/x86/mm/ioremap.c | 23 ++++++----------------- kernel/resource.c | 6 +++--- 2 files changed, 9 insertions(+), 20 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
WARNING: multiple messages have this Message-ID (diff)
From: Toshi Kani <toshi.kani@hp.com> To: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org Cc: travis@sgi.com, roland@purestorage.com, dan.j.williams@intel.com, x86@kernel.org, linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org Subject: [PATCH 0/3] mm, x86: Fix ioremap RAM check interfaces Date: Fri, 19 Jun 2015 15:44:02 -0600 [thread overview] Message-ID: <1434750245-6304-1-git-send-email-toshi.kani@hp.com> (raw) ioremap() checks if a target range is RAM and fails the request if true. There are multiple issues in the iormap RAM check interfaces. 1. region_is_ram() does not work at all. 2. The RAM checks, region_is_ram() and __ioremap_caller() via walk_system_ram_range(), are redundant. 3. walk_system_ram_range() requires the RAM ranges page-aligned in the resource table. This restriction has allowed multiple ioremap calls to setup_data, which is not page-aligned. This patchset solves issue 1 and 2. Issue 3 is not addressed in this patchset, but is taken into the account that ioremap continues to allow such callers until it is addressed. --- Toshi Kani (3): 1/3 mm, x86: Fix warning in ioremap RAM check 2/3 mm, x86: Remove region_is_ram() call from ioremap 3/3 mm: Fix bugs in region_is_ram() --- arch/x86/mm/ioremap.c | 23 ++++++----------------- kernel/resource.c | 6 +++--- 2 files changed, 9 insertions(+), 20 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in Please read the FAQ at http://www.tux.org/lkml/
next reply other threads:[~2015-06-19 21:44 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-19 21:44 Toshi Kani [this message] 2015-06-19 21:44 ` [PATCH 0/3] mm, x86: Fix ioremap RAM check interfaces Toshi Kani 2015-06-19 21:44 ` [PATCH 1/3] mm, x86: Fix warning in ioremap RAM check Toshi Kani 2015-06-19 21:44 ` Toshi Kani 2015-06-19 21:44 ` [PATCH 2/3] mm, x86: Remove region_is_ram() call from ioremap Toshi Kani 2015-06-19 21:44 ` Toshi Kani 2015-06-22 16:21 ` Mike Travis 2015-06-22 16:21 ` Mike Travis 2015-06-22 17:23 ` Toshi Kani 2015-06-22 17:23 ` Toshi Kani 2015-06-22 18:22 ` Mike Travis 2015-06-22 18:22 ` Mike Travis 2015-06-22 19:06 ` Toshi Kani 2015-06-22 19:06 ` Toshi Kani 2015-06-23 9:01 ` Ingo Molnar 2015-06-23 9:01 ` Ingo Molnar 2015-06-23 15:19 ` Toshi Kani 2015-06-23 15:19 ` Toshi Kani 2015-06-23 18:57 ` Mike Travis 2015-06-23 18:57 ` Mike Travis 2015-06-19 21:44 ` [PATCH 3/3] mm: Fix bugs in region_is_ram() Toshi Kani 2015-06-19 21:44 ` Toshi Kani
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1434750245-6304-1-git-send-email-toshi.kani@hp.com \ --to=toshi.kani@hp.com \ --cc=akpm@linux-foundation.org \ --cc=dan.j.williams@intel.com \ --cc=hpa@zytor.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-nvdimm@lists.01.org \ --cc=mingo@redhat.com \ --cc=roland@purestorage.com \ --cc=tglx@linutronix.de \ --cc=travis@sgi.com \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.