All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [PATCH 3/7] drm/i915: Don't return error on sink crc stop.
Date: Thu, 23 Jul 2015 16:35:46 -0700	[thread overview]
Message-ID: <1437694550-5667-2-git-send-email-rodrigo.vivi@intel.com> (raw)
In-Reply-To: <1437694550-5667-1-git-send-email-rodrigo.vivi@intel.com>

If we got to the point where we are trying to stop sink CRC
the main output of this function was already gotten properly,
so don't return the error and let userspace use the crc data.

Let's replace the errnos returns with some log messages.

Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/intel_dp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 70a4a37..44f8a32 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4021,12 +4021,12 @@ int intel_dp_sink_crc(struct intel_dp *intel_dp, u8 *crc)
 
 stop:
 	if (drm_dp_dpcd_readb(&intel_dp->aux, DP_TEST_SINK, &buf) < 0) {
-		ret = -EIO;
+		DRM_DEBUG_KMS("Sink CRC couldn't be stopped properly\n");
 		goto out;
 	}
 	if (drm_dp_dpcd_writeb(&intel_dp->aux, DP_TEST_SINK,
 			       buf & ~DP_TEST_SINK_START) < 0) {
-		ret = -EIO;
+		DRM_DEBUG_KMS("Sink CRC couldn't be stopped properly\n");
 		goto out;
 	}
 out:
-- 
2.1.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-07-23 23:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 23:35 [PATCH 2/7] drm/i915: Try to stop sink crc calculation on error Rodrigo Vivi
2015-07-23 23:35 ` Rodrigo Vivi [this message]
2015-07-24 18:22   ` [PATCH 3/7] drm/i915: Don't return error on sink crc stop Rafael Antognolli
2015-07-24 18:33     ` Rodrigo Vivi
2015-07-23 23:35 ` [PATCH 4/7] drm/i915: Split sink_crc function in start, stop and read Rodrigo Vivi
2015-07-28 20:10   ` Rafael Antognolli
2015-07-29  8:24     ` Daniel Vetter
2015-07-30 23:26       ` [PATCH] " Rodrigo Vivi
2015-08-05  8:07         ` Daniel Vetter
2015-08-05 20:30           ` Vivi, Rodrigo
2015-08-06 12:20             ` Daniel Vetter
2015-08-06 23:56               ` Rodrigo Vivi
2015-07-23 23:35 ` [PATCH 5/7] drm/i915: Force sink crc stop before start Rodrigo Vivi
2015-07-28 20:14   ` Rafael Antognolli
2015-07-23 23:35 ` [PATCH 6/7] drm/i915: Save latest known sink CRC to compensate delayed counter reset Rodrigo Vivi
2015-07-28 20:18   ` Rafael Antognolli
2015-07-23 23:35 ` [PATCH 7/7] drm/i915: Dont -ETIMEDOUT on identical new and previous (count, crc) Rodrigo Vivi
2015-07-28 20:25   ` Rafael Antognolli
2015-07-28 22:05     ` Vivi, Rodrigo
2015-07-29  8:26       ` Daniel Vetter
2015-07-29 16:05         ` Rafael Antognolli
2015-07-24 18:19 ` [PATCH 2/7] drm/i915: Try to stop sink crc calculation on error Rafael Antognolli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437694550-5667-2-git-send-email-rodrigo.vivi@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.