From: Andre Przywara <andre.przywara@arm.com> To: will.deacon@arm.com, kvm@vger.kernel.org Cc: marc.zyngier@arm.com, kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org Subject: [PATCH 12/14] powerpc: use read_file() in kernel and initrd loading Date: Thu, 30 Jul 2015 11:52:29 +0100 [thread overview] Message-ID: <1438253551-2378-13-git-send-email-andre.przywara@arm.com> (raw) In-Reply-To: <1438253551-2378-1-git-send-email-andre.przywara@arm.com> Replace the unsafe read-loops in the powerpc kernel image loading function with our new and safe read_file() wrapper. This should fix random fails in kernel image loading, especially from pipes and sockets. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- powerpc/kvm.c | 36 ++++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/powerpc/kvm.c b/powerpc/kvm.c index 87d0f9e..9888bf1 100644 --- a/powerpc/kvm.c +++ b/powerpc/kvm.c @@ -162,16 +162,19 @@ bool kvm__arch_load_kernel_image(struct kvm *kvm, int fd_kernel, int fd_initrd, { void *p; void *k_start; - void *i_start; - int nr; + ssize_t filesize; p = k_start = guest_flat_to_host(kvm, KERNEL_LOAD_ADDR); - while ((nr = read(fd_kernel, p, 65536)) > 0) - p += nr; - - pr_info("Loaded kernel to 0x%x (%ld bytes)", KERNEL_LOAD_ADDR, (long)(p-k_start)); + filesize = read_file(fd_kernel, p, INITRD_LOAD_ADDR - KERNEL_LOAD_ADDR); + if (filesize < 0) { + if (errno == ENOMEM) + die("Kernel overlaps initrd!"); + die_perror("kernel read"); + } + pr_info("Loaded kernel to 0x%x (%ld bytes)", KERNEL_LOAD_ADDR, + filesize); if (fd_initrd != -1) { if (lseek(fd_initrd, 0, SEEK_SET) < 0) die_perror("lseek"); @@ -180,19 +183,20 @@ bool kvm__arch_load_kernel_image(struct kvm *kvm, int fd_kernel, int fd_initrd, die("Kernel overlaps initrd!"); /* Round up kernel size to 8byte alignment, and load initrd right after. */ - i_start = p = guest_flat_to_host(kvm, INITRD_LOAD_ADDR); - - while (((nr = read(fd_initrd, p, 65536)) > 0) && - p < (kvm->ram_start + kvm->ram_size)) - p += nr; - - if (p >= (kvm->ram_start + kvm->ram_size)) - die("initrd too big to contain in guest RAM.\n"); + p = guest_flat_to_host(kvm, INITRD_LOAD_ADDR); + + filesize = read_file(fd_initrd, p, + (kvm->ram_start + kvm->ram_size) - p); + if (filesize < 0) { + if (errno == ENOMEM) + die("initrd too big to contain in guest RAM.\n"); + die_perror("initrd read"); + } pr_info("Loaded initrd to 0x%x (%ld bytes)", - INITRD_LOAD_ADDR, (long)(p-i_start)); + INITRD_LOAD_ADDR, filesize); kvm->arch.initrd_gra = INITRD_LOAD_ADDR; - kvm->arch.initrd_size = p-i_start; + kvm->arch.initrd_size = filesize; } else { kvm->arch.initrd_size = 0; } -- 2.3.5
WARNING: multiple messages have this Message-ID (diff)
From: Andre Przywara <andre.przywara@arm.com> To: will.deacon@arm.com, kvm@vger.kernel.org Cc: marc.zyngier@arm.com, kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org Subject: [PATCH 12/14] powerpc: use read_file() in kernel and initrd loading Date: Thu, 30 Jul 2015 10:52:29 +0000 [thread overview] Message-ID: <1438253551-2378-13-git-send-email-andre.przywara@arm.com> (raw) In-Reply-To: <1438253551-2378-1-git-send-email-andre.przywara@arm.com> Replace the unsafe read-loops in the powerpc kernel image loading function with our new and safe read_file() wrapper. This should fix random fails in kernel image loading, especially from pipes and sockets. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- powerpc/kvm.c | 36 ++++++++++++++++++++---------------- 1 file changed, 20 insertions(+), 16 deletions(-) diff --git a/powerpc/kvm.c b/powerpc/kvm.c index 87d0f9e..9888bf1 100644 --- a/powerpc/kvm.c +++ b/powerpc/kvm.c @@ -162,16 +162,19 @@ bool kvm__arch_load_kernel_image(struct kvm *kvm, int fd_kernel, int fd_initrd, { void *p; void *k_start; - void *i_start; - int nr; + ssize_t filesize; p = k_start = guest_flat_to_host(kvm, KERNEL_LOAD_ADDR); - while ((nr = read(fd_kernel, p, 65536)) > 0) - p += nr; - - pr_info("Loaded kernel to 0x%x (%ld bytes)", KERNEL_LOAD_ADDR, (long)(p-k_start)); + filesize = read_file(fd_kernel, p, INITRD_LOAD_ADDR - KERNEL_LOAD_ADDR); + if (filesize < 0) { + if (errno = ENOMEM) + die("Kernel overlaps initrd!"); + die_perror("kernel read"); + } + pr_info("Loaded kernel to 0x%x (%ld bytes)", KERNEL_LOAD_ADDR, + filesize); if (fd_initrd != -1) { if (lseek(fd_initrd, 0, SEEK_SET) < 0) die_perror("lseek"); @@ -180,19 +183,20 @@ bool kvm__arch_load_kernel_image(struct kvm *kvm, int fd_kernel, int fd_initrd, die("Kernel overlaps initrd!"); /* Round up kernel size to 8byte alignment, and load initrd right after. */ - i_start = p = guest_flat_to_host(kvm, INITRD_LOAD_ADDR); - - while (((nr = read(fd_initrd, p, 65536)) > 0) && - p < (kvm->ram_start + kvm->ram_size)) - p += nr; - - if (p >= (kvm->ram_start + kvm->ram_size)) - die("initrd too big to contain in guest RAM.\n"); + p = guest_flat_to_host(kvm, INITRD_LOAD_ADDR); + + filesize = read_file(fd_initrd, p, + (kvm->ram_start + kvm->ram_size) - p); + if (filesize < 0) { + if (errno = ENOMEM) + die("initrd too big to contain in guest RAM.\n"); + die_perror("initrd read"); + } pr_info("Loaded initrd to 0x%x (%ld bytes)", - INITRD_LOAD_ADDR, (long)(p-i_start)); + INITRD_LOAD_ADDR, filesize); kvm->arch.initrd_gra = INITRD_LOAD_ADDR; - kvm->arch.initrd_size = p-i_start; + kvm->arch.initrd_size = filesize; } else { kvm->arch.initrd_size = 0; } -- 2.3.5
next prev parent reply other threads:[~2015-07-30 10:52 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-30 10:52 [PATCH 00/14] kvmtool: Refactor kernel image loading to allow pipes Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` [PATCH 01/14] Refactor kernel image loading Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` [PATCH 02/14] arm/powerpc: remove unneeded seeks in kernel loading Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` [PATCH 03/14] x86: allow pipes for bzImage kernel images Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` [PATCH 04/14] x86: support loading flat binary kernel images from a pipe Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` [PATCH 05/14] kvmtool: introduce pseek Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` [PATCH 06/14] MIPS: use pseek() in ELF kernel image loading Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` [PATCH 07/14] MIPS: move ELF headers loading outside of load_elf_binary() Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` [PATCH 08/14] MIPS: remove seeks from load_flat_binary() Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` [PATCH 09/14] arm: move kernel loading into arm/kvm.c Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` [PATCH 10/14] provide generic read_file() implementation Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` [PATCH 11/14] arm/arm64: use read_file() in kernel and initrd loading Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` Andre Przywara [this message] 2015-07-30 10:52 ` [PATCH 12/14] powerpc: " Andre Przywara 2015-07-30 10:52 ` [PATCH 13/14] MIPS: use read wrappers in kernel loading Andre Przywara 2015-07-30 10:52 ` Andre Przywara 2015-07-30 10:52 ` [PATCH 14/14] x86: " Andre Przywara 2015-07-30 10:52 ` Andre Przywara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1438253551-2378-13-git-send-email-andre.przywara@arm.com \ --to=andre.przywara@arm.com \ --cc=kvm-ppc@vger.kernel.org \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=marc.zyngier@arm.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.