From: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> To: Sangbeom Kim <sbkim73@samsung.com>, Krzysztof Kozlowski <k.kozlowski@samsung.com>, Lee Jones <lee.jones@linaro.org>, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, Kukjin Kim <kgene@kernel.org>, linux-arm-kernel@lists.infradead.org Cc: Anand Moon <linux.amoon@gmail.com>, Krzysztof Kozlowski <k.kozlowski.k@gmail.com> Subject: [PATCH 2/2] ARM: dts: Fix power off method on exynos5422-odroidxu3 Date: Mon, 3 Aug 2015 21:37:27 +0900 [thread overview] Message-ID: <1438605447-6836-3-git-send-email-k.kozlowski.k@gmail.com> (raw) In-Reply-To: <1438605447-6836-1-git-send-email-k.kozlowski.k@gmail.com> The Odroid XU3 family boards have ACOKB pin of PMIC grounded, instead of pulled up as usual. This means that PMIC must manually set PWRHOLD field in its CTRL1 register to low before initiating power down. This fixes Odroid XU3 powering off: [ 25.966053] reboot: Power down [ 25.967679] Power down. [ 26.070174] Power down failed, please power off system manually. Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> Reported-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi index 1565667e6f69..48cecc8cf26e 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi @@ -159,6 +159,7 @@ s2mps11,buck2-ramp-enable = <1>; s2mps11,buck3-ramp-enable = <1>; s2mps11,buck4-ramp-enable = <1>; + samsung,s2mps11-acokb-ground; interrupt-parent = <&gpx0>; interrupts = <4 IRQ_TYPE_EDGE_FALLING>; -- 2.1.4
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski.k@gmail.com (Krzysztof Kozlowski) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/2] ARM: dts: Fix power off method on exynos5422-odroidxu3 Date: Mon, 3 Aug 2015 21:37:27 +0900 [thread overview] Message-ID: <1438605447-6836-3-git-send-email-k.kozlowski.k@gmail.com> (raw) In-Reply-To: <1438605447-6836-1-git-send-email-k.kozlowski.k@gmail.com> The Odroid XU3 family boards have ACOKB pin of PMIC grounded, instead of pulled up as usual. This means that PMIC must manually set PWRHOLD field in its CTRL1 register to low before initiating power down. This fixes Odroid XU3 powering off: [ 25.966053] reboot: Power down [ 25.967679] Power down. [ 26.070174] Power down failed, please power off system manually. Signed-off-by: Krzysztof Kozlowski <k.kozlowski.k@gmail.com> Reported-by: Anand Moon <linux.amoon@gmail.com> --- arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi index 1565667e6f69..48cecc8cf26e 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi @@ -159,6 +159,7 @@ s2mps11,buck2-ramp-enable = <1>; s2mps11,buck3-ramp-enable = <1>; s2mps11,buck4-ramp-enable = <1>; + samsung,s2mps11-acokb-ground; interrupt-parent = <&gpx0>; interrupts = <4 IRQ_TYPE_EDGE_FALLING>; -- 2.1.4
next prev parent reply other threads:[~2015-08-03 12:39 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-08-03 12:37 [PATCH 0/2] mfd/EXYNOS: Properly shutdown Odroid XU3 Krzysztof Kozlowski 2015-08-03 12:37 ` Krzysztof Kozlowski 2015-08-03 12:37 ` [PATCH 1/2] mfd: s2mps11: Add manual shutdown method for " Krzysztof Kozlowski 2015-08-03 12:37 ` Krzysztof Kozlowski 2015-08-03 18:52 ` Anand Moon 2015-08-03 18:52 ` Anand Moon 2015-08-03 18:52 ` Anand Moon 2015-08-05 10:53 ` Javier Martinez Canillas 2015-08-05 10:53 ` Javier Martinez Canillas 2015-08-10 15:49 ` Lee Jones 2015-08-10 15:49 ` Lee Jones 2015-08-10 23:45 ` Krzysztof Kozlowski 2015-08-10 23:45 ` Krzysztof Kozlowski 2015-08-03 12:37 ` Krzysztof Kozlowski [this message] 2015-08-03 12:37 ` [PATCH 2/2] ARM: dts: Fix power off method on exynos5422-odroidxu3 Krzysztof Kozlowski 2015-08-05 10:54 ` Javier Martinez Canillas 2015-08-05 10:54 ` Javier Martinez Canillas
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1438605447-6836-3-git-send-email-k.kozlowski.k@gmail.com \ --to=k.kozlowski.k@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=k.kozlowski@samsung.com \ --cc=kgene@kernel.org \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=linux.amoon@gmail.com \ --cc=sbkim73@samsung.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.