From: mhocko@kernel.org
To: LKML <linux-kernel@vger.kernel.org>
Cc: <linux-mm@kvack.org>, <linux-fsdevel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Dave Chinner <david@fromorbit.com>,
"Theodore Ts'o" <tytso@mit.edu>,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
Jan Kara <jack@suse.cz>, Michal Hocko <mhocko@suse.com>
Subject: [RFC 3/8] mm: page_alloc: do not lock up GFP_NOFS allocations upon OOM
Date: Wed, 5 Aug 2015 11:51:19 +0200 [thread overview]
Message-ID: <1438768284-30927-4-git-send-email-mhocko@kernel.org> (raw)
In-Reply-To: <1438768284-30927-1-git-send-email-mhocko@kernel.org>
From: Johannes Weiner <hannes@cmpxchg.org>
GFP_NOFS allocations are not allowed to invoke the OOM killer since
their reclaim abilities are severely diminished. However, without the
OOM killer available there is no hope of progress once the reclaimable
pages have been exhausted.
Don't risk hanging these allocations. Leave it to the allocation site
to implement the fallback policy for failing allocations.
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
mm/page_alloc.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index ee69c338ca2a..024d45d51700 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -2715,15 +2715,8 @@ __alloc_pages_may_oom(gfp_t gfp_mask, unsigned int order,
if (ac->high_zoneidx < ZONE_NORMAL)
goto out;
/* The OOM killer does not compensate for IO-less reclaim */
- if (!(gfp_mask & __GFP_FS)) {
- /*
- * XXX: Page reclaim didn't yield anything,
- * and the OOM killer can't be invoked, but
- * keep looping as per tradition.
- */
- *did_some_progress = 1;
+ if (!(gfp_mask & __GFP_FS))
goto out;
- }
if (pm_suspended_storage())
goto out;
/* The OOM killer may not free memory on a specific node */
--
2.5.0
WARNING: multiple messages have this Message-ID (diff)
From: mhocko@kernel.org
To: LKML <linux-kernel@vger.kernel.org>
Cc: <linux-mm@kvack.org>, <linux-fsdevel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Dave Chinner <david@fromorbit.com>,
"Theodore Ts'o" <tytso@mit.edu>,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
Jan Kara <jack@suse.cz>, Michal Hocko <mhocko@suse.com>
Subject: [RFC 3/8] mm: page_alloc: do not lock up GFP_NOFS allocations upon OOM
Date: Wed, 5 Aug 2015 11:51:19 +0200 [thread overview]
Message-ID: <1438768284-30927-4-git-send-email-mhocko@kernel.org> (raw)
In-Reply-To: <1438768284-30927-1-git-send-email-mhocko@kernel.org>
From: Johannes Weiner <hannes@cmpxchg.org>
GFP_NOFS allocations are not allowed to invoke the OOM killer since
their reclaim abilities are severely diminished. However, without the
OOM killer available there is no hope of progress once the reclaimable
pages have been exhausted.
Don't risk hanging these allocations. Leave it to the allocation site
to implement the fallback policy for failing allocations.
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
mm/page_alloc.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index ee69c338ca2a..024d45d51700 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -2715,15 +2715,8 @@ __alloc_pages_may_oom(gfp_t gfp_mask, unsigned int order,
if (ac->high_zoneidx < ZONE_NORMAL)
goto out;
/* The OOM killer does not compensate for IO-less reclaim */
- if (!(gfp_mask & __GFP_FS)) {
- /*
- * XXX: Page reclaim didn't yield anything,
- * and the OOM killer can't be invoked, but
- * keep looping as per tradition.
- */
- *did_some_progress = 1;
+ if (!(gfp_mask & __GFP_FS))
goto out;
- }
if (pm_suspended_storage())
goto out;
/* The OOM killer may not free memory on a specific node */
--
2.5.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: mhocko@kernel.org
To: LKML <linux-kernel@vger.kernel.org>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Dave Chinner <david@fromorbit.com>, Theodore Ts'o <tytso@mit.edu>,
linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org,
Jan Kara <jack@suse.cz>, Michal Hocko <mhocko@suse.com>
Subject: [RFC 3/8] mm: page_alloc: do not lock up GFP_NOFS allocations upon OOM
Date: Wed, 5 Aug 2015 11:51:19 +0200 [thread overview]
Message-ID: <1438768284-30927-4-git-send-email-mhocko@kernel.org> (raw)
In-Reply-To: <1438768284-30927-1-git-send-email-mhocko@kernel.org>
From: Johannes Weiner <hannes@cmpxchg.org>
GFP_NOFS allocations are not allowed to invoke the OOM killer since
their reclaim abilities are severely diminished. However, without the
OOM killer available there is no hope of progress once the reclaimable
pages have been exhausted.
Don't risk hanging these allocations. Leave it to the allocation site
to implement the fallback policy for failing allocations.
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Michal Hocko <mhocko@suse.com>
---
mm/page_alloc.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index ee69c338ca2a..024d45d51700 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -2715,15 +2715,8 @@ __alloc_pages_may_oom(gfp_t gfp_mask, unsigned int order,
if (ac->high_zoneidx < ZONE_NORMAL)
goto out;
/* The OOM killer does not compensate for IO-less reclaim */
- if (!(gfp_mask & __GFP_FS)) {
- /*
- * XXX: Page reclaim didn't yield anything,
- * and the OOM killer can't be invoked, but
- * keep looping as per tradition.
- */
- *did_some_progress = 1;
+ if (!(gfp_mask & __GFP_FS))
goto out;
- }
if (pm_suspended_storage())
goto out;
/* The OOM killer may not free memory on a specific node */
--
2.5.0
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-08-05 9:51 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-05 9:51 [RFC 0/8] Allow GFP_NOFS allocation to fail mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 9:51 ` [RFC 1/8] mm, oom: Give __GFP_NOFAIL allocations access to memory reserves mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 9:51 ` [RFC 2/8] mm: Allow GFP_IOFS for page_cache_read page cache allocation mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 9:51 ` mhocko [this message]
2015-08-05 9:51 ` [RFC 3/8] mm: page_alloc: do not lock up GFP_NOFS allocations upon OOM mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 12:28 ` Tetsuo Handa
2015-08-05 14:02 ` Michal Hocko
2015-08-06 11:50 ` Tetsuo Handa
2015-08-12 9:11 ` Michal Hocko
2015-08-16 14:04 ` Tetsuo Handa
2015-08-05 9:51 ` [RFC 4/8] jbd, jbd2: Do not fail journal because of frozen_buffer allocation failure mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 11:42 ` Jan Kara
2015-08-05 11:42 ` Jan Kara
2015-08-05 16:49 ` Greg Thelen
2015-08-05 16:49 ` Greg Thelen
2015-08-12 9:14 ` Michal Hocko
2015-08-12 9:14 ` Michal Hocko
2015-08-15 13:54 ` Theodore Ts'o
2015-08-15 13:54 ` Theodore Ts'o
2015-08-18 10:36 ` Michal Hocko
2015-08-18 10:36 ` Michal Hocko
2015-08-24 12:06 ` Michal Hocko
2015-08-24 12:06 ` Michal Hocko
2015-08-18 10:38 ` [RFC -v2 " Michal Hocko
2015-08-18 10:38 ` Michal Hocko
2016-03-13 21:37 ` Theodore Ts'o
2015-08-05 9:51 ` [RFC 5/8] ext4: Do not fail journal due to block allocator mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 11:43 ` Jan Kara
2015-08-05 11:43 ` Jan Kara
2015-08-18 10:39 ` [RFC -v2 " Michal Hocko
2015-08-18 10:39 ` Michal Hocko
2015-08-18 10:55 ` Michal Hocko
2015-08-18 10:55 ` Michal Hocko
2015-08-05 9:51 ` [RFC 6/8] ext3: Do not abort journal prematurely mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 9:51 ` mhocko
2015-08-18 10:39 ` [RFC -v2 " Michal Hocko
2015-08-18 10:39 ` Michal Hocko
2015-08-05 9:51 ` [RFC 7/8] btrfs: Prevent from early transaction abort mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 16:31 ` David Sterba
2015-08-05 16:31 ` David Sterba
2015-08-18 10:40 ` [RFC -v2 " Michal Hocko
2015-08-18 10:40 ` Michal Hocko
2015-08-18 11:01 ` Michal Hocko
2015-08-18 11:01 ` Michal Hocko
2015-08-18 11:01 ` Michal Hocko
2015-08-18 17:11 ` Chris Mason
2015-08-18 17:11 ` Chris Mason
2015-08-18 17:11 ` Chris Mason
2015-08-18 17:29 ` Michal Hocko
2015-08-18 17:29 ` Michal Hocko
2015-08-19 12:26 ` Michal Hocko
2015-08-19 12:26 ` Michal Hocko
2015-08-05 9:51 ` [RFC 8/8] btrfs: use __GFP_NOFAIL in alloc_btrfs_bio mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 9:51 ` mhocko
2015-08-05 16:32 ` David Sterba
2015-08-05 16:32 ` David Sterba
2015-08-18 10:41 ` [RFC -v2 " Michal Hocko
2015-08-18 10:41 ` Michal Hocko
2015-08-05 19:58 ` [RFC 0/8] Allow GFP_NOFS allocation to fail Andreas Dilger
2015-08-05 19:58 ` Andreas Dilger
2015-08-06 14:34 ` Michal Hocko
2015-08-06 14:34 ` Michal Hocko
2015-08-06 14:34 ` Michal Hocko
2015-09-07 16:51 ` Tetsuo Handa
2015-09-07 16:51 ` Tetsuo Handa
2015-09-15 13:16 ` Tetsuo Handa
2015-09-15 13:16 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438768284-30927-4-git-send-email-mhocko@kernel.org \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=hannes@cmpxchg.org \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.