From: Yibo Zhao <yiboz@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Ben Greear <greearb@candelatech.com>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
Zhi Chen <zhichen@codeaurora.org>
Subject: Re: [PATCH v2] mac80211: remove warning message
Date: Fri, 14 Jun 2019 10:52:29 +0800 [thread overview]
Message-ID: <143d044082b54b2be41ba3760390d97f@codeaurora.org> (raw)
In-Reply-To: <bbfd69ccb4289ba3f1767c1066f61ee1@codeaurora.org>
On 2019-05-20 21:56, Yibo Zhao wrote:
> On 2019-05-15 02:57, Johannes Berg wrote:
>> On Tue, 2019-05-14 at 11:54 -0700, Ben Greear wrote:
>>>
>>> Here is the info I have in my commit that changed this to
>>> WARN_ON_ONCE.
>>> I never posted it because I had to hack ath10k to get to this state,
>>> so maybe
>>> this is not a valid case to debug.
>>>
>>>
>>> Maybe Yibo Zhao has a better example.
>>>
>>> mac80211: don't spam kernel logs when chantx is null.
>>>
>>> I set up ath10k to be chandef based again in order to test
>>> WDS. My WDS stations are not very functional yet, and
>>> when ethtool stats are queried, there is a WARN_ON splat
>>> generated. Change this to WARN_ON_ONCE so that there is
>>> less kernel spam.
>>
>> I'm totally fine with WARN_ON_ONCE, FWIW.
>>
>> Sounds like different bugs though. You're talking about WDS here, and
>> Yibo was talking about something with AP interfaces prematurely
>> accepting frames or so.
>
> Yes, they might be different bugs that hit the same point. Looks like
> others found this too many warnings issue as well. Then I believe
> WARN_ON_ONCE() seems to be our solution for now.
>
Hi Johannes,
May I know if it is fine that WARN_ON_ONCE() to be applied in kernel in
the future? If a separate patch for it is needed, please let me know so
that I can raise a new one.
>>
>> johannes
--
Yibo
WARNING: multiple messages have this Message-ID (diff)
From: Yibo Zhao <yiboz@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Zhi Chen <zhichen@codeaurora.org>,
Ben Greear <greearb@candelatech.com>,
linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2] mac80211: remove warning message
Date: Fri, 14 Jun 2019 10:52:29 +0800 [thread overview]
Message-ID: <143d044082b54b2be41ba3760390d97f@codeaurora.org> (raw)
In-Reply-To: <bbfd69ccb4289ba3f1767c1066f61ee1@codeaurora.org>
On 2019-05-20 21:56, Yibo Zhao wrote:
> On 2019-05-15 02:57, Johannes Berg wrote:
>> On Tue, 2019-05-14 at 11:54 -0700, Ben Greear wrote:
>>>
>>> Here is the info I have in my commit that changed this to
>>> WARN_ON_ONCE.
>>> I never posted it because I had to hack ath10k to get to this state,
>>> so maybe
>>> this is not a valid case to debug.
>>>
>>>
>>> Maybe Yibo Zhao has a better example.
>>>
>>> mac80211: don't spam kernel logs when chantx is null.
>>>
>>> I set up ath10k to be chandef based again in order to test
>>> WDS. My WDS stations are not very functional yet, and
>>> when ethtool stats are queried, there is a WARN_ON splat
>>> generated. Change this to WARN_ON_ONCE so that there is
>>> less kernel spam.
>>
>> I'm totally fine with WARN_ON_ONCE, FWIW.
>>
>> Sounds like different bugs though. You're talking about WDS here, and
>> Yibo was talking about something with AP interfaces prematurely
>> accepting frames or so.
>
> Yes, they might be different bugs that hit the same point. Looks like
> others found this too many warnings issue as well. Then I believe
> WARN_ON_ONCE() seems to be our solution for now.
>
Hi Johannes,
May I know if it is fine that WARN_ON_ONCE() to be applied in kernel in
the future? If a separate patch for it is needed, please let me know so
that I can raise a new one.
>>
>> johannes
--
Yibo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-06-14 2:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 9:01 [PATCH v2] mac80211: remove warning message Yibo Zhao
2019-05-14 9:01 ` Yibo Zhao
2019-05-14 9:05 ` Johannes Berg
2019-05-14 9:05 ` Johannes Berg
2019-05-14 9:10 ` Yibo Zhao
2019-05-14 9:10 ` Yibo Zhao
2019-05-14 9:12 ` Johannes Berg
2019-05-14 9:12 ` Johannes Berg
2019-05-14 15:44 ` Joe Perches
2019-05-14 15:44 ` Joe Perches
2019-05-14 17:55 ` Ben Greear
2019-05-14 17:55 ` Ben Greear
2019-05-14 18:40 ` Johannes Berg
2019-05-14 18:40 ` Johannes Berg
2019-05-14 18:54 ` Ben Greear
2019-05-14 18:54 ` Ben Greear
2019-05-14 18:57 ` Johannes Berg
2019-05-14 18:57 ` Johannes Berg
2019-05-20 13:56 ` Yibo Zhao
2019-05-20 13:56 ` Yibo Zhao
2019-06-14 2:52 ` Yibo Zhao [this message]
2019-06-14 2:52 ` Yibo Zhao
2019-06-14 7:22 ` Johannes Berg
2019-06-14 7:22 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=143d044082b54b2be41ba3760390d97f@codeaurora.org \
--to=yiboz@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=zhichen@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.