Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code

From: Toshi Kani <toshi.kani@hp.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "hch@lst.de" <hch@lst.de>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"mingo@kernel.org" <mingo@kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"hpa@zytor.com" <hpa@zytor.com>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"mingo@redhat.com" <mingo@redhat.com>,
	"ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>,
	"boaz@plexistor.com" <boaz@plexistor.com>,
	"david@fromorbit.com" <david@fromorbit.com>
Subject: Re: [PATCH v2 5/9] x86, pmem: push fallback handling to arch code
Date: Fri, 28 Aug 2015 15:48:26 -0600	[thread overview]
Message-ID: <1440798506.14237.107.camel@hp.com> (raw)
In-Reply-To: <CAPcyv4iaado-ARQ4z=4jCYH3n7x5+pNsbDjd9XkWyiu=aFyBWA@mail.gmail.com>

On Fri, 2015-08-28 at 14:47 -0700, Dan Williams wrote:
> On Fri, Aug 28, 2015 at 2:41 PM, Toshi Kani <toshi.kani@hp.com> wrote:
> > On Wed, 2015-08-26 at 21:34 +0000, Williams, Dan J wrote:
> [..]
> > > -#define ARCH_MEMREMAP_PMEM MEMREMAP_WB
> > 
> > Should it be better to do:
> > 
> > #else   /* !CONFIG_ARCH_HAS_PMEM_API */
> > #define ARCH_MEMREMAP_PMEM MEMREMAP_WT
> > 
> > so that you can remove all '#ifdef ARCH_MEMREMAP_PMEM' stuff?
> 
> Yeah, that seems like a nice incremental cleanup for memremap_pmem()
> to just unconditionally use ARCH_MEMREMAP_PMEM, feel free to send it
> along.

OK. Will do.

Thanks,
-Toshi

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>