From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH] f2fs: should get a victim from retrials
Date: Mon, 21 Sep 2015 12:12:57 -0700 [thread overview]
Message-ID: <1442862777-22537-1-git-send-email-jaegeuk@kernel.org> (raw)
If we do not call get_victim first, we cannot get a new victim for retrial
path.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/gc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 782b8e7..e932740 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -823,7 +823,8 @@ gc_more:
write_checkpoint(sbi, &cpc);
}
- if (segno == NULL_SEGNO && !__get_victim(sbi, &segno, gc_type))
+ /* should call __get_victim first to get a victim from retrial path */
+ if (!__get_victim(sbi, &segno, gc_type) && segno == NULL_SEGNO)
goto stop;
ret = 0;
--
2.1.1
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH] f2fs: should get a victim from retrials
Date: Mon, 21 Sep 2015 12:12:57 -0700 [thread overview]
Message-ID: <1442862777-22537-1-git-send-email-jaegeuk@kernel.org> (raw)
If we do not call get_victim first, we cannot get a new victim for retrial
path.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/gc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 782b8e7..e932740 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -823,7 +823,8 @@ gc_more:
write_checkpoint(sbi, &cpc);
}
- if (segno == NULL_SEGNO && !__get_victim(sbi, &segno, gc_type))
+ /* should call __get_victim first to get a victim from retrial path */
+ if (!__get_victim(sbi, &segno, gc_type) && segno == NULL_SEGNO)
goto stop;
ret = 0;
--
2.1.1
------------------------------------------------------------------------------
next reply other threads:[~2015-09-21 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-21 19:12 Jaegeuk Kim [this message]
2015-09-21 19:12 ` [PATCH] f2fs: should get a victim from retrials Jaegeuk Kim
2015-09-28 21:43 ` [PATCH v2] " Jaegeuk Kim
2015-09-30 9:00 ` [f2fs-dev] " Chao Yu
2015-09-30 9:00 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442862777-22537-1-git-send-email-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.