From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Theodore Ts'o" <tytso@mit.edu>, Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, lizefan@huawei.com,
cgroups@vger.kernel.org, hannes@cmpxchg.org, kernel-team@fb.com,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: implement cgroup writeback support
Date: Wed, 23 Sep 2015 15:49:12 +0300 [thread overview]
Message-ID: <1443012552.19983.209.camel@gmail.com> (raw)
In-Reply-To: <20150722035620.GD2944@thunk.org>
On Tue, 2015-07-21 at 23:56 -0400, Theodore Ts'o wrote:
> > v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB.
> >
> > Signed-off-by: Tejun Heo <tj@kernel.org>
> > Cc: "Theodore Ts'o" <tytso@mit.edu>
> > Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> > Cc: linux-ext4@vger.kernel.org
>
> Thanks, applied.
Hi, this patch introduces a regression - a major one, I'd say.
Symptoms: copy a bunch of file, run sync, then run 'reboot', and after
you boot up the copied files are corrupted. So basically the user
-visible symptom is that 'sync' does not work.
I quite an effort to bisect it, but it led me to this patch.
If I take the latest upstream (v4.3-rc2+), and revert this patch:
001e4a8 ext4: imlpement cgroup writeback support
then the problem goes away - files are not corrupted after reboot.
I use ext4 on top of a "bare" partition, no LVM or dm layers involved.
I use Fedora 22 with all the latest package updates, and I only change
the kernel there.
The corruption seems to be that the start with a bunch of zeroes
instead of the real data, but I did not check carefully, looked only at
one file briefly.
Artem.
next prev parent reply other threads:[~2015-09-23 12:49 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 22:53 [PATCHSET v2 block/for-4.2/writeback] ext4: implement cgroup writeback support Tejun Heo
2015-06-16 22:53 ` Tejun Heo
2015-06-16 22:53 ` [PATCH 1/2] ext4: replace ext4_io_submit->io_op with ->io_wbc Tejun Heo
2015-07-22 3:56 ` Theodore Ts'o
2015-07-22 3:56 ` Theodore Ts'o
2015-06-16 22:53 ` [PATCH 2/2] ext4: implement cgroup writeback support Tejun Heo
2015-07-22 3:56 ` Theodore Ts'o
2015-07-22 3:56 ` Theodore Ts'o
2015-09-23 12:49 ` Artem Bityutskiy [this message]
2015-09-23 13:50 ` Artem Bityutskiy
2015-09-23 17:02 ` Theodore Ts'o
2015-09-23 17:57 ` Tejun Heo
2015-09-23 17:25 ` Chris Mason
2015-09-23 17:25 ` Chris Mason
[not found] ` <CAF4G-tKEcnVw76-ZU77AjmBDGybLnNEOKjkJtYBN67es0wb30g@mail.gmail.com>
2015-09-23 17:53 ` Chris Mason
2015-09-23 17:53 ` Chris Mason
2015-09-23 18:24 ` Theodore Ts'o
[not found] ` <CAF4G-t+E89a_A3RzQYB9wXxqE6nM0t7wN6fNmLABZ70=ivHTRQ@mail.gmail.com>
2015-09-23 19:47 ` Artem Bityutskiy
2015-09-23 19:47 ` Artem Bityutskiy
2015-09-23 20:48 ` Theodore Ts'o
2015-09-24 8:13 ` Artem Bityutskiy
2015-09-23 19:03 ` Tejun Heo
2015-09-23 19:03 ` Tejun Heo
2015-09-23 18:09 ` Tejun Heo
2015-09-23 18:09 ` Tejun Heo
2015-09-23 18:51 ` Tejun Heo
2015-09-23 18:51 ` Tejun Heo
2015-09-23 21:07 ` [PATCH cgroup/for-4.3-fixes] cgroup, writeback: don't enable cgroup writeback on traditional hierarchies Tejun Heo
2015-09-24 8:09 ` Artem Bityutskiy
2015-09-24 8:40 ` Dexuan Cui
2015-09-24 8:40 ` Dexuan Cui
2015-09-24 20:47 ` Tejun Heo
2015-09-24 20:47 ` Tejun Heo
2015-09-28 21:39 ` Tejun Heo
2015-09-24 20:45 ` Tejun Heo
2015-09-24 20:45 ` Tejun Heo
2015-09-25 6:49 ` Artem Bityutskiy
2015-09-25 6:49 ` Artem Bityutskiy
2015-09-25 10:50 ` Artem Bityutskiy
2015-09-25 10:50 ` Artem Bityutskiy
2015-09-25 15:49 ` Tejun Heo
2015-09-26 8:06 ` Artem Bityutskiy
2015-09-26 22:14 ` Tejun Heo
2015-09-29 11:37 ` Artem Bityutskiy
2015-09-29 11:37 ` Artem Bityutskiy
2015-09-29 14:26 ` Tejun Heo
2015-09-24 16:17 ` Jens Axboe
2015-09-24 16:17 ` Jens Axboe
2015-09-24 16:17 ` Jens Axboe
2015-09-24 20:48 ` Tejun Heo
2015-07-12 18:05 ` [PATCHSET v2 block/for-4.2/writeback] ext4: implement cgroup writeback support Tejun Heo
2015-07-16 19:40 ` Tejun Heo
2015-07-16 19:40 ` Tejun Heo
2015-07-16 23:21 ` Dave Chinner
2015-07-16 23:37 ` Tejun Heo
2015-07-17 1:37 ` Theodore Ts'o
2015-07-17 1:37 ` Theodore Ts'o
2015-07-17 15:20 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2015-06-12 22:02 [PATCHSET " Tejun Heo
2015-06-12 22:02 ` [PATCH 2/2] " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443012552.19983.209.camel@gmail.com \
--to=dedekind1@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=tj@kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.