From: "Theodore Ts'o" <tytso@mit.edu>
To: Tejun Heo <tj@kernel.org>
Cc: axboe@kernel.dk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, lizefan@huawei.com,
cgroups@vger.kernel.org, hannes@cmpxchg.org, kernel-team@fb.com,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: implement cgroup writeback support
Date: Tue, 21 Jul 2015 23:56:20 -0400 [thread overview]
Message-ID: <20150722035620.GD2944@thunk.org> (raw)
In-Reply-To: <1434495193-31182-3-git-send-email-tj@kernel.org>
On Tue, Jun 16, 2015 at 06:53:13PM -0400, Tejun Heo wrote:
> For ordered and writeback data modes, all data IOs go through
> ext4_io_submit. This patch adds cgroup writeback support by invoking
> wbc_init_bio() from io_submit_init_bio() and wbc_account_io() in
> io_submit_add_bh(). Journal data which is written by jbd2 worker is
> left alone by this patch and will always be written out from the root
> cgroup.
>
> ext4_fill_super() is updated to set MS_CGROUPWB when data mode is
> either ordered or writeback. In journaled data mode, most IOs become
> synchronous through the journal and enabling cgroup writeback support
> doesn't make much sense or difference. Journaled data mode is left
> alone.
>
> Lightly tested with sequential data write workload. Behaves as
> expected.
>
> v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: "Theodore Ts'o" <tytso@mit.edu>
> Cc: Andreas Dilger <adilger.kernel@dilger.ca>
> Cc: linux-ext4@vger.kernel.org
Thanks, applied.
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso-3s7WtUTddSA@public.gmane.org>
To: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org,
cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org,
kernel-team-b10kYP2dOMg@public.gmane.org,
adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/2] ext4: implement cgroup writeback support
Date: Tue, 21 Jul 2015 23:56:20 -0400 [thread overview]
Message-ID: <20150722035620.GD2944@thunk.org> (raw)
In-Reply-To: <1434495193-31182-3-git-send-email-tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
On Tue, Jun 16, 2015 at 06:53:13PM -0400, Tejun Heo wrote:
> For ordered and writeback data modes, all data IOs go through
> ext4_io_submit. This patch adds cgroup writeback support by invoking
> wbc_init_bio() from io_submit_init_bio() and wbc_account_io() in
> io_submit_add_bh(). Journal data which is written by jbd2 worker is
> left alone by this patch and will always be written out from the root
> cgroup.
>
> ext4_fill_super() is updated to set MS_CGROUPWB when data mode is
> either ordered or writeback. In journaled data mode, most IOs become
> synchronous through the journal and enabling cgroup writeback support
> doesn't make much sense or difference. Journaled data mode is left
> alone.
>
> Lightly tested with sequential data write workload. Behaves as
> expected.
>
> v2: Updated for MS_CGROUPWB -> SB_I_CGROUPWB.
>
> Signed-off-by: Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> Cc: "Theodore Ts'o" <tytso-3s7WtUTddSA@public.gmane.org>
> Cc: Andreas Dilger <adilger.kernel-m1MBpc4rdrD3fQ9qLvQP4Q@public.gmane.org>
> Cc: linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Thanks, applied.
- Ted
next prev parent reply other threads:[~2015-07-22 3:56 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 22:53 [PATCHSET v2 block/for-4.2/writeback] ext4: implement cgroup writeback support Tejun Heo
2015-06-16 22:53 ` Tejun Heo
2015-06-16 22:53 ` [PATCH 1/2] ext4: replace ext4_io_submit->io_op with ->io_wbc Tejun Heo
2015-07-22 3:56 ` Theodore Ts'o
2015-07-22 3:56 ` Theodore Ts'o
2015-06-16 22:53 ` [PATCH 2/2] ext4: implement cgroup writeback support Tejun Heo
2015-07-22 3:56 ` Theodore Ts'o [this message]
2015-07-22 3:56 ` Theodore Ts'o
2015-09-23 12:49 ` Artem Bityutskiy
2015-09-23 13:50 ` Artem Bityutskiy
2015-09-23 17:02 ` Theodore Ts'o
2015-09-23 17:57 ` Tejun Heo
2015-09-23 17:25 ` Chris Mason
2015-09-23 17:25 ` Chris Mason
[not found] ` <CAF4G-tKEcnVw76-ZU77AjmBDGybLnNEOKjkJtYBN67es0wb30g@mail.gmail.com>
2015-09-23 17:53 ` Chris Mason
2015-09-23 17:53 ` Chris Mason
2015-09-23 18:24 ` Theodore Ts'o
[not found] ` <CAF4G-t+E89a_A3RzQYB9wXxqE6nM0t7wN6fNmLABZ70=ivHTRQ@mail.gmail.com>
2015-09-23 19:47 ` Artem Bityutskiy
2015-09-23 19:47 ` Artem Bityutskiy
2015-09-23 20:48 ` Theodore Ts'o
2015-09-24 8:13 ` Artem Bityutskiy
2015-09-23 19:03 ` Tejun Heo
2015-09-23 19:03 ` Tejun Heo
2015-09-23 18:09 ` Tejun Heo
2015-09-23 18:09 ` Tejun Heo
2015-09-23 18:51 ` Tejun Heo
2015-09-23 18:51 ` Tejun Heo
2015-09-23 21:07 ` [PATCH cgroup/for-4.3-fixes] cgroup, writeback: don't enable cgroup writeback on traditional hierarchies Tejun Heo
2015-09-24 8:09 ` Artem Bityutskiy
2015-09-24 8:40 ` Dexuan Cui
2015-09-24 8:40 ` Dexuan Cui
2015-09-24 20:47 ` Tejun Heo
2015-09-24 20:47 ` Tejun Heo
2015-09-28 21:39 ` Tejun Heo
2015-09-24 20:45 ` Tejun Heo
2015-09-24 20:45 ` Tejun Heo
2015-09-25 6:49 ` Artem Bityutskiy
2015-09-25 6:49 ` Artem Bityutskiy
2015-09-25 10:50 ` Artem Bityutskiy
2015-09-25 10:50 ` Artem Bityutskiy
2015-09-25 15:49 ` Tejun Heo
2015-09-26 8:06 ` Artem Bityutskiy
2015-09-26 22:14 ` Tejun Heo
2015-09-29 11:37 ` Artem Bityutskiy
2015-09-29 11:37 ` Artem Bityutskiy
2015-09-29 14:26 ` Tejun Heo
2015-09-24 16:17 ` Jens Axboe
2015-09-24 16:17 ` Jens Axboe
2015-09-24 16:17 ` Jens Axboe
2015-09-24 20:48 ` Tejun Heo
2015-07-12 18:05 ` [PATCHSET v2 block/for-4.2/writeback] ext4: implement cgroup writeback support Tejun Heo
2015-07-16 19:40 ` Tejun Heo
2015-07-16 19:40 ` Tejun Heo
2015-07-16 23:21 ` Dave Chinner
2015-07-16 23:37 ` Tejun Heo
2015-07-17 1:37 ` Theodore Ts'o
2015-07-17 1:37 ` Theodore Ts'o
2015-07-17 15:20 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2015-06-12 22:02 [PATCHSET " Tejun Heo
2015-06-12 22:02 ` [PATCH 2/2] " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722035620.GD2944@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.