All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shashank Sharma <shashank.sharma@intel.com>
To: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	emil.l.velikov@gmail.com, matthew.d.roper@intel.com,
	robert.bradford@intel.com, jim.bish@intel.com
Cc: annie.j.matheson@intel.com, kausalmalladi@gmail.com,
	daniel.vetter@intel.com
Subject: [PATCH v7 02/25] drm: Create Color Management query properties
Date: Tue, 20 Oct 2015 18:04:29 +0530	[thread overview]
Message-ID: <1445344492-8296-3-git-send-email-shashank.sharma@intel.com> (raw)
In-Reply-To: <1445344492-8296-1-git-send-email-shashank.sharma@intel.com>

DRM color management is written to extract the color correction
capabilities of various platforms, and every platform can showcase
its capabilities using the query properties.

Different hardwares can have different no of coefficients for palette
correction. Also the correction can be applied after/before color
transformation (CTM) unit in the display pipeline.

This patch adds two new read-only properties,
  - cm_coeff_before_ctm_property: A platform driver should use this
    property to show supported no_of_coefficients for palette correction,
    which gets applied before ctm correction.
  - cm_coeff_after_ctm_property: A platform driver should use this property
    to show supported no_of_coefficients for palette correction, which gets
    applied after ctm correction.

Signed-off-by: Shashank Sharma <shashank.sharma@intel.com>
---
 drivers/gpu/drm/drm_crtc.c | 13 +++++++++++++
 include/drm/drm_crtc.h     |  4 ++++
 2 files changed, 17 insertions(+)

diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c
index cee1415..b342d45 100644
--- a/drivers/gpu/drm/drm_crtc.c
+++ b/drivers/gpu/drm/drm_crtc.c
@@ -1489,6 +1489,19 @@ static int drm_mode_create_standard_properties(struct drm_device *dev)
 		return -ENOMEM;
 	dev->mode_config.cm_ctm_property = prop;
 
+	/* DRM properties to query color capabilities */
+	prop = drm_property_create(dev, DRM_MODE_PROP_IMMUTABLE,
+			"COEFFICIENTS_BEFORE_CTM", 0);
+	if (!prop)
+		return -ENOMEM;
+	dev->mode_config.cm_coeff_before_ctm_property = prop;
+
+	prop = drm_property_create(dev, DRM_MODE_PROP_IMMUTABLE,
+			"COEFFICIENTS_AFTER_CTM", 0);
+	if (!prop)
+		return -ENOMEM;
+	dev->mode_config.cm_coeff_after_ctm_property = prop;
+
 	return 0;
 }
 
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
index 4225341..f58b595 100644
--- a/include/drm/drm_crtc.h
+++ b/include/drm/drm_crtc.h
@@ -1148,6 +1148,10 @@ struct drm_mode_config {
 	struct drm_property *cm_palette_after_ctm_property;
 	struct drm_property *cm_ctm_property;
 
+	/* Color management capabilities query */
+	struct drm_property *cm_coeff_before_ctm_property;
+	struct drm_property *cm_coeff_after_ctm_property;
+
 	/* dumb ioctl parameters */
 	uint32_t preferred_depth, prefer_shadow;
 
-- 
1.9.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  parent reply	other threads:[~2015-10-20 12:34 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 12:34 [PATCH v7 00/25] Color Management for DRM framework Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 01/25] drm: Create Color Management DRM properties Shashank Sharma
2015-10-20 12:34 ` Shashank Sharma [this message]
2015-10-20 12:34 ` [PATCH v7 03/25] drm: Add color correction blobs in CRTC state Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 04/25] drm: Add set property support for color manager Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 05/25] drm: Add get " Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 06/25] drm: Add drm structures for palette color property Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 07/25] drm: Add structure for CTM " Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 08/25] drm: Add color correction state flag Shashank Sharma
2015-10-20 13:58   ` [Intel-gfx] " kbuild test robot
2015-10-29 15:42     ` FW: " Sharma, Shashank
2015-10-30  9:54       ` Jani Nikula
2015-10-20 12:34 ` [PATCH v7 09/25] drm/i915: Add set property interface for CRTC Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 10/25] drm/i915: Create color management files Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 11/25] drm/i915: Register color correction capabilities Shashank Sharma
2015-10-21 23:19   ` Bish, Jim
2015-10-22  7:19     ` Daniel Vetter
2015-10-22 12:05     ` Rob Bradford
2015-10-26  3:59       ` Sharma, Shashank
2015-10-20 12:34 ` [PATCH v7 12/25] drm/i915: CHV: Load gamma color correction values Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 13/25] drm/i915: CHV: Load degamma " Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 14/25] drm/i915: CHV: Pipe level Gamma correction Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 15/25] drm/i915: CHV: Pipe level degamma correction Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 16/25] drm/i915: CHV: Pipe level CSC correction Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 17/25] drm/i915: Commit color correction to CRTC Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 18/25] drm/i915: Attach color properties " Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 19/25] drm/i915: BDW: Load gamma correction values Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 20/25] drm/i915: BDW: Pipe level Gamma correction Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 21/25] drm/i915: BDW: Load degamma correction values Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 22/25] drm/i915: BDW: Pipe level degamma correction Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 23/25] drm/i915: BDW: Pipe level CSC correction Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 24/25] drm/i915: disable plane gamma Shashank Sharma
2015-10-20 12:34 ` [PATCH v7 25/25] drm/i915: Commit color correction only when needed Shashank Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445344492-8296-3-git-send-email-shashank.sharma@intel.com \
    --to=shashank.sharma@intel.com \
    --cc=annie.j.matheson@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jim.bish@intel.com \
    --cc=kausalmalladi@gmail.com \
    --cc=matthew.d.roper@intel.com \
    --cc=robert.bradford@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.