RE: [PATCH v7 11/25] drm/i915: Register color correction capabilities

From: "Sharma, Shashank" <shashank.sharma@intel.com>
To: "Bish, Jim" <jim.bish@intel.com>
Cc: "Matheson, Annie J" <annie.j.matheson@intel.com>,
	"Bradford, Robert" <robert.bradford@intel.com>,
	"Palleti, Avinash Reddy" <avinash.reddy.palleti@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"emil.l.velikov@gmail.com" <emil.l.velikov@gmail.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"Mukherjee, Indranil" <indranil.mukherjee@intel.com>,
	"kausalmalladi@gmail.com" <kausalmalladi@gmail.com>,
	"Smith, Gary K" <gary.k.smith@intel.com>,
	"Vetter, Daniel" <daniel.vetter@intel.com>,
	"Kumar, Kiran S" <kiran.s.kumar@intel.com>
Subject: RE: [PATCH v7 11/25] drm/i915: Register color correction capabilities
Date: Mon, 26 Oct 2015 03:59:56 +0000	[thread overview]
Message-ID: <FF3DDC77922A8A4BB08A3BC48A1EA8CB09A5F92C@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <1445515549.8573.21.camel@intel.com>

Thanks Daniel, Rob, for providing the clarification. 
Jim, Does this sound good to you, now ? 

Regards
Shashank
-----Original Message-----
From: Bradford, Robert 
Sent: Thursday, October 22, 2015 5:36 PM
To: Bish, Jim; Sharma, Shashank
Cc: Palleti, Avinash Reddy; kausalmalladi@gmail.com; intel-gfx@lists.freedesktop.org; emil.l.velikov@gmail.com; Smith, Gary K; Roper, Matthew D; Vetter, Daniel; dri-devel@lists.freedesktop.org; Mukherjee, Indranil; Matheson, Annie J; Kumar, Kiran S
Subject: Re: [PATCH v7 11/25] drm/i915: Register color correction capabilities

> > diff --git a/drivers/gpu/drm/i915/i915_drv.h 
> > b/drivers/gpu/drm/i915/i915_drv.h index 8afda45..613bee2 100644
> > --- a/drivers/gpu/drm/i915/i915_drv.h
> > +++ b/drivers/gpu/drm/i915/i915_drv.h
> > @@ -789,6 +789,8 @@ struct intel_device_info {
> >       u8 num_sprites[I915_MAX_PIPES];
> >       u8 gen;
> >       u8 ring_mask; /* Rings supported by the HW */
> > +     u16 num_samples_after_ctm;
> > +     u16 num_samples_before_ctm;
> thought we agreed last week that num_samples was going to be removed.  
> May be ok to handle in a later patch unless someone has strong 
> objection.

This is for the reporting out of platform capability and is still needed as userspace needs to know the recommended table size so that it can resample as necessary.

Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel