All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@intel.com>
To: alsa-devel@alsa-project.org
Cc: patches.audio@intel.com, broonie@kernel.org,
	liam.r.girdwood@linux.intel.com,
	Vinod Koul <vinod.koul@intel.com>,
	Mythri P K <mythri.p.k@intel.com>, Jeeja KP <jeeja.kp@intel.com>
Subject: [PATCH 1/3] ASoC: dapm: Add kcontrol support for PGAs
Date: Tue, 20 Oct 2015 21:08:50 +0530	[thread overview]
Message-ID: <1445355532-28310-2-git-send-email-vinod.koul@intel.com> (raw)
In-Reply-To: <1445355532-28310-1-git-send-email-vinod.koul@intel.com>

From: Jeeja KP <jeeja.kp@intel.com>

For DSPs we can define processing blocks as DAPM PGA widgets.
Some of these proceesing blocks can be configured by usermode
like EQ etc. So we need to add support of kcontrol for PGA
widgets.

Signed-off-by: Jeeja KP <jeeja.kp@intel.com>
Signed-off-by: Mythri P K <mythri.p.k@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 sound/soc/soc-dapm.c | 22 +++++++++++++++-------
 1 file changed, 15 insertions(+), 7 deletions(-)

diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index ff8bda471b25..746800380eb7 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -779,8 +779,8 @@ static int dapm_is_shared_kcontrol(struct snd_soc_dapm_context *dapm,
  * Determine if a kcontrol is shared. If it is, look it up. If it isn't,
  * create it. Either way, add the widget into the control's widget list
  */
-static int dapm_create_or_share_mixmux_kcontrol(struct snd_soc_dapm_widget *w,
-	int kci)
+static int dapm_create_or_share_mixmuxpga_kcontrol(
+		struct snd_soc_dapm_widget *w, int kci)
 {
 	struct snd_soc_dapm_context *dapm = w->dapm;
 	struct snd_card *card = dapm->card->snd_card;
@@ -822,6 +822,10 @@ static int dapm_create_or_share_mixmux_kcontrol(struct snd_soc_dapm_widget *w,
 				wname_in_long_name = true;
 				kcname_in_long_name = false;
 				break;
+			case snd_soc_dapm_pga:
+				wname_in_long_name = true;
+				kcname_in_long_name = true;
+				break;
 			default:
 				return -EINVAL;
 			}
@@ -899,7 +903,7 @@ static int dapm_new_mixer(struct snd_soc_dapm_widget *w)
 				continue;
 
 			if (!w->kcontrols[i]) {
-				ret = dapm_create_or_share_mixmux_kcontrol(w, i);
+				ret = dapm_create_or_share_mixmuxpga_kcontrol(w, i);
 				if (ret < 0)
 					return ret;
 			}
@@ -952,7 +956,7 @@ static int dapm_new_mux(struct snd_soc_dapm_widget *w)
 		return -EINVAL;
 	}
 
-	ret = dapm_create_or_share_mixmux_kcontrol(w, 0);
+	ret = dapm_create_or_share_mixmuxpga_kcontrol(w, 0);
 	if (ret < 0)
 		return ret;
 
@@ -967,9 +971,13 @@ static int dapm_new_mux(struct snd_soc_dapm_widget *w)
 /* create new dapm volume control */
 static int dapm_new_pga(struct snd_soc_dapm_widget *w)
 {
-	if (w->num_kcontrols)
-		dev_err(w->dapm->dev,
-			"ASoC: PGA controls not supported: '%s'\n", w->name);
+	int i, ret;
+
+	for (i = 0; i < w->num_kcontrols; i++) {
+		ret = dapm_create_or_share_mixmuxpga_kcontrol(w, i);
+		if (ret < 0)
+			return ret;
+	}
 
 	return 0;
 }
-- 
1.9.1

  reply	other threads:[~2015-10-20 15:36 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 15:38 [PATCH 0/3] ASoC: dapm: add PGA kcontrol, dai_link enhancement & Vinod Koul
2015-10-20 15:38 ` Vinod Koul [this message]
2015-10-20 15:58   ` [PATCH 1/3] ASoC: dapm: Add kcontrol support for PGAs Lars-Peter Clausen
2015-10-20 16:46     ` Vinod Koul
2015-10-20 15:38 ` [PATCH 2/3] ASoC: dapm: Add startup & shutdown for dai_links Vinod Koul
2015-10-22 23:09   ` Applied "ASoC: dapm: Add startup & shutdown for dai_links" to the asoc tree Mark Brown
2015-10-20 15:38 ` [PATCH 3/3] ASoC: dapm: Add snd_soc_dapm_kcontrol_widget() Vinod Koul
2015-10-22 23:09   ` Applied "ASoC: dapm: Add snd_soc_dapm_kcontrol_widget()" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445355532-28310-2-git-send-email-vinod.koul@intel.com \
    --to=vinod.koul@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jeeja.kp@intel.com \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=mythri.p.k@intel.com \
    --cc=patches.audio@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.