Re: [PATCH 1/3] ASoC: dapm: Add kcontrol support for PGAs

From: Vinod Koul <vinod.koul@intel.com>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: alsa-devel@alsa-project.org, Mythri P K <mythri.p.k@intel.com>,
	patches.audio@intel.com, liam.r.girdwood@linux.intel.com,
	broonie@kernel.org, Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [PATCH 1/3] ASoC: dapm: Add kcontrol support for PGAs
Date: Tue, 20 Oct 2015 22:16:25 +0530	[thread overview]
Message-ID: <20151020164625.GD27370@localhost> (raw)
In-Reply-To: <562664B6.7090807@metafoo.de>

On Tue, Oct 20, 2015 at 05:58:46PM +0200, Lars-Peter Clausen wrote:
> > -static int dapm_create_or_share_mixmux_kcontrol(struct snd_soc_dapm_widget *w,
> > -	int kci)
> > +static int dapm_create_or_share_mixmuxpga_kcontrol(
> 
> ... but maybe just call it dapm_create_or_share_kcontrol()

I don't mind that

> 
> > +		struct snd_soc_dapm_widget *w, int kci)
> >  {
> >  	struct snd_soc_dapm_context *dapm = w->dapm;
> >  	struct snd_card *card = dapm->card->snd_card;
> > @@ -822,6 +822,10 @@ static int dapm_create_or_share_mixmux_kcontrol(struct snd_soc_dapm_widget *w,
> >  				wname_in_long_name = true;
> >  				kcname_in_long_name = false;
> >  				break;
> > +			case snd_soc_dapm_pga:
> 
> This should have the same behavior as mixers and switches, just add the case
> there instead having a different path.

Oh yes thanks for pointing out that makese better sense, will update in v2.

-- 
~Vinod