From: Jaegeuk Kim <jaegeuk@kernel.org> To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim <jaegeuk@kernel.org> Subject: [PATCH 3/3] Revert "f2fs: check the node block address of newly allocated nid" Date: Sat, 2 Jan 2016 17:26:06 -0800 [thread overview] Message-ID: <1451784366-14261-3-git-send-email-jaegeuk@kernel.org> (raw) In-Reply-To: <1451784366-14261-1-git-send-email-jaegeuk@kernel.org> Original issue is fixed by: f2fs: cover more area with nat_tree_lock This reverts commit 24928634f81b1592e83b37dcd89ed45c28f12feb. --- fs/f2fs/node.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 4dab09f..6d5f548 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1602,8 +1602,6 @@ retry: /* We should not use stale free nids created by build_free_nids */ if (nm_i->fcnt && !on_build_free_nids(nm_i)) { - struct node_info ni; - f2fs_bug_on(sbi, list_empty(&nm_i->free_nid_list)); list_for_each_entry(i, &nm_i->free_nid_list, list) if (i->state == NID_NEW) @@ -1614,13 +1612,6 @@ retry: i->state = NID_ALLOC; nm_i->fcnt--; spin_unlock(&nm_i->free_nid_list_lock); - - /* check nid is allocated already */ - get_node_info(sbi, *nid, &ni); - if (ni.blk_addr != NULL_ADDR) { - alloc_nid_done(sbi, *nid); - goto retry; - } return true; } spin_unlock(&nm_i->free_nid_list_lock); -- 2.6.3
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org> To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Cc: Jaegeuk Kim <jaegeuk@kernel.org> Subject: [PATCH 3/3] Revert "f2fs: check the node block address of newly allocated nid" Date: Sat, 2 Jan 2016 17:26:06 -0800 [thread overview] Message-ID: <1451784366-14261-3-git-send-email-jaegeuk@kernel.org> (raw) In-Reply-To: <1451784366-14261-1-git-send-email-jaegeuk@kernel.org> Original issue is fixed by: f2fs: cover more area with nat_tree_lock This reverts commit 24928634f81b1592e83b37dcd89ed45c28f12feb. --- fs/f2fs/node.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c index 4dab09f..6d5f548 100644 --- a/fs/f2fs/node.c +++ b/fs/f2fs/node.c @@ -1602,8 +1602,6 @@ retry: /* We should not use stale free nids created by build_free_nids */ if (nm_i->fcnt && !on_build_free_nids(nm_i)) { - struct node_info ni; - f2fs_bug_on(sbi, list_empty(&nm_i->free_nid_list)); list_for_each_entry(i, &nm_i->free_nid_list, list) if (i->state == NID_NEW) @@ -1614,13 +1612,6 @@ retry: i->state = NID_ALLOC; nm_i->fcnt--; spin_unlock(&nm_i->free_nid_list_lock); - - /* check nid is allocated already */ - get_node_info(sbi, *nid, &ni); - if (ni.blk_addr != NULL_ADDR) { - alloc_nid_done(sbi, *nid); - goto retry; - } return true; } spin_unlock(&nm_i->free_nid_list_lock); -- 2.6.3 ------------------------------------------------------------------------------
next prev parent reply other threads:[~2016-01-03 1:26 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-01-03 1:26 [PATCH 1/3] f2fs: check the page status filled from disk Jaegeuk Kim 2016-01-03 1:26 ` [PATCH 2/3] f2fs: cover more area with nat_tree_lock Jaegeuk Kim 2016-01-03 1:26 ` Jaegeuk Kim 2016-01-05 9:33 ` [f2fs-dev] " Chao Yu 2016-01-05 17:57 ` Jaegeuk Kim 2016-01-05 17:57 ` Jaegeuk Kim 2016-01-06 3:57 ` [f2fs-dev] " Chao Yu 2016-01-06 3:57 ` Chao Yu 2016-01-03 1:26 ` Jaegeuk Kim [this message] 2016-01-03 1:26 ` [PATCH 3/3] Revert "f2fs: check the node block address of newly allocated nid" Jaegeuk Kim 2016-01-05 9:31 ` [f2fs-dev] [PATCH 1/3] f2fs: check the page status filled from disk Chao Yu 2016-01-05 9:31 ` Chao Yu 2016-01-05 17:48 ` [f2fs-dev] " Jaegeuk Kim 2016-01-06 1:21 ` Chao Yu 2016-01-06 2:30 ` Jaegeuk Kim 2016-01-06 2:30 ` Jaegeuk Kim 2016-01-06 4:10 ` [PATCH 1/3 v2] " Jaegeuk Kim 2016-01-06 5:20 ` [f2fs-dev] " Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1451784366-14261-3-git-send-email-jaegeuk@kernel.org \ --to=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.