From: Ian Campbell <ian.campbell@citrix.com>
To: Doug Goldstein <cardoe@cardoe.com>, xen-devel@lists.xen.org
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH] arm: clean up build variables
Date: Mon, 25 Jan 2016 11:27:06 +0000 [thread overview]
Message-ID: <1453721226.4320.127.camel@citrix.com> (raw)
In-Reply-To: <1453326479-19885-1-git-send-email-cardoe@cardoe.com>
On Wed, 2016-01-20 at 15:47 -0600, Doug Goldstein wrote:
> This consolidates some of the different variables used for the ARM
> builds. This change was prompted by the Kconfig changes but looking back
> in time the CONFIG_ARM_{32,64} variables existed before Kconfig so this
> should just be a generic cleanup.
>
> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> ---
> xen/arch/arm/Makefile | 8 ++++----
> xen/arch/arm/Rules.mk | 18 ++++--------------
> xen/drivers/passthrough/Makefile | 2 +-
> 3 files changed, 9 insertions(+), 19 deletions(-)
>
> diff --git a/xen/arch/arm/Makefile b/xen/arch/arm/Makefile
> index 2f050f5..0d11c0f 100644
> --- a/xen/arch/arm/Makefile
> +++ b/xen/arch/arm/Makefile
> @@ -1,7 +1,7 @@
> -subdir-$(arm32) += arm32
> -subdir-$(arm64) += arm64
> +subdir-$(CONFIG_ARM_32) += arm32
> +subdir-$(CONFIG_ARM_64) += arm64
> subdir-y += platforms
> -subdir-$(arm64) += efi
> +subdir-$(CONFIG_ARM_64) += efi
>
> obj-$(EARLY_PRINTK) += early_printk.o
> obj-y += cpu.o
> @@ -52,7 +52,7 @@ ALL_OBJS := $(TARGET_SUBARCH)/head.o $(ALL_OBJS)
>
> $(TARGET): $(TARGET)-syms $(TARGET).axf
> $(OBJCOPY) -O binary -S $< $@
> -ifeq (arm64,$(XEN_TARGET_ARCH))
> +ifdef CONFIG_ARM_64
The old way looks to be the prevailing normal form. I don't especially
object to the change but things ought to remain consistent.
For the rest:
Acked-by: Ian Campbell < ian.campbell@citrix.com >
FYI I'm not committing things right now due to network issues between the
machine(s) I use for such things.
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-01-25 11:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 21:47 [PATCH] arm: clean up build variables Doug Goldstein
2016-01-21 10:56 ` Jan Beulich
2016-01-25 11:27 ` Ian Campbell [this message]
2016-01-27 14:30 ` Doug Goldstein
2016-01-27 14:44 ` Jan Beulich
2016-01-27 15:05 ` Ian Campbell
2016-01-27 15:11 ` Doug Goldstein
2016-01-27 15:24 ` Ian Campbell
2016-01-27 15:26 ` Doug Goldstein
2016-01-29 14:35 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453721226.4320.127.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=cardoe@cardoe.com \
--cc=jbeulich@suse.com \
--cc=stefano.stabellini@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.